tandraschko commented on issue #8: MYFACES-4239: Multiple performance
improvements
URL: https://github.com/apache/myfaces/pull/8#issuecomment-400075148
Yep! :)
This is an automated message from the Apache Git Service.
To
tandraschko commented on issue #8: MYFACES-4239: Multiple performance
improvements
URL: https://github.com/apache/myfaces/pull/8#issuecomment-399597447
I also thought a bit about it, i think it would be better if we discuss it
first on the mailing list.
And details about it would be gre
tandraschko commented on issue #8: MYFACES-4239: Multiple performance
improvements
URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465769
All other changes looks fine of course.
This is an automated message from
tandraschko commented on issue #8: MYFACES-4239: Multiple performance
improvements
URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655
JFYI: we avoided new objects so much in the past that we even switched from
for-each to for loops, so the SharedStringBuilder is IMO a mus
tandraschko commented on issue #8: MYFACES-4239: Multiple performance
improvements
URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464821
ok, i see
i'm ok for it if you use the SharedStringBuilder
This is an
tandraschko commented on issue #8: MYFACES-4239: Multiple performance
improvements
URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368
@pnicolucci i'm not sure about this changes out.write vs sb.append...
Why do you switchted from out.write to a new StringBuilder?