[ https://issues.apache.org/jira/browse/MYFACES-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601952#comment-17601952 ]
Paul Nicolucci commented on MYFACES-4454: ----------------------------------------- [~tandraschko] any objection to making the change in 2.3-next : [https://github.com/apache/myfaces/blob/2.3-next/api/src/main/java/javax/faces/context/ExternalContextWrapper.java#L147] The other change for this in 4.0 doesn't look to exist in 2.3-next: [https://github.com/apache/myfaces/blob/2.3-next/api/src/main/java/javax/faces/render/Renderer.java#L144] (still uses UIComponent correctly vs T) > TCK:SigTest failures: Added Methods > ----------------------------------- > > Key: MYFACES-4454 > URL: https://issues.apache.org/jira/browse/MYFACES-4454 > Project: MyFaces Core > Issue Type: Bug > Components: General > Affects Versions: 4.0.0-RC1 > Reporter: Paul Nicolucci > Assignee: Paul Nicolucci > Priority: Major > Fix For: 4.0.0-RC2 > > > 1) ExternalContextWrapper.getInitParameterMap() was updated here: > [https://github.com/apache/myfaces/commit/e5cfa71ef2ceeeee68769befcb8f2f40e47024c9] > However, the Spec still defines it as: > [https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/context/externalcontextwrapper#getInitParameterMap()] > Note the Map vs Map<String,String> > > 2) Renderer.getConvertedValue was updated here: > [https://github.com/apache/myfaces/commit/895fc4ebed67cf9de121157c1a3563490d4ea9b0#diff-1cf56a9a7964d94b000a763f671c45892ca58f114e93b891fce8fc8211de6e5b] > However, the Spec still defines it as: > [https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/render/renderer#getConvertedValue(jakarta.faces.context.FacesContext,jakarta.faces.component.UIComponent,java.lang.Object)] > Note the UIComponent vs T > This was work originally done for the following Spec issue: > [https://github.com/jakartaee/faces/issues/1497] > For now we're stuck and need to match the published API, maybe these can get > cleaned up for the next Faces release! > > {code:java} > Added Methods > [javatest.batch] jakarta.faces.context.ExternalContextWrapper: method public > java.util.Map<java.lang.String,java.lang.String> > jakarta.faces.context.ExternalContextWrapper.getInitParameterMap() > [javatest.batch] jakarta.faces.render.Renderer: method public > java.lang.Object > jakarta.faces.render.Renderer.getConvertedValue(jakarta.faces.context.FacesContext,{jakarta.faces.render.Renderer%0},java.lang.Object){code} > {code:java} > Missing Methods > [javatest.batch] jakarta.faces.context.ExternalContextWrapper: method public > java.util.Map > jakarta.faces.context.ExternalContextWrapper.getInitParameterMap() > [javatest.batch] jakarta.faces.render.Renderer: method public > java.lang.Object > jakarta.faces.render.Renderer.getConvertedValue(jakarta.faces.context.FacesContext,jakarta.faces.component.UIComponent,java.lang.Object) > [javatest.batch] > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)