Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-27 Thread Volodymyr Siedlecki
Hey Werner, All the tests (with your changes) looked good except for one. The problem looks to be a bug, so I created this JIRA: https://issues.apache.org/jira/browse/MYFACES-4575 I'm not sure the best way to fix it, so I assigned it to you, if you could take a look. Thanks, Volodymyr On

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-27 Thread Volodymyr Siedlecki
Thank you for getting these tests ported! We'll test out the PR and hope to have it merged soon :) On 2023/02/27 14:42:13 Werner Punz wrote: > I just have issued the pull request, and sorry, that I could not wrap > everything up on Friday. > > However I noticed that 3 TCK tests in the 2.3

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-27 Thread Werner Punz
I just have issued the pull request, and sorry, that I could not wrap everything up on Friday. However I noticed that 3 TCK tests in the 2.3 area fail commandScript tests fail.. also on the old codebase so not ajax related! The exactMapping test fails, because myfaces delivers a slightly

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-26 Thread Werner Punz
Hi sorry, did not make it... I will target today. Werner Am Do., 23. Feb. 2023 um 21:15 Uhr schrieb Paul Nicolucci < pnicolu...@gmail.com>: > Hi Werner, > > I just wanted to check in and see if you were still on target for the end > of the week for the changes you're working on. > > Vlad will

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-23 Thread Paul Nicolucci
Hi Werner, I just wanted to check in and see if you were still on target for the end of the week for the changes you're working on. Vlad will have a PR up for the tests that were failing in the old tck tomorrow sometime which will include selenium updates for: 1) jsf/spec/view/protectedview

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Volodymyr Siedlecki
Thank you as always. Let me know if I can help port over any tests, so we can split the work. Volodymyr On 2023/02/21 15:31:30 Werner Punz wrote: > Yes... I will work on them, I just converted the first one. > This is indeed the usual Rhino Problem. > I tackled for the Ajax parts of the TCK! >

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Werner Punz
Yes... I will work on them, I just converted the first one. This is indeed the usual Rhino Problem. I tackled for the Ajax parts of the TCK! Expect the fixed scripts to hit the TCK this week, I will simply will fix it in the evening. Vacation or not! Werner Am Di., 21. Feb. 2023 um 16:25 Uhr

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Thomas Andraschko
it would be really great if we just fix the new failing tests, this are only ~10 test classes. the new scripts are really a great benefit for the future Am Di., 21. Feb. 2023 um 16:10 Uhr schrieb Werner Punz < werner.p...@gmail.com>: > Sorry I missed this thread. > I will work on the list.

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Werner Punz
Sorry I missed this thread. I will work on the list. Problem is I am not working until next monday. But I will see what I can do in my sparetime. Thing is, this entire Rhino situation makes me somewhat uneasy if there is a huge time pressure. We probably should postpone the big switch to a 4.1

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-20 Thread Volodymyr Siedlecki
Hello, The old-tck completed, and the results are better than expected. The only failures were found here: jsf/spec/ajax - 5 / 5 Fail (1 is excluded entirely) jsf/spec/render/commandlink - 3 /3 Fail jsf/spec/resource/packaging/classpath - 4 / 8 Fail jsf/spec/view/protectedview - 1 / 2

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-20 Thread Paul Nicolucci
I did send a quick update to the Faces community: https://www.eclipse.org/lists/faces-dev/msg00272.html Regards, Paul Nicolucci On Mon, Feb 20, 2023 at 11:50 AM Paul Nicolucci wrote: > Hi, > > If we're not reverting this, then @Werner can you let the Faces community > know that you have more

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-20 Thread Paul Nicolucci
Hi, If we're not reverting this, then @Werner can you let the Faces community know that you have more changes coming in? I sent a message hoping we could get a new TCK out: https://www.eclipse.org/lists/faces-dev/msg00264.html last week. I hate holding up a MyFaces 4.0.0 release when we were

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-20 Thread Thomas Andraschko
IMO the goal should be to NOT revert this changes @Werner Could you fix/refactor the tests maybe? I really dont like to revert because TCK uses a technology which doesnt support long time existing JS/HTML features Am Mo., 20. Feb. 2023 um 17:16 Uhr schrieb Volodymyr Siedlecki <

Requesting Revert of MYFACES-4466 (PR #514)

2023-02-20 Thread Volodymyr Siedlecki
Hello, I regret bringing this topic up, but the new JavaScript code in RC5 is encountering more HTMLUnit trouble. I've pulled the RC5 jars into our application server and run our test suite against it, and we saw about 5-10% of tests fail. We have yet to run against the full TCK, but initial