+1 on using sysinit

> On Mar 1, 2018, at 6:18 PM, Jacob Rosenthal <jakerosent...@gmail.com> wrote:
> 
> shell_init in the app feels odd.
> https://github.com/apache/mynewt-core/blob/master/apps/sensors_test/src/main.c#L411
> 
> It feels like they should be down in the drivers pkg.init, especially
> theyre defined down in the driver's syscfg
> https://github.com/apache/mynewt-core/blob/master/hw/drivers/drv2605/syscfg.yml#L21
> 
> My ideal world would probably be something conditional like
> pkg.init.DRV2605_CLI:
>   drv2605_shell_init 501
> 
> but that would need newt tool changes I presume.
> 
> Uglier, but we could make some new second init function which does #ifdef
> and calls drv2605_shell_init
> 
> pkg.init:
> drv2605_init_thesecond
> 
> Thoughts (especially from vipul)

Reply via email to