[ 
https://issues.apache.org/jira/browse/MYRIAD-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970520#comment-14970520
 ] 

Yuliya Feldman commented on MYRIAD-148:
---------------------------------------

Submitted PR: https://github.com/apache/incubator-myriad/pull/19

Problem is that Optional<T> does not serialize correctly <T>. It shows state 
"present" instead of value.
Created custom serializers to produce value if present and string "value is 
absent" when value is absent.

> /api/config missing myriadExecutorConfiguration & nodeManagerConfiguration's 
> param key value.
> ---------------------------------------------------------------------------------------------
>
>                 Key: MYRIAD-148
>                 URL: https://issues.apache.org/jira/browse/MYRIAD-148
>             Project: Myriad
>          Issue Type: Bug
>            Reporter: Sarjeet Singh
>            Assignee: Yuliya Feldman
>
> When executed the /api/config to get myriad configs, the api output doesn't 
> have values for nodeManagerConfiguration & myriadExecutorConfiguration's 
> parameter keys.
> e.g. /api/config json (snippet) output:
>     "myriadExecutorConfiguration": {
>         "jvmMaxMemoryMB": {
>             "present": true        <----------
>         }, 
>         "nodeManagerUri": {
>             "present": false       <----------
>         }, 
>         "path": 
> "file:///opt/mapr/myriad/myriad-0.1/lib/myriad-executor-runnable-0.0.1.jar"
>     }, 
>     "nativeLibrary": "/usr/local/lib/libmesos.so", 
>     "nmInstances": {
>         "medium": 1
>     }, 
>     "nodeManagerConfiguration": {
>         "cgroups": {
>             "present": true        <----------
>         }, 
>         "cpus": {
>             "present": true          <----------
>         }, 
>         "jvmMaxMemoryMB": {
>             "present": true         <----------
>         }, 
>         "jvmOpts": {
>             "present": false        <----------
>         }
>     }, 
> From myriad-config-default.yml:
> nodemanager:
>   jvmMaxMemoryMB: 1024
>   cpus: 0.2
>   cgroups: false
> executor:
>   jvmMaxMemoryMB: 256
>   path: 
> file:///opt/mapr/myriad/myriad-0.1/lib/myriad-executor-runnable-0.0.1.jar
>   #The following should be used for a remotely distributed URI, hdfs assumed 
> but other URI types valid.
>   #nodeManagerUri: hdfs://namenode:port/dist/hadoop-2.5.0.tar.gz
>   #path: 
> file:///opt/mapr/myriad/myriad-0.1/lib/myriad-executor-runnable-0.0.1.jar
> As the parameter values are specified in *.yml, /api/config json output 
> should contain the values for the param keys.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to