[GitHub] jeongyooneo commented on issue #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on issue #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#issuecomment-390543343 @johnyangk Of course! This is an automated message from the Apache Git Service

[GitHub] sanha closed pull request #19: [NEMO-47] Use primitive types for AlternatingLeastSquare

2018-05-20 Thread GitBox
sanha closed pull request #19: [NEMO-47] Use primitive types for AlternatingLeastSquare URL: https://github.com/apache/incubator-nemo/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] johnyangk commented on issue #19: [NEMO-47] Use primitive types for AlternatingLeastSquare

2018-05-20 Thread GitBox
johnyangk commented on issue #19: [NEMO-47] Use primitive types for AlternatingLeastSquare URL: https://github.com/apache/incubator-nemo/pull/19#issuecomment-390532737 @jeongyooneo @wonook @seojangho @sanha Ping. 😄 This is a

[GitHub] johnyangk commented on issue #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
johnyangk commented on issue #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#issuecomment-390528099 @jeongyooneo I've addressed your comments except the ones for TaskDataHandler and 'pipelined' tasks, which I'd like to address while working on

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456590 ## File path: runtime/master/src/test/java/edu.snu.nemo.runtime.master/scheduler/SourceLocationAwareSchedulingPolicy

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189453902 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/metric/MetricData.java ## @@ -25,7

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455467 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -374,12

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455257 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -32,48 +

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455496 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -565,8

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455394 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/Executor.java ## @@ -87,36 +87,

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456068 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java ## @@ -131,36

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455518 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -565,8

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456665 ## File path: runtime/master/src/test/java/edu.snu.nemo.runtime.master/scheduler/SourceLocationAwareSchedulingPolicy

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455614 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java ##

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455429 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -76,24

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455580 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java ##

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189454073 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/physical/PhysicalPlanGenerator.java ###

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455003 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -32,48 +

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456732 ## File path: tests/src/test/java/edu/snu/nemo/tests/runtime/executor/TaskExecutorTest.java ## @@ -145,7 +

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456580 ## File path: runtime/master/src/test/java/edu.snu.nemo.runtime.master/scheduler/SourceLocationAwareSchedulingPolicy

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456596 ## File path: runtime/master/src/test/java/edu.snu.nemo.runtime.master/scheduler/SourceLocationAwareSchedulingPolicy

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456113 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java ## @@ -260,39

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456094 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java ## @@ -260,39

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455609 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java ##

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455592 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/TaskDataHandler.java ##

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189454865 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -32,48 +

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455280 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java ## @@ -89,15 +

[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

2018-05-20 Thread GitBox
jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456710 ## File path: tests/src/test/java/edu/snu/nemo/tests/runtime/executor/TaskExecutorTest.java ## @@ -88,11 +