Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Josh Juneau
+1, that is a great idea to have Travis fail sooner. On Fri, Jul 12, 2019 at 12:15 PM Neil C Smith wrote: > On Fri, 12 Jul 2019 at 18:05, Neil C Smith wrote: > > One thing from this that might be good to look at in future is having > > our Travis tests fail fast. > > Maybe a "|| travis_terminat

Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Neil C Smith
On Fri, 12 Jul 2019 at 18:05, Neil C Smith wrote: > One thing from this that might be good to look at in future is having > our Travis tests fail fast. Maybe a "|| travis_terminate 1" on a few things like rat? https://medium.com/@manjula.cse/how-to-stop-the-execution-of-travis-pipeline-if-script

Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Neil C Smith
On Fri, 12 Jul 2019 at 17:50, Josh Juneau wrote: > > Thanks Neil for your patience with the PR. Took a few tries and lots of > time...I appreciate it. No problem! One thing from this that might be good to look at in future is having our Travis tests fail fast. Took a while for me to realise th

Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Josh Juneau
Thanks Neil for your patience with the PR. Took a few tries and lots of time...I appreciate it. Best wishes On Fri, Jul 12, 2019 at 11:43 AM Neil C Smith wrote: > On Fri, 12 Jul 2019 at 16:31, Geertjan Wielenga > wrote: > > > > Thanks for your resilience and calm control of everything. :-) >

Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Neil C Smith
On Fri, 12 Jul 2019 at 16:31, Geertjan Wielenga wrote: > > Thanks for your resilience and calm control of everything. :-) There is a famous phrase about a swan! ;-) After a couple more failed attempts, we got all green lights, and it's merged to master. Assuming the PR to release branch also go

Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Geertjan Wielenga
Thanks for your resilience and calm control of everything. :-) Gj On Fri, 12 Jul 2019 at 17:12, Neil C Smith wrote: > On Fri, 12 Jul 2019 at 16:05, Alessandro wrote: > > > > Hi Neil, > > could the reason be this instead: > > > > BUILD FAILED > > /home/travis/build/apache/netbeans/scratch/nbb

Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Neil C Smith
On Fri, 12 Jul 2019 at 16:05, Alessandro wrote: > > Hi Neil, > could the reason be this instead: > > BUILD FAILED > /home/travis/build/apache/netbeans/scratch/nbbuild/build.xml:2167: > Failed Rat test(s): > Unapproved license in 1 file(s) > https://github.com/apache/netbeans/tree/master/enterpri

Re: [URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Alessandro
Hi Neil, could the reason be this instead: BUILD FAILED /home/travis/build/apache/netbeans/scratch/nbbuild/build.xml:2167: Failed Rat test(s): Unapproved license in 1 file(s) https://github.com/apache/netbeans/tree/master/enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/resources/web-app

[URGENT] Java EE 8 support fixes / beta4?

2019-07-12 Thread Neil C Smith
Hi, Josh and I could do with someone having a quick look at why the Travis test on https://github.com/apache/netbeans/pull/1375 is failing? It's been retriggered a couple of times so it's not a one-off glitch. It says it's failing on ant verify-libs-and-licenses. Neither of us can replicate tha