[GitHub] incubator-netbeans pull request #26: [NETBEANS-54] Module Review api.debugge...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/26 ---

[GitHub] incubator-netbeans pull request #27: [NETBEANS-54] Module Review api.xml.ui

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/27 ---

[GitHub] incubator-netbeans pull request #28: [NETBEANS-54] Module Review bugtracking

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/28 ---

[GitHub] incubator-netbeans pull request #39: [NETBEANS-54] Module Review bugzilla

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/39 ---

[GitHub] incubator-netbeans pull request #40: [NETBEANS-54] Module Review c.googlecod...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/40 ---

[GitHub] incubator-netbeans pull request #41: [NETBEANS-54] Module Review c.google.gu...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/41 ---

Podling Report Reminder - October 2017

Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 18 October 2017, 10:30 am PDT. The report for your podling will

[GitHub] incubator-netbeans pull request #48: [NETBEANS-54] Module Review c.jcraft.jz...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/48 ---

[GitHub] incubator-netbeans pull request #54: added initial .travis.yml

GitHub user krichter722 opened a pull request: https://github.com/apache/incubator-netbeans/pull/54 added initial .travis.yml A basic `.travis.yml` to test the build instructions specified in `README.md`. You can merge this pull request into a Git repository by running: $ git

Re: Editing permissions for making changes to the Wiki.

Done! And welcome! Gj On Tue, Oct 3, 2017 at 1:05 PM, Borxa Varela Bouzas wrote: > Hi, > > Would someone please add my confluence id " borxa " to the list of > people allowed to make changes to the list of modules to review at > [1]? > > Thanks, > Borxa > > [1]

[GitHub] incubator-netbeans pull request #53: [NETBEANS-54] Module Review editor.code...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/53 [NETBEANS-54] Module Review editor.codetemplates * No external libraries. * A nbproject/*sig that will be handled centrally. * Some text xml files wihout license header.

Editing permissions for making changes to the Wiki.

Hi, Would someone please add my confluence id " borxa " to the list of people allowed to make changes to the list of modules to review at [1]? Thanks, Borxa [1] https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review

[GitHub] incubator-netbeans pull request #52: First batch of xml modules for review

GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/52 First batch of xml modules for review Please see the individual commits for the details. The biggest changeset comes from xml.text, as there many unittest files

[GitHub] incubator-netbeans issue #49: [NETBEANS-54] Add license header to binaries-l...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/49 To me personally, looks OK. ---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 Thank you for it :) I'll push changes tomorrow. ---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 These look good to me. Before doing the final push you might do: ---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 @emilianbold Yes. Are the following steps OK if I push my changes myself? ``` $ cd incubator-netbeans $ git remote add upstream-apache

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 @junichi11 will you commit this yourself? ---

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/41 Feel free to commit. ---

[GitHub] incubator-netbeans pull request #44: Testcases related fixes

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/44#discussion_r142446465 --- Diff: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java --- @@ -50,7 +50,7 @@ protected

[GitHub] incubator-netbeans pull request #13: [NETBEANS-54] Module Review openide.mod...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/13 ---

[GitHub] incubator-netbeans pull request #32: [NETBEANS-54] Module Review server

Github user borxa closed the pull request at: https://github.com/apache/incubator-netbeans/pull/32 ---

Re: Grep CDDL (was Re: PR #46)

Aha! I now understand :-) I’ll doublecheck that the files excluded don’t have any original license headers. Thanks, Antonio > El 3 oct 2017, a las 15:36, Jan Lahoda escribió: > > Sorry, I probably should have been more precise. > > All I meant was a check that the files

[GitHub] incubator-netbeans pull request #51: [NETBEANS-54] Module review docker.edit...

GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/51 [NETBEANS-54] Module review docker.editor - no external library - checked Rat report; manually updated license header in Dockerfile - skimmed through the

[GitHub] incubator-netbeans pull request #10: [NETBEANS-54] Module Review openide.fil...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/10 ---

[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...

Github user lkishalmi closed the pull request at: https://github.com/apache/incubator-netbeans/pull/25 ---

[GitHub] incubator-netbeans pull request #50: [NETBEANS-54] Module review diff

GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/50 [NETBEANS-54] Module review diff - no external library - checked Rat report; ignored l10n.list (see central problems) and added ingore entries for rat report.

[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

Github user lkishalmi commented on the issue: https://github.com/apache/incubator-netbeans/pull/25 Thank you! ---

[GitHub] incubator-netbeans issue #14: [NETBEANS-54] Module Review o.n.swing.tabcontr...

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/14 Merged. ---

[GitHub] incubator-netbeans pull request #14: [NETBEANS-54] Module Review o.n.swing.t...

Github user emilianbold closed the pull request at: https://github.com/apache/incubator-netbeans/pull/14 ---

[GitHub] incubator-netbeans issue #17: [NETBEANS-54] Module Review openide.text

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/17 Committed. ---

Re: iCLA needed for Module Reviews?

Hi, Am Dienstag, den 03.10.2017, 16:47 +0200 schrieb Christian Lenz: > Because I asked for help in the slack chan to Review the modules, I > get a question: > > „is there any contribution agreement to sign?“ > > In General yes, but is this iCLA needed for module Review too? the work itself

AW: iCLA needed for Module Reviews?

Of Course it is always good, but if it is not needed for the module Review for the users to bring it on, it will be ok. Gesendet von Mail für Windows 10 Von: Emilian Bold Gesendet: Dienstag, 3. Oktober 2017 16:50 An: NetBeans Dev@ Betreff: Re: iCLA needed for Module Reviews? PS: Note how the

Re: iCLA needed for Module Reviews?

Hi, Am Dienstag, den 03.10.2017, 17:50 +0300 schrieb Emilian Bold: > PS: Note how the iCLA may be digitally signed with PGP. No need to > FAX > stuff. it does not even need to be signed by PGP. I printed the sheet, filled it, scanned it and emailed it to apache. Very painless! Greetings

Re: iCLA needed for Module Reviews?

PS: Note how the iCLA may be digitally signed with PGP. No need to FAX stuff. --emi On Tue, Oct 3, 2017 at 5:49 PM, Emilian Bold wrote: > I would say no. Any review will be double-checked by somebody else too and > committed by a committer. > > --emi > > On Tue, Oct 3,

Re: iCLA needed for Module Reviews?

I would say no. Any review will be double-checked by somebody else too and committed by a committer. --emi On Tue, Oct 3, 2017 at 5:47 PM, Christian Lenz wrote: > Because I asked for help in the slack chan to Review the modules, I get a > question: > > „is there any

Re: iCLA needed for Module Reviews?

I think it's always good to get your iCLA sorted out, it's not hard, regardless of whether you need it for this specific task. https://www.apache.org/licenses/icla.pdf Gj On Tue, Oct 3, 2017 at 7:47 AM, Christian Lenz wrote: > Because I asked for help in the slack chan

[GitHub] incubator-netbeans pull request #18: [NETBEANS-54] Module Review settings

Github user emilianbold closed the pull request at: https://github.com/apache/incubator-netbeans/pull/18 ---

[GitHub] incubator-netbeans issue #18: [NETBEANS-54] Module Review settings

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/18 Committed. ---

iCLA needed for Module Reviews?

Because I asked for help in the slack chan to Review the modules, I get a question: „is there any contribution agreement to sign?“ In General yes, but is this iCLA needed for module Review too? Regards Chris

[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/46 One additional thing I'd add is: - `*/nbproject/private/**` (the files are per user and should not be distributed) I would also not match with `**/nbproject` but

[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/25 Please close this PR. ---

[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/25 Committed: https://github.com/apache/incubator-netbeans/commit/ff5f3c4e175cf15c1b4b0caebfb5047be4196a44 ---

Re: Grep CDDL (was Re: PR #46)

Sorry, I probably should have been more precise. All I meant was a check that the files excluded from Rat don't have the original license header (as due to the excludes, Rat would no longer report them). I tried to check, and it seems that none of the excluded files has the headers, so this

Re: OK, so what did I mess up?

Yes, the repository is in a sane state. It's just those 3 duplicate commits that are annoying... Funny thing is this time I tried not to do a rebase but do a plain merge. I will stick to fast forward. --emi Pe 3 oct. 2017, la 16:10, Matthias Bläsing a scris: > Hi

[GitHub] incubator-netbeans issue #12: properties for by module report

Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 closing this PR. Do not want to add false positive to the rat report ---

Re: OK, so what did I mess up?

Hi Emilian, Am Dienstag, den 03.10.2017, 15:27 +0300 schrieb Emilian Bold: > I looked with > > > > > $ git diff --stat --cached apache/master > >  git/src/org/netbeans/modules/git/ui/repository/remote/RemoteReposi > > tory.java > > > 13 ++--- > > > >  1 file changed, 10 insertions(+),

[GitHub] incubator-netbeans issue #43: [NETBEANS-54] Module Review editor.bookmarks

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/43 Looks good. ---

[GitHub] incubator-netbeans issue #45: [NETBEANS-54] Module Review masterfs.ui

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/45 Looks good. ---

[GitHub] incubator-netbeans issue #48: [NETBEANS-54] Module Review c.jcraft.jzlib

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/48 Looks good. ---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 Looks good. ---

OK, so what did I mess up?

I looked with > > $ git diff --stat --cached apache/master > git/src/org/netbeans/modules/git/ui/repository/remote/RemoteRepository.java > | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) so I was only supposed to push one change. But $ git push apache master > Counting

[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/46 Looks good - the files that would match also look clean (either ALv2 or no license header): ``` matthias@athena:~/src/incubator-netbeans$ find . \( -name

[GitHub] incubator-netbeans issue #32: [NETBEANS-54] Module Review server

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/32 Thank you - I merged the changes into master with 2 positive reviews. I suggest, that you include the full name into the author field, user names look strange. The merge

Re: Grep CDDL (was Re: PR #46)

Hey, Am Dienstag, den 03.10.2017, 13:34 +0200 schrieb Antonio: > > On 03/10/17 12:59, Antonio wrote: > > > > I'll investigate the grep operation on CDDL and will post here with > > my  > > findings. > > > > It seems ant-rat is not able to do this. > > Anyway one can quickly find CDDL files

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 Oh - and no reason for apologies! The work is appreciated. ---

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 The problem is that you added the license headers, that conflicted with the central change the @jlahoda kindly did (fixing a great many files). Now your changeset removes these

Grep CDDL (was Re: PR #46)

On 03/10/17 12:59, Antonio wrote: I'll investigate the grep operation on CDDL and will post here with my findings. It seems ant-rat is not able to do this. Anyway one can quickly find CDDL files with grep -R CDDL --exclude-dir build Or adding

[GitHub] incubator-netbeans pull request #49: [NETBEANS-54] Add license header to bin...

GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/49 [NETBEANS-54] Add license header to binaries-list Add Apache License header to binaries-list. Excluded from this commit are: - db.sql.visualeditor -

[GitHub] incubator-netbeans pull request #47: [NETBEANS-54] Module Review c.jcraft.js...

GitHub user junichi11 opened a pull request: https://github.com/apache/incubator-netbeans/pull/47 [NETBEANS-54] Module Review c.jcraft.jsch - external library jsch-0.1.54.jar: BSD-jsch-variant. Maven coordinates added. - checked Rat report: everything has been relicensed to

[GitHub] incubator-netbeans pull request #48: [NETBEANS-54] Module Review c.jcraft.jz...

GitHub user junichi11 opened a pull request: https://github.com/apache/incubator-netbeans/pull/48 [NETBEANS-54] Module Review c.jcraft.jzlib - external library jzlib-1.0.7.jar: BSD-jzlib-variant. Maven coordinates added. - checked Rat report: everything has been relicensed to

PR #46 (was Re: Want a PR? (was Re: nbproject/*-impl.xml and genfiles.properties))

On 03/10/17 12:18, Jan Lahoda wrote: On Tue, Oct 3, 2017 at 11:51 AM, Antonio wrote: I've added '**/nbproject/*-impl.xml' and '**/nbproject/genfiles.properties' to the rat exclusion list. (Note: **/nbproject/, so that affects qa-test projects as well, and not */nbproject

[GitHub] incubator-netbeans pull request #46: Updating the rat exclusion list

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/46 Updating the rat exclusion list Now excluding the following automatically generated files from the rat report: - **/nbproject/build-impl.xml - **/nbproject/jfx-impl.xml

[GitHub] incubator-netbeans pull request #45: [NETBEANS-54] Module Review masterfs.ui

GitHub user rtaneja1 opened a pull request: https://github.com/apache/incubator-netbeans/pull/45 [NETBEANS-54] Module Review masterfs.ui Added Apache license header in bundle.properties You can merge this pull request into a Git repository by running: $ git pull

Re: Want a PR? (was Re: nbproject/*-impl.xml and genfiles.properties)

On Tue, Oct 3, 2017 at 11:51 AM, Antonio wrote: > On 03/10/17 11:09, Jaroslav Tulach wrote: > >> Hello Antonio, >> thanks for your help. >> > > My pleasure. > > I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and >>> nbproject/genfiles.properties. >>> >>> These

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/41 For me this looks good - thanks for taking care! ---

Re: nbproject/*-impl.xml and genfiles.properties

Problems to be solved centrally build.xml, build-impl.xml, project.properties, genfiles.properties, D'oh! Sorry On 03/10/17 08:57, Antonio wrote: Hi all, I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and nbproject/genfiles.properties. These are automatically generated in

[GitHub] incubator-netbeans pull request #42: [NETBEANS-54] Module Review editor

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/42 [NETBEANS-54] Module Review editor - No external libraries. - Checked Rat report: added license to project files. Did NOT add license to editor/demosrc/README nor to the rest of test

nbproject/*-impl.xml and genfiles.properties

Hi all, I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and nbproject/genfiles.properties. These are automatically generated in the IDE so, - I'm not adding license headers to these. - Should I remove them from git? Thanks, Antonio