Re: Review of java.hints.declarative

2017-10-23 Thread Geertjan Wielenga
Done: https://github.com/apache/incubator-netbeans/pull/180 Gj On Sun, Oct 22, 2017 at 11:44 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Great, thanks, will implement these insights. > > Gj > > On Sun, Oct 22, 2017 at 11:12 PM, Jan Lahoda wrote: > >> Yes, I think Matthias

Re: Review of java.hints.declarative

2017-10-22 Thread Geertjan Wielenga
Great, thanks, will implement these insights. Gj On Sun, Oct 22, 2017 at 11:12 PM, Jan Lahoda wrote: > Yes, I think Matthias is right, anything before the first %%TestCase should > be ignored, so a license header there should be OK. (I guess it might make > sense to place the header inside a Ja

Re: Review of java.hints.declarative

2017-10-22 Thread Jan Lahoda
Yes, I think Matthias is right, anything before the first %%TestCase should be ignored, so a license header there should be OK. (I guess it might make sense to place the header inside a Java comment as for Java files, but shouldn't be necessary.) For the two empty files under resources (one .hintm

Re: Review of java.hints.declarative

2017-10-22 Thread Matthias Bläsing
Hi Geertjan, Am Sonntag, den 22.10.2017, 20:27 +0200 schrieb Geertjan Wielenga: > I'm looking at the Rat report for the java.hints.declarative module -- and > these are the ones identified as not having Apache licenses yet. > > In the below, there is one file with a ".hint" extension, which is em