Updater branding for release90

2018-06-26 Thread Sven Reimers
Hi all, I created a PR with the cherry-picked commit for release90 branch. https://github.com/apache/incubator-netbeans/pull/608 -Sven P.S. I think we need to work on the blue color etc. in the lower half of the updater as well... any ideas?

Re: Updater branding

2018-06-26 Thread Geertjan Wielenga
On Mon, Jun 25, 2018 at 9:54 PM, Lars Bruun-Hansen wrote: > > > I've been offline for some time so haven't been following your excellent > progress. > Thanks -- and welcome back! Gj > > -Lars > > > On Mon, Jun 25, 2018 at 5:08 PM, Geertjan Wielenga < >

Re: Updater branding

2018-06-26 Thread Geertjan Wielenga
I've done a separate pull request for the new splash images for the release90 branch, since I'm using the web interface for doing these changes and I don't see a way to do cherry picking there: https://github.com/apache/incubator-netbeans/pull/605 Gj On Tue, Jun 26, 2018 at 6:25 AM, Thilina

Re: Updater branding

2018-06-25 Thread Thilina Ranathunga
Hi, Take a look at this pull request - Update updater splash #604 https://github.com/apache/incubator-netbeans/pull/604 On Tue, Jun 26, 2018 at 1:25 AM Lars Bruun-Hansen wrote: > This is all documented in NETBEANS-146. It lists all the artwork, including > that for the Updater Splash. It also

Re: Updater branding

2018-06-25 Thread Lars Bruun-Hansen
This is all documented in NETBEANS-146. It lists all the artwork, including that for the Updater Splash. It also lists the locations for both Platform and IDE (just hover over the links). IDE overrides Platform. I wouldn't close NETBEANS-146 just yet, as long as not everything mentioned is

Re: Updater branding

2018-06-25 Thread Peter Steele
There is a nice little animated gif of stack overflow which shows you how to do this. https://stackoverflow.com/a/24159161/2999563 On Mon, 25 Jun 2018 17:27 Geertjan Wielenga, wrote: > https://github.com/apache/incubator-netbeans/pull/601 > > That's a PR for 'main'. How do I get it into

Re: Updater branding

2018-06-25 Thread Geertjan Wielenga
https://github.com/apache/incubator-netbeans/pull/601 That's a PR for 'main'. How do I get it into 'release90' branch? Gj On Mon, Jun 25, 2018 at 5:08 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Here they are: > > core.startup/src/org/netbeans/core/startup/splash.gif >

Re: Updater branding

2018-06-25 Thread Geertjan Wielenga
Here they are: core.startup/src/org/netbeans/core/startup/splash.gif core.startup/src/org/netbeans/core/startup/splash_dark.gif Thanks, Gj On Mon, Jun 25, 2018 at 5:04 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > > Here's the location of the updater image, I believe:

Re: Updater branding

2018-06-25 Thread Geertjan Wielenga
Here's the location of the updater image, I believe: ide.branding/autoupdate.services/libsrc/org/netbeans/updater/resources/updatersplash_nb.gif The other one I haven't found yet, i.e., the one for the NetBeans Platform application. Gj On Sun, Jun 24, 2018 at 11:36 PM, Laszlo Kishalmi

Re: Updater branding

2018-06-24 Thread Laszlo Kishalmi
And if we get a chance the branding when you create a new platform application project is still the old branding. (https://issues.apache.org/jira/browse/NETBEANS-990) I could not find the code responsible for that at the first scan. On 06/24/2018 12:16 PM, Geertjan Wielenga wrote: Yes.

Re: Updater branding

2018-06-24 Thread Geertjan Wielenga
Yes. Gj On Sun, Jun 24, 2018 at 8:56 PM, Sven Reimers wrote: > So we still need to update the updater as well for NetBeans 9.0 release? > > -Sven > > Geertjan Wielenga schrieb am > So., 24. Juni 2018, 19:25: > > > I don't believe the update dialog has been updated -- I only updated the > >

Re: Updater branding

2018-06-24 Thread Sven Reimers
So we still need to update the updater as well for NetBeans 9.0 release? -Sven Geertjan Wielenga schrieb am So., 24. Juni 2018, 19:25: > I don't believe the update dialog has been updated -- I only updated the > splash screen and the About box. > > Those new images are in 'ide.branding'. > >

Re: Updater branding

2018-06-24 Thread Geertjan Wielenga
I don't believe the update dialog has been updated -- I only updated the splash screen and the About box. Those new images are in 'ide.branding'. Gj On Sun, Jun 24, 2018 at 6:36 PM, Sven Reimers wrote: > Hi all, > > can anyone confirm that the branding of the update dialog has been updated? >

Updater branding

2018-06-24 Thread Sven Reimers
Hi all, can anyone confirm that the branding of the update dialog has been updated? I just tried with a local build of the latest 90release branch and saw the old blue updater splash (this is on mac os). Just trying to figure out if this is just me seeing this.. Thanks -Sven -- Sven Reimers