[GitHub] incubator-netbeans pull request #59: [NETBEANS-54] Module Review parsing.ind...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/59 ---

[GitHub] incubator-netbeans pull request #58: [NETBEANS-54] Module Review parsing.nb

Github user emilianbold closed the pull request at: https://github.com/apache/incubator-netbeans/pull/58 ---

[GitHub] incubator-netbeans pull request #60: [NETBEANS-54] Module Review spellchecke...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/60 ---

[GitHub] incubator-netbeans issue #34: -external library jna-4.2.2.jar: dual-licensed...

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/34 @jlahoda Should we remove the OSR field in other -license.txt files? ---

[GitHub] incubator-netbeans pull request #57: [NETBEANS-54] Module Review parsing.api

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/57 ---

[GitHub] incubator-netbeans issue #64: [NETBEANS-54] Module Review j2ee.core.utilitie...

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/64 Perfect! ---

Re: TomEE Support in NetBeans

Sure this is a no brainer... Already created a repo at github (still empty) to build the plugin under ASL license and integrate once the donation is complete.. Ok? Or should we create a repo for incubating plugins at apache? Sven Am 05.10.2017 14:49 schrieb "Zoran Sevarac"

Re: hi all & request for confluence rights

Really awesome -- and done! Gj On Thu, Oct 5, 2017 at 3:44 AM, Daniel Platz wrote: > Hi all, > My name is Daniel (username 38leinad) and i am a long-time Netbeans user > and now the move to apache seems to be the perfect time to get involved and > give back. > I would

hi all & request for confluence rights

Hi all, My name is Daniel (username 38leinad) and i am a long-time Netbeans user and now the move to apache seems to be the perfect time to get involved and give back. I would like to pick up some modules for reaview here: 

[GitHub] incubator-netbeans pull request #64: [NETBEANS-54] Module Review j2ee.core.u...

GitHub user juneau001 opened a pull request: https://github.com/apache/incubator-netbeans/pull/64 [NETBEANS-54] Module Review j2ee.core.utilities - no external libraries - checked Rat report, added license header to project.xml, other headers looked ok. Ignored problems to be

[GitHub] incubator-netbeans issue #34: -external library jna-4.2.2.jar: dual-licensed...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/34 Regarding the OSR field - that does not have any significance at this point, as far as I can tell. So can be removed. But we can do a batch update at some point and remove them all.

[GitHub] incubator-netbeans pull request #35: -external library Apache felix. Changed...

Github user jlahoda closed the pull request at: https://github.com/apache/incubator-netbeans/pull/35 ---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 Merged this pull request: https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=commit;h=0aa49fe575905f3c3eddd47c6b95194d40115174 ---

[GitHub] incubator-netbeans issue #35: -external library Apache felix. Changed coordi...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/35 Merged this pull request: https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=commit;h=3814587fcc8ae6712840b2d6c78126cb02b641e7 ---

[GitHub] incubator-netbeans pull request #33: -external library jna-platform-4.2.2.ja...

Github user jlahoda closed the pull request at: https://github.com/apache/incubator-netbeans/pull/33 ---

Re: TomEE Support in NetBeans

Hello Sven. Merging git repos (including history) is easier than splitting them (commit ids are kept). I think a separate git repo for an incubating^2 plugin is good idea. -jt Dne 6. 10. 2017 0:11 Sven Reimers napsal(a): > > Sure this is a no brainer... > > Already

[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/46 Merged - thank you. ---

[GitHub] incubator-netbeans pull request #46: Updating the rat exclusion list

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/46 ---

[GitHub] incubator-netbeans pull request #62: [NETBEANS-54] Module Review hibernate

Github user ikysil commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/62#discussion_r143025054 --- Diff: hibernate/src/org/netbeans/modules/hibernate/resources/HibernateRevengTemplate.xml --- @@ -1,2 +1,24 @@ + --- End diff --

[GitHub] incubator-netbeans pull request #62: [NETBEANS-54] Module Review hibernate

Github user matthiasblaesing commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/62#discussion_r143012148 --- Diff: hibernate/src/org/netbeans/modules/hibernate/resources/HibernateRevengTemplate.xml --- @@ -1,2 +1,24 @@ + --- End

[GitHub] incubator-netbeans pull request #34: -external library jna-4.2.2.jar: dual-l...

Github user jlahoda closed the pull request at: https://github.com/apache/incubator-netbeans/pull/34 ---

[GitHub] incubator-netbeans pull request #65: Added Apache License

GitHub user subhash-koganti opened a pull request: https://github.com/apache/incubator-netbeans/pull/65 Added Apache License - no external libraries - checked Rat report and found 11 XML files that don't have any license info defined on them. Added the license text on to them .

[GitHub] incubator-netbeans issue #34: -external library jna-4.2.2.jar: dual-licensed...

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/34 Thank you for your answer. I see. I'll leave it as it is. ---

Re: Using #Hacktoberfest for the modules review

I'd say few people have idea of what "module review" is. Also on github the search: "label:hacktoberfest state:open type:issue netbeans" brings up only 3 irrelevant issues. - Dmitry On Thu, Oct 5, 2017 at 2:19 PM, Emilian Bold wrote: > Hello, > > I'm trying to use

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

Github user juneau001 commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 Hi @matthiasblaesing is the code looking okay now? I've done what was mentioned. That is, I rebased changes on to master, reverted my changes to form files and genfiles.properties.

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058527 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml --- @@ -7,9 +28,9 @@

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058623 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml --- @@ -35,20 +56,20 @@ -For list

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058793 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/nbproject/project.xml --- @@ -1,4 +1,24 @@

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058704 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/nbproject/build-impl.xml --- @@ -1,5 +1,25 @@

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058683 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml --- @@ -60,10 +81,10 @@ -Notice

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058334 --- Diff: j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ParametersPanel.form --- @@ -1,26 +1,5 @@

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058744 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/nbproject/project.properties --- @@ -1,3 +1,20 @@ +# Licensed to the Apache Software

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058582 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml --- @@ -35,20 +56,20 @@ -For list

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058559 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml --- @@ -35,20 +56,20 @@ -For list

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058376 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml --- @@ -1,4 +1,25 @@

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058725 --- Diff: j2ee.core.utilities/test/unit/data/JavaApp/nbproject/build-impl.xml --- @@ -21,9 +41,9 @@ is divided into following sections:

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058252 --- Diff: j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form --- @@ -1,26 +1,5 @@

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user juneau001 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143059352 --- Diff: j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form --- @@ -1,26 +1,5 @@

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user juneau001 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143060074 --- Diff: j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form --- @@ -1,26 +1,5 @@

Using #Hacktoberfest for the modules review

Hello, I'm trying to use Twitter to attract contributors to NetBeans for our modules review as part of #Hacktoberfest (https://hacktoberfest.digitalocean.com/ ) (See, for example, https://twitter.com/emilianbold/status/916043049381195776 ) We still have about 400 modules to go from which 200 or

[GitHub] incubator-netbeans pull request #31: [NETBEANS-54] Module Review j2ee.core.u...

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/31#discussion_r143060563 --- Diff: j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form --- @@ -1,26 +1,5 @@

TomEE Support in NetBeans

Hi, I've talked to David Blevins from TomiTribe about including TomEE support in NetBeans and they would be pretty happy to see that. That would not be complicated since we already have Tomcat included, and its on the line of adding support to apache related projects to netbeans. I think it would