Re: README & commit workflow was: Git "temp" repository requested

2016-10-22 Thread Emilian Bold
You don't need to be a committer to do a PR. Development will come to a standstill if all the main committers would have to go through this. Seems to me that if you trust somebody to vote her to be a committer you trust her to actually commit code without being vetted by someone else. I know

Re: README & commit workflow was: Git "temp" repository requested

2016-10-22 Thread Wade Chandler
> On Oct 22, 2016, at 12:31, Wade Chandler wrote: > > I’m not even sure if that is possible with GH (GitHub). > > I mention this because even if we have infrastructure within ASF, aren’t GH mirrors 2 way streets where things can be merged to a master branch on

Re: README & commit workflow was: Git "temp" repository requested

2016-10-22 Thread Wade Chandler
> > On Oct 22, 2016, at 12:21, Emilian Bold wrote: > > I also wouldn't mind if we use code reviews. > > But code reviews don't make sense for every NetBeans commit. > > By definition a committer will not need approval to commit code. To me this is more of a community

Re: README & commit workflow was: Git "temp" repository requested

2016-10-22 Thread Wade Chandler
Generally in full on open processes it isn't exactly "locked down", but instead there is a methodology followed by all to commit to some personal branch, then use PRs to get to some develop/development branch, where automation takes over, and then merge to master in some way. Things can go

Re: README & commit workflow was: Git "temp" repository requested

2016-10-22 Thread Emilian Bold
So the master branch is the new main-golden? I agree that we should have some automatically managed branches where only a bot/Jenkins task pushes after the tests have passed, etc. I also wouldn't mind if we use code reviews. But code reviews don't make sense for every NetBeans commit. By

README & commit workflow was: Git "temp" repository requested

2016-10-22 Thread Jaroslav Tulach
Hi, I also made my first commit and described the setup steps in README: https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans-temp.git;a=commitdiff;h=9fbda90b2430a3a7cedbe7f855eb4cb9398e4513 However I don't think this is the workflow we want to use. Nobody should have write access to the

Re: Jenkins & Git @apache

2016-10-22 Thread Jaroslav Tulach
> As others already explained we must only import stuff > to ASF repos which already got granted and are properly ALv2 licensed I see. I try to play with the temp repo then. -jt