[GitHub] lbruun opened a new pull request #310: Javadoc build changes

2017-12-01 Thread GitBox
lbruun opened a new pull request #310: Javadoc build changes URL: https://github.com/apache/incubator-netbeans/pull/310 Two minor changes to Javadoc build. Not worthy of a JIRA issue, I thought. ### Change Javadoc copyright notice from Oracle to ASF The copyright notice at

[GitHub] matthiasblaesing opened a new pull request #311: [NETBEANS-54] Various module reviews

2017-12-01 Thread GitBox
matthiasblaesing opened a new pull request #311: [NETBEANS-54] Various module reviews URL: https://github.com/apache/incubator-netbeans/pull/311 - Removed unused files without license headers - Added various headers - Added various exclusions With this we are down to only one

[GitHub] geertjanw closed pull request #316: Attempting to clear more verify-libs-and-licenses reports.

2017-12-03 Thread GitBox
geertjanw closed pull request #316: Attempting to clear more verify-libs-and-licenses reports. URL: https://github.com/apache/incubator-netbeans/pull/316 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw closed pull request #306: Some more updates to fix issues reported by verify-libs-and-licenses.

2017-12-01 Thread GitBox
geertjanw closed pull request #306: Some more updates to fix issues reported by verify-libs-and-licenses. URL: https://github.com/apache/incubator-netbeans/pull/306 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] geertjanw closed pull request #307: added test data of autoupdate.services to rat exclude list

2017-12-01 Thread GitBox
geertjanw closed pull request #307: added test data of autoupdate.services to rat exclude list URL: https://github.com/apache/incubator-netbeans/pull/307 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw closed pull request #311: [NETBEANS-54] Various module reviews

2017-12-01 Thread GitBox
geertjanw closed pull request #311: [NETBEANS-54] Various module reviews URL: https://github.com/apache/incubator-netbeans/pull/311 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw commented on issue #311: [NETBEANS-54] Various module reviews

2017-12-01 Thread GitBox
geertjanw commented on issue #311: [NETBEANS-54] Various module reviews URL: https://github.com/apache/incubator-netbeans/pull/311#issuecomment-348637305 Awesome, merging. This is an automated message from the Apache Git

[GitHub] ebarboni closed pull request #252: NETBEANS-134 wip attempt to get ignore from .gitgnore

2017-12-03 Thread GitBox
ebarboni closed pull request #252: NETBEANS-134 wip attempt to get ignore from .gitgnore URL: https://github.com/apache/incubator-netbeans/pull/252 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] geertjanw commented on issue #316: Attempting to clear more verify-libs-and-licenses reports.

2017-12-03 Thread GitBox
geertjanw commented on issue #316: Attempting to clear more verify-libs-and-licenses reports. URL: https://github.com/apache/incubator-netbeans/pull/316#issuecomment-348761109 Great, merging. This is an automated message

[GitHub] geertjanw closed pull request #317: Excluding svnkit

2017-12-03 Thread GitBox
geertjanw closed pull request #317: Excluding svnkit URL: https://github.com/apache/incubator-netbeans/pull/317 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] geertjanw closed pull request #321: Trying to resolve some more verify-libs-and-licenses warnings.

2017-12-08 Thread GitBox
geertjanw closed pull request #321: Trying to resolve some more verify-libs-and-licenses warnings. URL: https://github.com/apache/incubator-netbeans/pull/321 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw commented on issue #321: Trying to resolve some more verify-libs-and-licenses warnings.

2017-12-08 Thread GitBox
geertjanw commented on issue #321: Trying to resolve some more verify-libs-and-licenses warnings. URL: https://github.com/apache/incubator-netbeans/pull/321#issuecomment-350384633 Excellent. This is an automated message

[GitHub] junichi11 opened a new pull request #201: Remove an unused line

2017-10-28 Thread GitBox
junichi11 opened a new pull request #201: Remove an unused line URL: https://github.com/apache/incubator-netbeans/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] vieiro commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries.

2017-10-29 Thread GitBox
vieiro commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries. URL: https://github.com/apache/incubator-netbeans/pull/152#issuecomment-340240222 I think we should normalize to either upper or lower case. Maven currently returns all lowercase, as far as I

[GitHub] junichi11 opened a new pull request #203: [NETBEANS-54] Module Review root files

2017-10-29 Thread GitBox
junichi11 opened a new pull request #203: [NETBEANS-54] Module Review root files URL: https://github.com/apache/incubator-netbeans/pull/203 - Add the license header to README.md and .travis.yml We can add the license header to these. Or should we add these to rat exclusions?

[GitHub] junichi11 commented on issue #71: Cleanup NetBeans license header for module updatecenters #203

2017-10-28 Thread GitBox
junichi11 commented on issue #71: Cleanup NetBeans license header for module updatecenters #203 URL: https://github.com/apache/incubator-netbeans/pull/71#issuecomment-340231356 @mihaivpopescu Are you still interested in this? I'm going to close this issue tomorrow. Then I'll fix it.

[GitHub] ebarboni opened a new pull request #205: NETBEANS-109 fix server generation

2017-10-30 Thread GitBox
ebarboni opened a new pull request #205: NETBEANS-109 fix server generation URL: https://github.com/apache/incubator-netbeans/pull/205 add test fix related javadoc This is an automated message from the Apache Git Service.

[GitHub] junichi11 opened a new pull request #206: [NETBEANS-54] Module Review updatecenters

2017-10-30 Thread GitBox
junichi11 opened a new pull request #206: [NETBEANS-54] Module Review updatecenters URL: https://github.com/apache/incubator-netbeans/pull/206 Update the license header in mf-layer.xml This is an automated message from the

[GitHub] junichi11 opened a new pull request #207: [NETBEANS-54] Module Review o.n.upgrader

2017-10-30 Thread GitBox
junichi11 opened a new pull request #207: [NETBEANS-54] Module Review o.n.upgrader URL: https://github.com/apache/incubator-netbeans/pull/207 Add the license header to systemoptionsimport. This file is used in `o.n.upgrader/src/org/netbeans/upgrade/systemoptions/Importer.java` (see

[GitHub] junichi11 closed pull request #71: Cleanup NetBeans license header for module updatecenters #203

2017-10-30 Thread GitBox
junichi11 closed pull request #71: Cleanup NetBeans license header for module updatecenters #203 URL: https://github.com/apache/incubator-netbeans/pull/71 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw closed pull request #203: [NETBEANS-54] Module Review root files

2017-10-30 Thread GitBox
geertjanw closed pull request #203: [NETBEANS-54] Module Review root files URL: https://github.com/apache/incubator-netbeans/pull/203 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw commented on issue #203: [NETBEANS-54] Module Review root files

2017-10-30 Thread GitBox
geertjanw commented on issue #203: [NETBEANS-54] Module Review root files URL: https://github.com/apache/incubator-netbeans/pull/203#issuecomment-340482645 No, this is perfect, thanks. Merging. This is an automated message

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-25 Thread GitBox
rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-339492014 I didn't realise I could resolve conflicts from GitHub. I've done that now, but that's made a mess after the alphabetisation.

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-25 Thread GitBox
rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-339497203 OK, all sorted, but I haven't squashed the merge masters. I'm not that familiar with git/squashing - is it safe to squash the

[GitHub] geertjanw commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
geertjanw commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339298136 I think we need to investigate whether this is the right approach here.

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339297996 I have modified the license headers for those xsd files that were contained within the archive ZIP file. Please let me know

[GitHub] junichi11 closed pull request #174: Add a license header template for new files of NetBeans modules

2017-10-25 Thread GitBox
junichi11 closed pull request #174: Add a license header template for new files of NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/174 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
geertjanw commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339298472 Well, potentially it's OK. Let's wait and investigate. This

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339298284 OK, I need to revert that...sorry. I read on my phone and thought you wanted me to relicense. Give me a moment to revert.

[GitHub] junichi11 commented on issue #174: Add a license header template for new files of NetBeans modules

2017-10-25 Thread GitBox
junichi11 commented on issue #174: Add a license header template for new files of NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/174#issuecomment-339311746 Merged. I've excluded license-*.txt from rat because they are user visible templates.

[GitHub] matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339295122 Please be careful. The contents of the ZIP dies not belong to the netbeans cidebase. In the ZIP XSDs are contained,

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339299401 I've got both versions available in my local repository...if I need to relicense then let me know and I can do it. Sorry

[GitHub] junichi11 opened a new pull request #194: [NETBEANS-54] Module Review java.platform.ui

2017-10-26 Thread GitBox
junichi11 opened a new pull request #194: [NETBEANS-54] Module Review java.platform.ui URL: https://github.com/apache/incubator-netbeans/pull/194 Exclude javaplatform.xml from rat. This is an automated message from the

[GitHub] matthiasblaesing opened a new pull request #193: Add java based patch task to build environment

2017-10-25 Thread GitBox
matthiasblaesing opened a new pull request #193: Add java based patch task to build environment URL: https://github.com/apache/incubator-netbeans/pull/193 Some packages need to be able to apply diff patches while building and the ant patch task expects a native patch binary to be

[GitHub] matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339460139 Ok - this still looks a bit chaotic: - please squash the commits together into one - this gives a better overview

[GitHub] bolsover commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-24 Thread GitBox
bolsover commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-339001084 I'll quite happily do some testing... Where do I get the 'patch' utility?

[GitHub] matthiasblaesing commented on issue #169: [NETBEANS-54] Module Review o.apache.commons.httpclient

2017-10-24 Thread GitBox
matthiasblaesing commented on issue #169: [NETBEANS-54] Module Review o.apache.commons.httpclient URL: https://github.com/apache/incubator-netbeans/pull/169#issuecomment-339061437 I pushed the commit to master. This PR is still a bit strange. For some reason you managed to push three

[GitHub] vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-24 Thread GitBox
vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-339065700 We'll either: 1- Add the complete source files to avoid patching (I'm worried about licensing issues here). 2-

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-24 Thread GitBox
juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339047664 Thanks @geertjanw we ran into an issue with this package due to a ZIP file containing additional files requiring license

[GitHub] geertjanw commented on issue #181: [NETBEANS-54] Module Review libs.osgi (followup)

2017-10-24 Thread GitBox
geertjanw commented on issue #181: [NETBEANS-54] Module Review libs.osgi (followup) URL: https://github.com/apache/incubator-netbeans/pull/181#issuecomment-339060565 Thanks for the info, will investigate. This is an

[GitHub] lbruun opened a new pull request #191: [NETBEANS-54] Module Review swing.validation

2017-10-24 Thread GitBox
lbruun opened a new pull request #191: [NETBEANS-54] Module Review swing.validation URL: https://github.com/apache/incubator-netbeans/pull/191 Project includes `ValidationAPI.jar` (CDDL licensed), originally hosted on Kenai, now GitHub. Changed dead references to Kenai to their

[GitHub] vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-24 Thread GitBox
vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-339110849 All source is Apache 2 licensed, so no worries regarding point 1. See #192 for a fix.

[GitHub] matthiasblaesing commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-24 Thread GitBox
matthiasblaesing commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-339115637 Another approach (java based patching):

[GitHub] vieiro opened a new pull request #192: [NETBEANS-54] Module Review o.apache.xml.resolver (Build fails on sys?

2017-10-24 Thread GitBox
vieiro opened a new pull request #192: [NETBEANS-54] Module Review o.apache.xml.resolver (Build fails on sys? URL: https://github.com/apache/incubator-netbeans/pull/192 Build fails on systems without the 'patch' command line tool. - The ant 'patch' task requires an external

[GitHub] geertjanw commented on issue #191: [NETBEANS-54] Module Review swing.validation

2017-10-25 Thread GitBox
geertjanw commented on issue #191: [NETBEANS-54] Module Review swing.validation URL: https://github.com/apache/incubator-netbeans/pull/191#issuecomment-339280203 Thanks for this investigation and changes, merging. This is an

[GitHub] geertjanw closed pull request #191: [NETBEANS-54] Module Review swing.validation

2017-10-25 Thread GitBox
geertjanw closed pull request #191: [NETBEANS-54] Module Review swing.validation URL: https://github.com/apache/incubator-netbeans/pull/191 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] geertjanw commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-25 Thread GitBox
geertjanw commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339280397 I think that makes sense, yes, i.e., please adjust license headers of those files.

[GitHub] geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-25 Thread GitBox
geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-339280650 Should this be merged or closed? This is an automated message

[GitHub] geertjanw closed pull request #189: [NETBEANS-54] Module Review web.browser.api

2017-10-25 Thread GitBox
geertjanw closed pull request #189: [NETBEANS-54] Module Review web.browser.api URL: https://github.com/apache/incubator-netbeans/pull/189 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] geertjanw commented on issue #189: [NETBEANS-54] Module Review web.browser.api

2017-10-25 Thread GitBox
geertjanw commented on issue #189: [NETBEANS-54] Module Review web.browser.api URL: https://github.com/apache/incubator-netbeans/pull/189#issuecomment-339280812 Thanks. This is an automated message from the Apache Git

[GitHub] geertjanw commented on issue #190: [NETBEANS-54] Module Review o.apache.commons.io

2017-10-25 Thread GitBox
geertjanw commented on issue #190: [NETBEANS-54] Module Review o.apache.commons.io URL: https://github.com/apache/incubator-netbeans/pull/190#issuecomment-339281165 Thanks. This is an automated message from the Apache Git

[GitHub] geertjanw closed pull request #190: [NETBEANS-54] Module Review o.apache.commons.io

2017-10-25 Thread GitBox
geertjanw closed pull request #190: [NETBEANS-54] Module Review o.apache.commons.io URL: https://github.com/apache/incubator-netbeans/pull/190 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] geertjanw closed pull request #180: [NETBEANS-54] Module Review java.hints.declarative

2017-10-25 Thread GitBox
geertjanw closed pull request #180: [NETBEANS-54] Module Review java.hints.declarative URL: https://github.com/apache/incubator-netbeans/pull/180 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] geertjanw commented on issue #174: Add a license header template for new files of NetBeans modules

2017-10-25 Thread GitBox
geertjanw commented on issue #174: Add a license header template for new files of NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/174#issuecomment-339281422 I think this can be merged, or should something be done still?

[GitHub] geertjanw commented on issue #180: [NETBEANS-54] Module Review java.hints.declarative

2017-10-25 Thread GitBox
geertjanw commented on issue #180: [NETBEANS-54] Module Review java.hints.declarative URL: https://github.com/apache/incubator-netbeans/pull/180#issuecomment-339281482 OK, merging. This is an automated message from the

[GitHub] rosslamont commented on issue #158: [NETBEANS-54] Module Review css.editor

2017-10-20 Thread GitBox
rosslamont commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338317539 Thx folks, do you want the fixes squashed into the original commit or would you like the history to match your comments? (not quite

[GitHub] rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform

2017-10-20 Thread GitBox
rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform URL: https://github.com/apache/incubator-netbeans/pull/166#discussion_r146058601 ## File path: java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/queries/Bundle.properties

[GitHub] junichi11 commented on issue #164: [NETBEANS-54] Module Review debugger.jpda.ui

2017-10-20 Thread GitBox
junichi11 commented on issue #164: [NETBEANS-54] Module Review debugger.jpda.ui URL: https://github.com/apache/incubator-netbeans/pull/164#issuecomment-338350808 > For the genfiles.properties I would consider not adding a header. I'll revert them. Thanks!

[GitHub] junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor

2017-10-20 Thread GitBox
junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338351224 > do you want the fixes squashed into the original commit Yes, maybe, it is preferred.

[GitHub] asfgit closed pull request #154: NETBEANS-87 - incorrect warning displayed

2017-10-21 Thread GitBox
asfgit closed pull request #154: NETBEANS-87 - incorrect warning displayed URL: https://github.com/apache/incubator-netbeans/pull/154 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw commented on issue #171: Module Review usersguide (part 1)

2017-10-21 Thread GitBox
geertjanw commented on issue #171: Module Review usersguide (part 1) URL: https://github.com/apache/incubator-netbeans/pull/171#issuecomment-338396189 Usersguide module has around 750 unlicensed HTML files, i.e., the JavaHelp files. I relicensed about half of them via this PR, after this

[GitHub] geertjanw closed pull request #107: Removed failing tests dependent on nbm

2017-10-21 Thread GitBox
geertjanw closed pull request #107: Removed failing tests dependent on nbm URL: https://github.com/apache/incubator-netbeans/pull/107 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw commented on issue #107: Removed failing tests dependent on nbm

2017-10-21 Thread GitBox
geertjanw commented on issue #107: Removed failing tests dependent on nbm URL: https://github.com/apache/incubator-netbeans/pull/107#issuecomment-338386939 Looks like a good solution, not deleting but disabling, so as not to remove the related knowledge from the project.

[GitHub] geertjanw commented on issue #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
geertjanw commented on issue #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#issuecomment-338408292 I believe they're done now, review and comments welcome.

[GitHub] geertjanw commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
geertjanw commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146106901 ## File path:

[GitHub] geertjanw commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
geertjanw commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146103819 ## File path:

[GitHub] matthiasblaesing commented on issue #157: [NETBEANS-94] Cannot build NB Javadocs on Windows

2017-10-21 Thread GitBox
matthiasblaesing commented on issue #157: [NETBEANS-94] Cannot build NB Javadocs on Windows URL: https://github.com/apache/incubator-netbeans/pull/157#issuecomment-338396584 Thank you - merged. This is an automated message

[GitHub] asfgit closed pull request #157: [NETBEANS-94] Cannot build NB Javadocs on Windows

2017-10-21 Thread GitBox
asfgit closed pull request #157: [NETBEANS-94] Cannot build NB Javadocs on Windows URL: https://github.com/apache/incubator-netbeans/pull/157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] matthiasblaesing commented on issue #134: [NETBEANS-54] Module Review httpserver

2017-10-21 Thread GitBox
matthiasblaesing commented on issue #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134#issuecomment-338413745 Thank you very much. From my perspective the testing part was important. I squashed your commits together and pushed them as

[GitHub] asfgit closed pull request #134: [NETBEANS-54] Module Review httpserver

2017-10-21 Thread GitBox
asfgit closed pull request #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146105949 ## File path:

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146105934 ## File path:

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146106017 ## File path:

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146105884 ## File path:

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146105918 ## File path:

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146105894 ## File path:

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146105907 ## File path:

[GitHub] junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on a change in pull request #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#discussion_r146105916 ## File path:

[GitHub] asfgit closed pull request #136: [NETBEANS-54] Module Review hibernate

2017-10-21 Thread GitBox
asfgit closed pull request #136: [NETBEANS-54] Module Review hibernate URL: https://github.com/apache/incubator-netbeans/pull/136 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] borxa commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver

2017-10-21 Thread GitBox
borxa commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134#discussion_r146103308 ## File path: httpserver/external/binaries-list ## @@ -14,4 +14,4 @@ # KIND, either express or

[GitHub] lbruun commented on issue #154: NETBEANS-87 - incorrect warning displayed

2017-10-21 Thread GitBox
lbruun commented on issue #154: NETBEANS-87 - incorrect warning displayed URL: https://github.com/apache/incubator-netbeans/pull/154#issuecomment-338370262 @matthiasblaesing Thanks for reviewing. You are absolutely right. Changes implemented as requested.

[GitHub] matthiasblaesing closed pull request #170: Fix unittests for Netbeans Build system

2017-10-21 Thread GitBox
matthiasblaesing closed pull request #170: Fix unittests for Netbeans Build system URL: https://github.com/apache/incubator-netbeans/pull/170 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] borxa commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver

2017-10-21 Thread GitBox
borxa commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134#discussion_r146103320 ## File path: httpserver/nbproject/project.xml ## @@ -153,7 +153,7 @@

[GitHub] lbruun commented on issue #157: [NETBEANS-94] Cannot build NB Javadocs on Windows

2017-10-21 Thread GitBox
lbruun commented on issue #157: [NETBEANS-94] Cannot build NB Javadocs on Windows URL: https://github.com/apache/incubator-netbeans/pull/157#issuecomment-338371571 @matthiasblaesing Thank you for reviewing. Changes implemented as requested. Yes, I have an ICLA on file.

[GitHub] junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor

2017-10-20 Thread GitBox
junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338363064 > Fixes requested thus far done. Thank you! Please exclude CascadeStyleSheet.css.template and CssExample from rat.

[GitHub] vieiro opened a new pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-21 Thread GitBox
vieiro opened a new pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172 - Updated external/binaries-list with Maven coordinates for the sources. - Created external/xml-resolver-1.2-netbeans.patch and

[GitHub] bondolo opened a new pull request #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting

2017-10-21 Thread GitBox
bondolo opened a new pull request #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting URL: https://github.com/apache/incubator-netbeans/pull/173 Extraneous braces will also be removed according to user preference

[GitHub] rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform

2017-10-20 Thread GitBox
rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform URL: https://github.com/apache/incubator-netbeans/pull/166#discussion_r146059919 ## File path:

[GitHub] junichi11 opened a new pull request #174: Add a license header template for new files of NetBeans modules

2017-10-21 Thread GitBox
junichi11 opened a new pull request #174: Add a license header template for new files of NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/174 There are differences between current license header and existing license template for Apache 2.0. So we should have a new

[GitHub] bondolo commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting

2017-10-21 Thread GitBox
bondolo commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting URL: https://github.com/apache/incubator-netbeans/pull/173#issuecomment-338439126 I agree that not everyone might want this; in part the patch is to allow people to not have

[GitHub] junichi11 commented on issue #145: [NETBEANS-54] Module Review apisupport.wizards

2017-10-21 Thread GitBox
junichi11 commented on issue #145: [NETBEANS-54] Module Review apisupport.wizards URL: https://github.com/apache/incubator-netbeans/pull/145#issuecomment-338439059 Perfect. Thank you for fixing them! This is an automated

[GitHub] vieiro opened a new pull request #175: [NETBEANS-54] Module Review extexecution.process (patch)

2017-10-21 Thread GitBox
vieiro opened a new pull request #175: [NETBEANS-54] Module Review extexecution.process (patch) URL: https://github.com/apache/incubator-netbeans/pull/175 - We now generate the external/winp-1.14-patched.jar binary from Maven sources with a patch.

[GitHub] asfgit closed pull request #164: [NETBEANS-54] Module Review debugger.jpda.ui

2017-10-22 Thread GitBox
asfgit closed pull request #164: [NETBEANS-54] Module Review debugger.jpda.ui URL: https://github.com/apache/incubator-netbeans/pull/164 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] lbruun commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting

2017-10-22 Thread GitBox
lbruun commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting URL: https://github.com/apache/incubator-netbeans/pull/173#issuecomment-338463594 Thank you for explanation, bondolo. You are touching something sensitive here as people

[GitHub] geertjanw commented on issue #171: Module Review usersguide (part 1)

2017-10-22 Thread GitBox
geertjanw commented on issue #171: Module Review usersguide (part 1) URL: https://github.com/apache/incubator-netbeans/pull/171#issuecomment-338464100 Yes, by hand. :-) If someone has a way to automate this, great; in the meantime, my focus is to get it done.

[GitHub] geertjanw opened a new pull request #176: [NETBEANS-54] Module Review usersguide (part 2)

2017-10-22 Thread GitBox
geertjanw opened a new pull request #176: [NETBEANS-54] Module Review usersguide (part 2) URL: https://github.com/apache/incubator-netbeans/pull/176 This is an automated message from the Apache Git Service. To respond to

[GitHub] geertjanw commented on issue #174: Add a license header template for new files of NetBeans modules

2017-10-22 Thread GitBox
geertjanw commented on issue #174: Add a license header template for new files of NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/174#issuecomment-338471263 Makes sense, good idea. This is an

[GitHub] matthiasblaesing commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-22 Thread GitBox
matthiasblaesing commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#discussion_r146129038 ## File path: o.apache.xml.resolver/build.xml ## @@ -20,5 +20,45 @@ --> +

[GitHub] matthiasblaesing commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-22 Thread GitBox
matthiasblaesing commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#discussion_r146129202 ## File path: o.apache.xml.resolver/external/xml-resolver-1.2-netbeans.patch ##

[GitHub] matthiasblaesing commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-22 Thread GitBox
matthiasblaesing commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#discussion_r146129108 ## File path: o.apache.xml.resolver/external/binaries-list ## @@ -14,4 +14,7 @@

<    3   4   5   6   7   8   9   10   >