geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans
URL:
https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338715094
I would suggest not for the first incubator release of Apache NetBeans
(incubating). I.e., for the first release, I propose we
geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans
URL:
https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338707204
It seems to me that these are all "test data for which the addition of a
source header would cause the tests to fail" -- i.e.,
geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans
URL:
https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338635407
Can you see which ones fail? I don't see a difference in terms of failed
tests.
geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans
URL:
https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338618636
Failed unit tests increase because of this pull request?
This is
geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans
URL:
https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338512032
Waiting for someone to review, will then merge this.
This is an
