[GitHub] incubator-netbeans issue #6: [NETBEANS-54] Module Review db

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/6 @svenreimers @jlahoda thanks for taking time for review! I merged the change into master. I'm manually closing this here, as the merge was done as a fast-forward merge and

Re: [GitHub] incubator-netbeans issue #6: [NETBEANS-54] Module Review db

Indeed, if there's been discussion about a PR and if there's agreement on it (and no big disagreements) and if you're a comitter... go ahead and do the push. Gj On Wed, 27 Sep 2017 at 20:54, jlahoda wrote: > Github user jlahoda commented on the issue: > >

[GitHub] incubator-netbeans issue #6: [NETBEANS-54] Module Review db

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/6 Matthias, you are an Apache Netbeans committer, right? So you should be able to push this directly to the apache repository (https://git-wip-us.apache.org/repos/asf/incubator-netbeans). (I

[GitHub] incubator-netbeans issue #6: [NETBEANS-54] Module Review db

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/6 @svenreimers @jlahoda I reverted the fix for the unittest to get this merged at some point, but I don't agree with your assessment. ---

[GitHub] incubator-netbeans issue #6: [NETBEANS-54] Module Review db

Github user asfgit commented on the issue: https://github.com/apache/incubator-netbeans/pull/6 Can one of the admins verify this patch? ---