Re: submit PR

2018-04-01 Thread Geertjan Wielenga
it-pr.html , so i just fork > it and submit PR, right? Do I need to register myself as a team or whatever? > Thanks > From Peter > >

submit PR

2018-04-01 Thread Peter Cheung
Hi All I want to add a filter to the “customize toolbars” window, to filter out the buttons i want. Am I welcome for this? I have read https://netbeans.apache.org/participate/submit-pr.html , so i just fork it and submit PR, right? Do I need to register myself as a team or whatever? Thanks

Re: Wiki page on how to submit PR

2017-10-02 Thread Neil C Smith
Hi, On Mon, 2 Oct 2017, 15:16 Eric Barboni, wrote: > > I started a new page [1] to help people making PR. I'm novice in git and > nice workflow with GitHub. > This is a good start. From experience if this is particularly aimed at people unused to GitHub, you may want to be more explicit that

Re: Wiki page on how to submit PR

2017-10-02 Thread Matthias Bläsing
Hi Emilian, Am Montag, den 02.10.2017, 16:36 +0300 schrieb Emilian Bold: > Most important, before a master commit: > > git checkout feature > git checkout -b temporary-branch > git rebase -i master > # [Clean up the history] > git checkout master > git merge temporary-branch why do you insist on

Re: Wiki page on how to submit PR

2017-10-02 Thread Emilian Bold
Lots of useful info here https://www.atlassian.com/git/tutorials/merging-vs-rebasing Most important, before a master commit: git checkout feature git checkout -b temporary-branch git rebase -i master # [Clean up the history] git checkout master git merge temporary-branch --emi On Mon, Oct 2,

Wiki page on how to submit PR

2017-10-02 Thread Eric Barboni
Hi, I started a new page [1] to help people making PR. I'm novice in git and nice workflow with GitHub. Changing name and mail seems to be important but as git by default allow committing with local name you may lose a bit of time (:D) . Many thanks to Matthias and Emilian Regards -E