[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

Re: Direction for Integration Tests

Just another small note - I believe pure unit test are very imp because they are light weight and can give us 100% test coverage.  The standalone/no ext dependencies gives us more confidence about interaction of the objects.  They are not as light as unit tests and perhaps take a littler longer

Re: Direction for Integration Tests

I also like Mans categories, as I know I have personally written some unit tests that don't require any external dependencies, but might have veered closer to an integration test than a true unit test. Some examples I am thinking of are the tests for Put/GetSolr which use and EmbeddedSolrServer, or

Re: Direction for Integration Tests

I like that Mans' categories. Logically, I think the 2nd and 3rd categories fold together with "no dependency" integration tests being another case alongside "hadoop dependency", "jms dependency", "aws dependency", etc. Then I would expect that - every component should have unit tests, - m

Re: Direction for Integration Tests

Hi: My thought is that we can classify tests into 3 major categories -  - Pure unit test - class isolated using mocks etc - Integration with no external dependencies - some interaction with other classes/in memory db, or mocks, but no external resources. - Integration with external res

Re: Direction for Integration Tests

Definitely agree and can see value in those as well. The core issue I am trying to address with this is that as highlighted by Joe. As an intermediate step, I have created a PR [1] that shows how I envision a baseline of this. Currently this treats all ITs (in this external resource context) the

[GitHub] nifi pull request: NIFI-589 Creating basis for integration-tests i...

GitHub user apiri opened a pull request: https://github.com/apache/nifi/pull/173 NIFI-589 Creating basis for integration-tests in build Introducing the maven-failsafe-plugin to the root pom.xml. Refactoring AWS integration level tests to make use of the IT* prefix and removing @Igno

[GitHub] nifi pull request: [A-2013] Updating bootstrap.conf to reflect lat...

Github user ymao1 closed the pull request at: https://github.com/apache/nifi/pull/172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] nifi pull request: [A-2013] Updating bootstrap.conf to reflect lat...

GitHub user ymao1 opened a pull request: https://github.com/apache/nifi/pull/172 [A-2013] Updating bootstrap.conf to reflect latest. Added langauge detection models directory to the bootstrap.conf to reflect changes made to bootstrap template in puppet for WF-2013 You can merge thi

Re: S3 configuration

Patrick, Can you access S3 with the AWS CLI tools ? Something like "list-buckets" is enough to confirm you can access S3 ok from the system your using. Regards, Joe On Wed, Jan 13, 2016 at 10:37 AM, Joe Percivall < joeperciv...@yahoo.com.invalid> wrote: > Hello Patr

Re: S3 configuration

Hello Patrick, Sorry no one has gotten back to you on this. Are you still having an issue? Unfortunately I don't have any S3 experience. Is there anyone else that can weigh in? Joe- - - - - - Joseph Percivall linkedin.com/in/Percivall e: joeperciv...@yahoo.com On Friday, January 8, 2016 4

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/169#issuecomment-171320882 @olegz - going to test build on a couple of platforms before I merge this in --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Direction for Integration Tests

Aldrin IMHO there are two types of integration testing; 1. Integration testing a Processor/ControllerService with the actual target system, 2. Integration testing of the flow or part of the flow. The second one essentially is the same as the first one but the target system is being NiFi itself

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/169#issuecomment-171283707 @trkurc went ahead with your suggestion. It's definitely safer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Re: Direction for Integration Tests

Aldrin, +1 + That sounds like a great approach, especially since it leverages existing Surefire/Failsafe features. Ideally, the TestXXX unit tests can filled out using Mocks and then the ITXXX integration tests will follow up with the real service tests. For the integration tests, since not