[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/280#issuecomment-211726456 @jskora do you think this PR can be closed now given the updates made to fix the underlying defects found? A new PR could be submitted which adds the proposed features

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/354#issuecomment-211726075 I am less concerned about thread safety of the transforms themselves now. Jolt's docs do refer to this at the readme level

Re: [ANNOUNCE] Apache NiFi 0.6.1 release

It would be an unnecessary party foul to kill off the old tags right? On Tue, Apr 19, 2016 at 12:21 AM, Sean Busbey wrote: > No magic that I know of. Each project that I've seen do this just > pushed new tags. Some make the tag point to the prior release tag, > some have it

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/354#issuecomment-211724253 Oleg off-list pointed out the finer concerns with the member variable. While it seems pretty far out it also seems like it is accurate. In reading

Re: [ANNOUNCE] Apache NiFi 0.6.1 release

No magic that I know of. Each project that I've seen do this just pushed new tags. Some make the tag point to the prior release tag, some have it point to the commit that the prior release tag points to. Those who want to be fancy use git cli to make the date match. On Mon, Apr 18, 2016 at 10:58

Re: [ANNOUNCE] Apache NiFi 0.6.1 release

Is there some good git magic to follow to do this Sean? I could push new signed tags? On Mon, Apr 18, 2016 at 11:54 PM, Sean Busbey wrote: > The "rel/" prefix is part of the implementation of an ASF policy that > requires a > protected immutable tag for releases. It will be

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/354#issuecomment-211718256 @joewitt As I am thinking more about it, you have a point for @OnStopped, so I am retracting my comment. As for volatile, what's at question is the visibility of the

Re: [ANNOUNCE] Apache NiFi 0.6.1 release

The "rel/" prefix is part of the implementation of an ASF policy that requires a protected immutable tag for releases. It will be present on all releases going forward and we should probably add them for our prior releases. On Mon, Apr 18, 2016 at 12:28 PM, Aldrin Piri

[GitHub] nifi pull request: NIFI-1614 File Identity Provider implementation

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/267#issuecomment-211716593 @jvwing @alopresto Have you had a chance to re-engage on this? It seems like a reasonable easy-path option for folks just wanting to use some simple/local username and

Slack for 'apachenifi'?

Team, In attempting to test/review NIFI-1578 I went to slack to create a team for 'apachenifi'. I found though that it wasn't available. Anyone here already make that and if so can you transfer it to the Apache NiFi PMC? Thanks Joe

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/252#issuecomment-211712568 @jskora I recall there was some discussion where you were considering supporting this as part of something a bit broader. Is that right or is this one you think good to

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-211711893 I can, but it might not be until later this week. On Mon, Apr 18, 2016 at 11:26 PM, Joe Witt wrote: > Anyone in a good position

[GitHub] nifi pull request: Nifi 1540 - AWS Kinesis Get and Put Processors

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/239#issuecomment-211711720 Hello @mans2singh . Do you think you'll have a chance to incorporate these review feedback items? --- If your project is set up for it, you can reply to this email and

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-211711025 Anyone in a good position to test/validate this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/354#issuecomment-211708711 @YolandaMDavis @olegz some feedback. 1. The com.bazaar.jolt... dependency does not appear to be accounted for in the LICENSE/NOTICE updates. Their LICENSE does

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60167981 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,211

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60167411 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,211

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/354#issuecomment-211703487 @YolandaMDavis this looks very good. One general comment; Just to finish the life-cycle loop I'd suggest adding a stop operation (operation annotated with @OnStopped) where

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/188#issuecomment-211702845 @rickysaltzer Looks like there might be a lack of time to focus on this at this time. How do you feel about closing this PR down for now and revisiting later? --- If

[GitHub] nifi pull request: NiFi-924: Camel integration

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/219#issuecomment-211701587 Commented on NIFI-924 to reference https://issues.apache.org/jira/browse/NIFI-1571 and consider this as resolved by that. --- If your project is set up for it, you can

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user YolandaMDavis commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60164832 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@

[GitHub] nifi pull request: NIFI-1197 Added SSL support for MongoDB process...

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/360#discussion_r60159711 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java --- @@

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60155833 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60155646 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1197 Added SSL support for MongoDB process...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/360#discussion_r60144583 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java --- @@ -52,6

[GitHub] nifi pull request: NIFI-1197 Added SSL support for MongoDB process...

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/360#discussion_r60144254 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java --- @@

[GitHub] nifi pull request: NIFI-1197 Added SSL support for MongoDB process...

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/360#discussion_r60144137 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java --- @@

[GitHub] nifi-minifi pull request: MINIFI-18 Moving initialization of confi...

Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/361 NIFI-1778 Adding NiFiBolt to write back to NiFi from Storm - Adding example topology that creates a full loop between NiFi and Storm. - Bumping Storm to 0.10.0 There is an example topology

[GitHub] nifi-minifi pull request: MINIFI-18 Moving initialization of confi...

GitHub user apiri opened a pull request: https://github.com/apache/nifi-minifi/pull/11 MINIFI-18 Moving initialization of configuration notifier/listener from constructor MINIFI-18 Moving initialization of configuration notifier/listener from constructor such that it is only

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60118214 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60118046 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60117078 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user YolandaMDavis commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60115891 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@

[GitHub] nifi-minifi pull request: MINIFI-14 Incorporating Listener/Notifie...

Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1678

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60107339 --- Diff:

[GitHub] nifi pull request: NIFI-1028 initial commit of NiFi In Depth docum...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/339#discussion_r60105112 --- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc --- @@ -0,0 +1,209 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] nifi pull request: NIFI-1771 deprecated ObjectHolder

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1028 initial commit of NiFi In Depth docum...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/339#discussion_r60103526 --- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc --- @@ -0,0 +1,209 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/324#issuecomment-211491167 Actually ran into this error myself on both Travis and the efforts of https://issues.apache.org/jira/browse/NIFI-1654 for Appveyor. I found that using JUnit temp

[GitHub] nifi pull request: NIFI-1771 deprecated ObjectHolder

Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/351#issuecomment-211491138 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: Nifi 1214

Github user ToivoAdams commented on a diff in the pull request: https://github.com/apache/nifi/pull/321#discussion_r60099883 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/verifier/ConditionsBuilder.java --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/324#issuecomment-211487325 @pvillard31 any idea why? I mean 'target' directory should be deletable. Just wonder if you have any idea/pointers? --- If your project is set up for it, you can reply to

Re: [ANNOUNCE] Apache NiFi 0.6.1 release

The "rel" prefix is a bit of a deviation from what we have been doing. Up to this point, it had been x.y.z-RC# up until a final release occurred resulting in just an x.y.z tag. On Mon, Apr 18, 2016 at 1:19 PM, James Wing wrote: > Found it, thank you. Is "rel/nifi-0.6.1" the

Re: [ANNOUNCE] Apache NiFi 0.6.1 release

Yep! Thanks for catching that. Had made but not pushed. Should be there now. On Mon, Apr 18, 2016 at 12:10 PM, James Wing wrote: > Thanks, Joe. Will the 0.6.1 git tag be published as part of the release? > > On Mon, Apr 18, 2016 at 5:23 AM, Joe Witt

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60093499 --- Diff:

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60092307 --- Diff:

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60090174 --- Diff:

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60088663 --- Diff:

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60087458 --- Diff:

Re: [ANNOUNCE] Apache NiFi 0.6.1 release

Thanks, Joe. Will the 0.6.1 git tag be published as part of the release? On Mon, Apr 18, 2016 at 5:23 AM, Joe Witt wrote: > Hello > > The Apache NiFi team would like to announce the release of Apache NiFi > 0.6.1. > > Apache NiFi is an easy to use, powerful, and reliable

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60086063 --- Diff:

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60084831 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60084343 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-1582 added state to UpdateAttribute as wel...

Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/319#discussion_r60083778 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

Github user YolandaMDavis commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60080948 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@

Re: Is my custom processor doing too many things? OnTrigger question

Oleg, thanks for your help and patience, much appreciated. No, I would actually like to stop the flow if I am catching or at least I thought it was what I was doing with session.transfer(flowFile, FAILURE). Is that incorrect? -- View this message in context:

[GitHub] nifi pull request: NIFI-1661 add random() function to expression l...

Github user ckmcd commented on the pull request: https://github.com/apache/nifi/pull/322#issuecomment-211429563 I've update the PR to address the issues (1 & 2) from above. 1. Updated the EL Guide to use plus() instead of add() 2. Use Math.abs() so as only to generate

Re: Is my custom processor doing too many things? OnTrigger question

Well, you have session transfer to success after postHttp call; You don’t need to do that since you only wan to transfer the new file to success. Also, I am not sure I understand the exception handling. You seem to be catching exception, handling it and attempt to create flow file regardless if

[GitHub] nifi pull request: NIFI-1755 Fixed remote process group status cou...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/347#issuecomment-211417082 @pvillard31 I was gonna play with it a bit more and possibly create the test, but getting tied up with other things. Yet I was able to dig up one of my experiments that I

Re: Is my custom processor doing too many things? OnTrigger question

Thanks Oleg, would this be what I want? public void onTrigger(final ProcessContext context, final ProcessSession session) throws ProcessException { FlowFile flowFile = session.get(); if (flowFile == null) return; final String userId =

[GitHub] nifi pull request: NIFI-1568: Add Filter Capability to UnpackConte...

Github user rickysaltzer commented on the pull request: https://github.com/apache/nifi/pull/248#issuecomment-211408619 sure thing, @olegz. I just got back from vacation today, so I will try and take a look this week. Thanks! --- If your project is set up for it, you can reply to

Re: Is my custom processor doing too many things? OnTrigger question

I don’t see any response from postHttp. You just invoke a method and that’s it. I thought you said you need to send the results of HTTP Post (json) downstream. If so you should receive response form HTTP and create a new FlowFile (session.create(..) or session.clone(..)) and write the contents

[GitHub] nifi-minifi pull request: MINIFI-14 Incorporating Listener/Notifie...

Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/10#discussion_r60062578 --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf/bootstrap.conf --- @@ -28,6 +28,16 @@

Re: Is my custom processor doing too many things? OnTrigger question

Oleg, this is actually a great idea, I will follow it for certain (a good compromise, too). I have an additional question on the onTrigger method for my Post Http. Among the main NiFi components, my custom processor contains a number of separate methods, in particular one that send a Post HTTP

[GitHub] nifi-minifi pull request: MINIFI-14 Incorporating Listener/Notifie...

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/10#discussion_r60062452 --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf/bootstrap.conf --- @@ -28,6 +28,16 @@

[GitHub] nifi pull request: NIFI-1582 added state to UpdateAttribute as wel...

Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/319#discussion_r60060311 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java

[GitHub] nifi pull request: NIFI-1582 added state to UpdateAttribute as wel...

Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/319#discussion_r60060257 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java

Re: Is my custom processor doing too many things? OnTrigger question

Idioma I would suggest for your learning experience to have custom processor to do your HTTP stuff and if successful transfer to ‘success’ relationship and connect it to PutKafka processor that comes with NiFi. This way you’ll not only be able to learn on how to develop custom processor but

Re: Is my custom processor doing too many things? OnTrigger question

Thank you Joe and thank you for understanding the struggle of a newbie, not many communities are so welcoming and inclusive like Apache NiFi Developer List! :) Yes, you are right posting to a URL endpoint to get a response and put that on Kafka is all I want, do you have any existing out of the

Re: Is my custom processor doing too many things? OnTrigger question

Idioma, No worries about questions being newbie questions. We're here to help and grow the community so you have to start somewhere! You will get lots of opinions on whether something is doing too many things. For this example you've provided I'd say yes it is probably doing too many things.

[GitHub] nifi pull request: NIFI-1724 Added properties to configure log lev...

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Is my custom processor doing too many things? OnTrigger question

Hi, I have some fundamental questions on a custom Processor I am working on. First of all, I think I am trying to do too many things in one custom processor (correct me if I am wrong :) as 1) I am sending a Post HTTP request 2) Posting the JSON response to Kafka. In my custom processor I have all

[ANNOUNCE] Apache NiFi 0.6.1 release

Hello The Apache NiFi team would like to announce the release of Apache NiFi 0.6.1. Apache NiFi is an easy to use, powerful, and reliable system to process and distribute data. Apache NiFi was made for dataflow. It supports highly configurable directed graphs of data routing, transformation,

Re: Multiple nar/custom processors: advisable directory structure

Yes, but eventually I have resorted to copy and pasted the existing nar and processor folders and changing references in the pom.xml and in the resources folder. Thank you! -- View this message in context:

[GitHub] nifi pull request: NIFI-1724 Added properties to configure log lev...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/348#issuecomment-211349732 @pvillard31 Looks good, will test and merge. Could you please reassign this issue in JIRA to yourself (since you did all the work)? Even if its resolved it would be nice

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211322321 Was able to validate that when/if someone attempts to delete a connected processor a window pops up with the error message "Destination of Connection

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211319503 @pvillard31 also, when you submit PR click on "Submit Patch" in JIRA (without writing anything in description). I know it may be a bit awkward but this is how we signal

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211318338 Perfect, reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-211295813 @olegz I just added a unit test even if I don't think it is a vital one! Otherwise it's ready for final review. --- If your project is set up for it, you can reply to

[GitHub] nifi pull request: NIFI-1755 Fixed remote process group status cou...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/347#issuecomment-211283811 @olegz I agree a unit test would be nice, but I must admit that I am not sure to see how to do it. It involves RPG, remote ports, remote processors and I don't see how

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211276565 @olegz You're right, just added a unit test. (Note: I believe that travis build failure is not related to this PR) --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-1724 Added properties to configure log lev...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/348#issuecomment-211276895 @olegz You're right, just added a unit test. (Note: I believe that travis build failure is not related to this PR) --- If your project is set up for it, you can reply