Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Tony Kurc
+1 (binding) went through helper with clean mvn repo, everything checks out and built beautifully On Thu, Mar 14, 2019 at 9:27 PM Koji Kawamura wrote: > +1 binding > > Went through release helper guide. > Thanks Joe for managing this release! > > On Fri, Mar 15, 2019 at 9:34 AM Aldrin Piri wro

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Koji Kawamura
+1 binding Went through release helper guide. Thanks Joe for managing this release! On Fri, Mar 15, 2019 at 9:34 AM Aldrin Piri wrote: > > +1, binding > > comments: > hashes and signature looked good > build, tests, and contrib check good on Ubuntu and MacOS > > > On Thu, Mar 14, 2019 at 6:58 PM

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Aldrin Piri
+1, binding comments: hashes and signature looked good build, tests, and contrib check good on Ubuntu and MacOS On Thu, Mar 14, 2019 at 6:58 PM James Wing wrote: > +1 (binding) - Ran through the release helper, checked the signatures, > license/readme, and ran the full build. Ran a simple tes

Re: Question about ListFile Test

2019-03-14 Thread Bryan Rosander
I've seen similar issues building locally on OSx. I tried going back and building 1.8.0 and saw similar behavior as master. Haven't been able to sort it out yet though. Thanks, Bryan On Thu, Mar 14, 2019 at 6:41 PM Ryan Withers wrote: > Hello all, > > I'm encountering an error in the TestList

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread James Wing
+1 (binding) - Ran through the release helper, checked the signatures, license/readme, and ran the full build. Ran a simple test flow. Thanks, Joe, for putting this release together! On Tue, Mar 12, 2019 at 10:49 PM Joe Witt wrote: > Hello, > > I am pleased to be calling this vote for the sour

Question about ListFile Test

2019-03-14 Thread Ryan Withers
Hello all, I'm encountering an error in the TestListFile.java class and in the testFilterAge() specifically. This unit test and associated class can be found in the Nifi-Standard-Bundle. I've noticed a couple issues have been reported on ListFile before. My issue is most closely related to this

Re: Configuration Service

2019-03-14 Thread Bryan Bende
This original thread was from quite a long time ago, and there have been many improvements since then, one of which is a variable registry that is exposed directly through the UI [1] and does not require bouncing the NiFi instance. [1] https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#Va

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Kevin Doran
+1 (binding) Ran through the steps in the release helper guide and verified that NIFI-6108 is fixed in this release. Thanks again for RM'ing, Joe. Kevin On Thu, Mar 14, 2019 at 11:41 AM Laszlo Horvath wrote: > > +1 (non-binding) > > - Verified signature > - Verified hashes > - Verified the bui

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Laszlo Horvath
+1 (non-binding) - Verified signature - Verified hashes - Verified the build, tests were successful - Verified Git commit ID - Binary starts as expected Laszlo On Thu, Mar 14, 2019 at 3:43 PM Andrew Lim wrote: > +1 (non-binding) > > -Ran full clean install on OS X (10.14.2) > -Ran some simple

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Kevin Doran
Agree we should probably update master to use the latest plugin. For what it's worth, on the RC, I ran this and both completed fine: mvn -T 2 install -Pcontrib-check,include-grpc,include-atlas mvn install -Pdocker -DskiptTests -pl nifi-docker/dockermaven I am logged into dockerhub. On T

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Otto Fowler
Maybe we should update to the latest dockerfile-maven-plugin On March 14, 2019 at 10:49:39, Otto Fowler (ottobackwa...@gmail.com) wrote: Logging into docker hub got me past that issue On March 14, 2019 at 10:46:00, Otto Fowler (ottobackwa...@gmail.com) wrote: https://github.com/spotify/docker

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Otto Fowler
Logging into docker hub got me past that issue On March 14, 2019 at 10:46:00, Otto Fowler (ottobackwa...@gmail.com) wrote: https://github.com/spotify/docker-maven-plugin/issues/350 maybe? I will try logging into docker hub and see On March 14, 2019 at 10:43:22, Otto Fowler (ottobackwa...@gma

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Otto Fowler
https://github.com/spotify/docker-maven-plugin/issues/350 maybe? I will try logging into docker hub and see On March 14, 2019 at 10:43:22, Otto Fowler (ottobackwa...@gmail.com) wrote: I got the same error after resume On March 14, 2019 at 10:42:05, Otto Fowler (ottobackwa...@gmail.com) wrote

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Andrew Lim
+1 (non-binding) -Ran full clean install on OS X (10.14.2) -Ran some simple flows successfully -Reviewed documentation updates Drew > On Mar 13, 2019, at 1:49 AM, Joe Witt wrote: > > Hello, > > I am pleased to be calling this vote for the source release of Apache NiFi > 1.9.1. > > The source

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Otto Fowler
I got the same error after resume On March 14, 2019 at 10:42:05, Otto Fowler (ottobackwa...@gmail.com) wrote: [ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.3.5:build (default) on project nifi-toolkit-assembly: Could not build image: com.spotify.docker.client.shaded.com.fas

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Otto Fowler
[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.3.5:build (default) on project nifi-toolkit-assembly: Could not build image: com.spotify.docker.client.shaded.com.fasterxml.jackson.databind.JsonMappingException: Can not construct instance of com.spotify.docker.client.messages.Re

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Bryan Bende
+1 (binding) Ran through release helper and everything looked good, tested a few flows and auto-loading of NARs, worked as expected. On Thu, Mar 14, 2019 at 8:55 AM Mike Thomsen wrote: > > Disregard, I misinterpreted something, but I am having weird local issues > with the maven docker plugin cr

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Aldrin Piri
Interestingly enough, I had started another build from where that one failed using resume from. That worked and generated the images which seems to function appropriately. Gives a bit more credence to the possible naughtiness on the behalf of the plugin. On Thu, Mar 14, 2019 at 10:03 AM Aldrin P

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Aldrin Piri
That is interesting. Seems like the plugin may possibly be doing mischievous things with how it handles some of our libraries in the associated build context. Several of these libs, presumably, are also those we adjusted in NIFI recently. I think this is okay to adjust after the release as this

Re: Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Otto Fowler
You mean RC1? I’ll try to reproduce On March 14, 2019 at 09:18:49, Mike Thomsen (mikerthom...@gmail.com) wrote: mvn clean install -Pdocker Throws the following error: [WARNING] An attempt failed, will retry 1 more times org.apache.maven.plugin.MojoExecutionException: Could not build image at c

Docker build broken for me in 1.9.1RC2

2019-03-14 Thread Mike Thomsen
mvn clean install -Pdocker Throws the following error: [WARNING] An attempt failed, will retry 1 more times org.apache.maven.plugin.MojoExecutionException: Could not build image at com.spotify.plugin.dockerfile.BuildMojo.buildImage(BuildMojo.java:185) at com.spotify.plugin.dockerfile.Buil

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Mike Thomsen
Disregard, I misinterpreted something, but I am having weird local issues with the maven docker plugin crapping out on me that I normally don't have. On Thu, Mar 14, 2019 at 8:52 AM Mike Thomsen wrote: > Still trying it out, but the version is 1.9.0 in the Dockerfiles. So > anyone wanting to tes

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Mike Thomsen
Still trying it out, but the version is 1.9.0 in the Dockerfiles. So anyone wanting to test it that way will need a manual patch. On Wed, Mar 13, 2019 at 11:01 PM Nathan Gough wrote: > +1 (non-binding) > > - Verified signature > - Verified checksums > - mvn contrib executed successfully > - Crea

Re: [VOTE] Release Apache NiFi 1.9.1 (rc1)

2019-03-14 Thread Jeremy Dyer
+1 (binding) Verified signature, hashes. Build succeeded with contrib-check Started NiFi up and tested S3 and GCS processors. Also tested auto loading of nars without restart > On Mar 13, 2019, at 11:00 PM, Nathan Gough wrote: > > +1 (non-binding) > > - Verified signature > - Verified checksum

Re: Configuration Service

2019-03-14 Thread Abhay Pasad
One of the major issues with an external variable registry file which we refer to in the nifi.properties file is that it needs NiFi instance to be bounced. While this may serve your purpose in the lower environments in a purpose, at an enterprise level cluster this might not be feasible in higher e