RE: [EXT] Re: Thoughts on an internal "Terminate" handler for special processors

2019-06-19 Thread Peter Wicks (pwicks)
Mark, Lots of good questions. I'll write up a JIRA on it at least, and finish reviewing your original PR on Terminate (https://github.com/apache/nifi/pull/2555/). Thanks, Peter -Original Message- From: Mark Payne Sent: Wednesday, June 19, 2019 9:27 AM To: dev@nifi.apache.org

Re: Thoughts on an internal "Terminate" handler for special processors

2019-06-19 Thread Mark Payne
Peter, Without thinking through this too much, I am not opposed to the idea, but there are certainly a lot of things that would have to be carefully thought through around the lifecycle: - When a processor is terminated, its threads are interrupted. They may or may not ignore the interrupt.

NiFi and Mockito 2.28.2

2019-06-19 Thread Jeff
NiFi Developers, Recently, NIFI-6360 [1] was resolved with PR 3533 [2] merged to master. All NiFi components were upgraded to use Mockito version 2.28.2, including updating those components to use mockito-core instead of mockito-all since the mockito-all distribution was discontinued in Mockito

Thoughts on an internal "Terminate" handler for special processors

2019-06-19 Thread Peter Wicks (pwicks)
I've run into a few cases where a processor that works with external resources (DBCP especially) will hang and can't be properly terminated. I was thinking it would make sense to have an interface or annotation that these processors could have that would flag them for "special" termination.