+1, binding
Comments:
* signature and hashes looked good
* license and notification looked correct and comprehensive
* performed build and test successfully on Ubuntu 19.04, CentOS 7, and
MacOS 10.14
* ran a variety of flows and achieved expected results
* we should update the helper to have
The PR solution is slightly different from mine. It short-circuits the
validation immediately if the required API is the generic
"ControllerService" interface. I suppose that's better to put up front
rather than run through the whole chain only to reach the "special case" at
the end.
This
Mark,
Good timing; Shawn, Bryan and I were talking about that on the Apache
NiFi Slack just today. It's been captured in NIFI-6852 [1] and Shawn
has drafted a PR [2] and is working on a unit test for it. My overall
thought is that you really shouldn't be binding to the generic
ControllerService,
I have a custom controller service with dynamic properties. The dynamic
property value is expected to be a controller service. Therefore, the
getSupportedDynamicPropertyDescriptor returns a PropertyDescriptor from the
Builder with "identifiesControllerService(ControllerService.class)". This
is
