[GitHub] nifi issue #611: NIFI-2119 Fixed 0.7.0 release blocker for cluster secure co...

2016-07-06 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/611 This was merged to `0.x`. I will open a new PR with the changes for `master`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request #611: NIFI-2119 Fixed 0.7.0 release blocker for cluster se...

2016-07-06 Thread alopresto
Github user alopresto closed the pull request at: https://github.com/apache/nifi/pull/611 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #611: NIFI-2119 Fixed 0.7.0 release blocker for cluster se...

2016-07-06 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/611 NIFI-2119 Fixed 0.7.0 release blocker for cluster secure communications The client and server sockets were being treated the same when attempting to extract the peer certificate DN (server sockets

[GitHub] nifi issue #554: NIFI-2032 port for 0.x

2016-06-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/554 I'm going to rebase, squash, and re-push. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] nifi issue #554: NIFI-2032 port for 0.x

2016-06-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/554 I fixed an issue in `GetSNMPTest` (a local variable was referenced from within an inner class, and wasn't declared `final`). I forgot to squash it with the commit that closed the PR. It was c

[GitHub] nifi issue #554: NIFI-2032 port for 0.x

2016-06-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/554 I am getting test failures: ``` Results : Failed tests: KafkaPublisherTest.validateSuccessfulSendAsDelimited:106 expected:<3> but w

[GitHub] nifi issue #551: Removed duplicate dependency declaration from nifi-standard...

2016-06-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/551 Thanks @pvillard31 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #551: Removed duplicate dependency declaration from nifi-s...

2016-06-21 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/551 Removed duplicate dependency declaration from nifi-standard-processor… …s/pom.xml. Simple PR for duplicated dependency declaration (probably a copy/paste error). Did not open Jira for

[GitHub] nifi issue #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/541 I merged into master but I've had to rebase and resolve conflicts 3 times on `0.x` branch and still have tests failing. Will continue working on that part in the morning. --- If your proje

[GitHub] nifi issue #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/541 Getting a compilation failure missing `import org.apache.nifi.reporting.BulletinFactory`. Did this get missed in the second commit? --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/541 Thanks @olegz . I will build locally and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67740493 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67738328 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi issue #544: Nifi 1958

2016-06-17 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/544 Thanks for adding `wks`. I built locally and verified the checkstyle. Please rebase and squash all the commits and push, and I will merge into `master` and `0.x`. --- If your project is set up

[GitHub] nifi pull request #544: Nifi 1958

2016-06-17 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/544#discussion_r67587861 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/FormatUtils.java --- @@ -41,8 +41,9 @@ private static final String MINS = join

[GitHub] nifi pull request #544: Nifi 1958

2016-06-17 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/544#discussion_r67587884 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/FormatUtils.java --- @@ -176,6 +177,12 @@ public static long getTimeDuration(final

[GitHub] nifi issue #544: Nifi 1958

2016-06-17 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/544 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-17 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67581551 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-17 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67581275 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...

2016-06-16 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/328 Merged and closed. Will do the same for [PR 533](https://github.com/apache/nifi/pull/533). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...

2016-06-15 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/328 I've tried to build this locally twice (clean checkouts and everything). It is failing with a compilation error in `MonitorMemoryTest` saying that `UserService` cannot be found. I had to clean

[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...

2016-06-15 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/328 Thanks @olegz . If you rebase and squash, I'll verify and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #328: NIFI-1690 Changed MonitorMemory to use allowable val...

2016-06-15 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/328#discussion_r67210183 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java --- @@ -154,30

[GitHub] nifi pull request #256: NIFI-1578: Create PutSlack processor

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/256#discussion_r67098716 --- Diff: nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java --- @@ -0,0 +1,238

[GitHub] nifi pull request #328: NIFI-1690 Changed MonitorMemory to use allowable val...

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/328#discussion_r67093804 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java --- @@ -154,30

[GitHub] nifi pull request #328: NIFI-1690 Changed MonitorMemory to use allowable val...

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/328#discussion_r67079817 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java --- @@ -91,12

[GitHub] nifi pull request #328: NIFI-1690 Changed MonitorMemory to use allowable val...

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/328#discussion_r67076846 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/pom.xml --- @@ -1,60 +1,69 @@ -http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #256: NIFI-1578: Create PutSlack processor

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/256#discussion_r67039592 --- Diff: nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java --- @@ -0,0 +1,238

[GitHub] nifi pull request #256: NIFI-1578: Create PutSlack processor

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/256#discussion_r67025553 --- Diff: nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java --- @@ -0,0 +1,238

[GitHub] nifi issue #256: NIFI-1578: Create PutSlack processor

2016-06-14 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/256 Built, passed checkstyle, and ran a sample flow posting to the Apache NiFi #test channel and directed at a user. Once the above comments are addressed, I'll revisit, but preliminary +1. -

[GitHub] nifi pull request #256: NIFI-1578: Create PutSlack processor

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/256#discussion_r67024788 --- Diff: nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java --- @@ -0,0 +1,238

[GitHub] nifi pull request #256: NIFI-1578: Create PutSlack processor

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/256#discussion_r67024579 --- Diff: nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java --- @@ -0,0 +1,238

[GitHub] nifi issue #508: NIFI-1981 Cluster communication without client certificate

2016-06-14 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/508 @mattyb149 merged to `0.x`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi pull request #508: NIFI-1981 Cluster communication without client certi...

2016-06-14 Thread alopresto
Github user alopresto closed the pull request at: https://github.com/apache/nifi/pull/508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #508: NIFI-1981 Cluster communication without client certi...

2016-06-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/508#discussion_r66991211 --- Diff: nifi-commons/nifi-security-utils/pom.xml --- @@ -30,6 +30,21 @@ org.apache.commons commons-lang3

[GitHub] nifi issue #508: NIFI-1981 Cluster communication without client certificate

2016-06-14 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/508 Squashing and will push. Thanks @mattyb149 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request #508: NIFI-1981 Cluster communication without client certi...

2016-06-13 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/508#discussion_r66900373 --- Diff: nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/CertificateUtilsTest.groovy --- @@ -272,4 +275,179 @@ class

[GitHub] nifi pull request #508: NIFI-1981 Cluster communication without client certi...

2016-06-07 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/508 NIFI-1981 Cluster communication without client certificate This PR resolves an issue where cluster communications were failing when the node sent a heartbeat without a client certificate chain

[GitHub] nifi issue #491: NIFI-1960: Update admin guide regarding documentation for c...

2016-06-03 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/491 +1 for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65756334 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65754466 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65753532 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65753430 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65753157 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752750 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752470 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752318 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752022 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65751497 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi issue #474: NIFI-1919 Add replaceFirst method to expression language

2016-06-01 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/474 @joewitt No existing methods are changing in this fix. A new ticket is filed for NIFI-1938 to address any breaking changes. --- If your project is set up for it, you can reply to this email and

[GitHub] nifi pull request #474: NIFI-1919 Add replaceFirst method to expression lang...

2016-06-01 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/474#discussion_r65406019 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/processors/script/ExecuteScriptGroovyTest.groovy

[GitHub] nifi pull request #474: NIFI-1919 Add replaceFirst method to expression lang...

2016-06-01 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/474#discussion_r65405940 --- Diff: nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/ReplaceEvaluator.java

[GitHub] nifi pull request: NIFI-1919 Add replaceFirst method to expression language

2016-05-31 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/474 Fixed the re-organization of import sections by the IDE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1919 Add replaceFirst method to expression...

2016-05-27 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/474#issuecomment-78473 Will rebase the merge after it's been reviewed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request: NIFI-1919 Add replaceFirst method to expression...

2016-05-27 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/474 NIFI-1919 Add replaceFirst method to expression language I will open an additional Jira for 1.0 to consider renaming the `replace` method to `replaceAllLiteral` or something similar, and add logic

[GitHub] nifi pull request: NIFI-1918 Ignored failing test because timing i...

2016-05-24 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/465 NIFI-1918 Ignored failing test because timing is not deterministic an… …d should not be used in unit test. I did not delete the test because it is still illustrative in most cases of

[GitHub] nifi pull request: NIFI-1799 Implements auto-scaling flow layout

2016-05-24 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/442#issuecomment-221410007 Merged and closed. Did *not* port to 0.x branch as this code is for migration from 0.x to 1.0. --- If your project is set up for it, you can reply to this email and

[GitHub] nifi pull request: NIFI-1799 Implements auto-scaling flow layout

2016-05-24 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/442#issuecomment-221405938 Reviewing to merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request: NIFI-1799 Implements auto-scaling flow layout

2016-05-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/442#discussion_r64277394 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-19 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220464739 @mcgilman thanks for the response above. It feels a little to me like the authorizer has gotten conflated with user and group management tasks. If the authorizer

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220227038 @bbende thanks for the explanation. I suppose I am more familiar with, and conditioned to assume, the models used in many database-backed frameworks where the user and

[GitHub] nifi pull request: NIFI-1578: Create PutSlack processor

2016-05-18 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/256#issuecomment-220160457 @Edgardo, yes, NiFi provides access control and checks authentication and authorization (if configured) before allowing a user or entity to access the processor

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220108280 I'm not sure I understand the relationship between `User` and `Group` -- which class owns the relationship, and is it bidirectional? What would be the steps fo

[GitHub] nifi pull request: NIFI-1578: Create PutSlack processor

2016-05-18 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/256#issuecomment-220092091 Hi, While I understand making `webhook` a sensitive value means it does not "accompany" the template, it really is a sensitive value. Anyone with tha

[GitHub] nifi pull request: Eorgad patch nifi 539

2016-05-17 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/416#discussion_r63631088 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java --- @@ -0,0

[GitHub] nifi pull request: Added PGP key to KEYS file.

2016-05-16 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/450 Added PGP key to KEYS file. Added my public PGP key to the KEYS file to allow developers to verify signatures. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi pull request: NIFI-1799 Implements auto-scaling flow layout

2016-05-16 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/442#discussion_r63457225 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy

[GitHub] nifi pull request: NIFI-1799 Implements auto-scaling flow layout

2016-05-16 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/442#discussion_r63457158 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy

[GitHub] nifi pull request: NIFI-1799 Implements auto-scaling flow layout

2016-05-16 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/442#discussion_r63456899 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/PositionScaler.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

2016-05-16 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/449#issuecomment-219586093 @jtstorck because I did not merge this into the `master` branch, the phrase `This closes #449.` in the commit message will not close this PR. Can you please manually

[GitHub] nifi pull request: NIFI-1887 Updating default timeout in Admin Gui...

2016-05-16 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/447#issuecomment-219567073 Should have mentioned that you're not required to put the "Signed-off-by" when merging your own commits. As long as they've been reviewed by another

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

2016-05-16 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/449#issuecomment-219563962 @jtstorck now when the build is run, full test output is provided as follows: ``` [INFO] --- maven-surefire-plugin:2.18:test (default-test) @ nifi

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

2016-05-16 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/449#issuecomment-219556910 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1887 Updating default timeout in Admin Gui...

2016-05-16 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/447#issuecomment-219510269 It definitely takes some getting used to. Here is a [cheatsheet](https://gist.github.com/alopresto/c05485f80799cd3ba02461b07f1e82de) I wrote for myself. This PR is a

[GitHub] nifi pull request: NIFI-1887 Updating default timeout in Admin Gui...

2016-05-16 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/447#issuecomment-219498359 Looks good to me. Want to merge it yourself with your new committer powers? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request: NIFI-1822 ExecuteScript should allow concurrent...

2016-05-15 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/443#issuecomment-219314247 Rebuilt once the Apache repository was back online and everything is fine. This is the same reason the Travis CI build failed. --- If your project is set up for it

[GitHub] nifi pull request: NIFI-1822: Allow concurrent execution in Execut...

2016-05-14 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/387#issuecomment-219264620 I have opened a new [PR 443](https://github.com/apache/nifi/pull/443) with unit tests, fixes for the above issues, and additional changes. --- If your project is set

[GitHub] nifi pull request: NIFI-1822 ExecuteScript should allow concurrent...

2016-05-14 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/443 NIFI-1822 ExecuteScript should allow concurrent execution I have added some unit tests and fixed a few minor things in @mattyb149 's original contribution ([PR 387](https://github.com/apache

[GitHub] nifi pull request: NIFI-1822: Allow concurrent execution in Execut...

2016-05-13 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/387#issuecomment-219195734 I added some unit tests (not yet complete) and made the changes referenced above in a branch here: https://github.com/apache/nifi/compare/master...alopresto:pr387

[GitHub] nifi pull request: NIFI-1822: Allow concurrent execution in Execut...

2016-05-13 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/387#issuecomment-219194190 I also updated `MockProcessorContext` to allow for a configurable `maxConcurrentTasks` value, as it was previously hard-coded to 1. --- If your project is set up for

[GitHub] nifi pull request: NIFI-1822: Allow concurrent execution in Execut...

2016-05-13 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/387#discussion_r63269309 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/AbstractScriptProcessor.java

[GitHub] nifi pull request: NIFI-1822: Allow concurrent execution in Execut...

2016-05-13 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/387#discussion_r63269277 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/AbstractScriptProcessor.java

[GitHub] nifi pull request: NIFI-1799 Implements auto-scaling flow layout

2016-05-13 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/442#issuecomment-219185920 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...

2016-05-10 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/429#issuecomment-218324462 Yes, some people prefer to `squash` before opening the PR; others open the PR with incremental commits in place to show history/decisions. There are different opinions

[GitHub] nifi pull request: NIFI-1812 nifi-env scripts (linux/windows)

2016-05-10 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/386#issuecomment-218323644 Ran locally on Mac OS X 10.11.4 with both `./bin/nifi.sh start`/`stop` and `./bin/nifi.sh run`. Worked and merged. Backporting to 0.x support branch as well. --- If

[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...

2016-05-10 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/429#issuecomment-218318790 @ijokarumawak for future reference, you can push the changes to the same branch and the PR will update automatically. If you decide to rebase, you can do that as well

[GitHub] nifi pull request: NIFI-1862 User Guide corrections/improvements

2016-05-09 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/427#issuecomment-217917476 Reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1812 nifi-env scripts (linux/windows)

2016-05-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/386#discussion_r62085710 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh --- @@ -211,9 +211,9 @@ run() { # run

[GitHub] nifi pull request: NIFI-1812 nifi-env scripts (linux/windows)

2016-05-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/386#discussion_r62084290 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi-env.bat --- @@ -0,0 +1,29 @@ +@echo off

[GitHub] nifi pull request: NIFI-1812 nifi-env scripts (linux/windows)

2016-05-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/386#discussion_r62083303 --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java --- @@ -324,27 +324,46 @@ private void registerNotificationServices(final

[GitHub] nifi pull request: NIFI-1812 nifi-env scripts (linux/windows)

2016-05-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/386#discussion_r62082835 --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java --- @@ -324,27 +324,46 @@ private void registerNotificationServices(final

[GitHub] nifi pull request: NIFI-1614 File Identity Provider implementation

2016-05-03 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/267#issuecomment-216661583 I'm away from my keyboard right now but I have always used the `maven:shade` plugin. Andy LoPresto alopre...@hortonworks.com<mailt

[GitHub] nifi pull request: NIFI-1614 File Identity Provider implementation

2016-05-03 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/267#issuecomment-216594397 My recommendation would be a command line utility (could be a shell script wrapping a JAR) which is invoked without arguments, provides a secure prompt for entering a

[GitHub] nifi pull request: NIFI-1614 File Identity Provider implementation

2016-05-02 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/267#issuecomment-216417900 I think my earlier comments may have been unclear or ambiguous. I do not believe we need a full command-line interface for modifying the configuration file, as hand

[GitHub] nifi pull request: NIFI-1614 File Identity Provider implementation

2016-05-02 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/267#discussion_r61832014 --- Diff: nifi-nar-bundles/nifi-iaa-providers-bundle/nifi-file-identity-provider/src/main/java/org/apache/nifi/authentication/file/CredentialsStore.java

[GitHub] nifi pull request: NIFI-1614 File Identity Provider implementation

2016-05-02 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/267#discussion_r61817392 --- Diff: nifi-nar-bundles/nifi-iaa-providers-bundle/nifi-file-identity-provider/src/main/java/org/apache/nifi/authentication/file/CredentialsCLI.java

[GitHub] nifi pull request: NIFI-1818 Adjusting repository exception handli...

2016-04-27 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/385#issuecomment-215251460 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: Fixed typo in ScryptCipherProviderGroovyTest Ja...

2016-04-26 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/380 Fixed typo in ScryptCipherProviderGroovyTest Javadoc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-1813 Alternatively

[GitHub] nifi pull request: NIFI-1803: Exclude spark classes from nifi-spar...

2016-04-21 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/375#issuecomment-213243013 Also backported to 0.x. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1803: Exclude spark classes from nifi-spar...

2016-04-21 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/375#issuecomment-213233268 Reviewed, built, no issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   >