Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69828024
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -481,4 +496,51 @@ private
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/578
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/606
NIFI-2160 fixed service startup ordering (MASTER)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-2160
Alternatively you can
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/605
NIFI-2160 fixed service startup ordering
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-2160-0.x
Alternatively you can review
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68989065
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/555
NIFI-2067 ignored intermittently failing MemoryTest
left comment with the explanation as to why it was not removed
You can merge this pull request into a Git repository by running:
$ git pull
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/552
+1, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/554
NIFI-2032 port for 0.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-2032-0.x
Alternatively you can review and apply
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/543
Ok, consistency wins so a somewhat reluctant +1 :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67783621
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/541
@alopresto so I just fixed it and squashed it with the last commit. No
compilation error on my end. LMK
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67780170
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67779956
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutTCP.java
---
@@ -0,0 +1,48
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/541
I see, it appears that I have to reference different
```org.apache.nifi.events.BulletinFactory```, building now
---
If your project is set up for it, you can reply to this email and have your
reply
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67778279
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/541#discussion_r67766144
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67733058
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67732780
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67732631
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutTCP.java
---
@@ -0,0 +1,48
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67732149
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67731299
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,290
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/397
back to reviewing this. It has some merge conflicts but i'll fox them as I
go along
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user olegz closed the pull request at:
https://github.com/apache/nifi/pull/545
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/257
@pvillard31 Had a merge conflict again, but fixed it myself. Nothing to
do, just making comment for traceability.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/541#discussion_r67582485
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/257
Ok, finally I am in this PR and no distractions ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/537
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/538
@rekhajoshm this has been discussed (see NIFI-1774 JIRA comments) based on
the same change done and then un-done by @pvillard31. Basically changing
OnConfigured to OnEnabled is wrong and in itself
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/539
Thanks you Chris! Merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user olegz closed the pull request at:
https://github.com/apache/nifi/pull/533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/533
@alopresto so this is the 0.x port of NIFI-1690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/533
Nifi 1690 0.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1690-0.x
Alternatively you can review and apply these changes
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/328
@alopresto just fixed it. Took me a while to figure out what's going on but
you can read some details here: https://issues.apache.org/jira/browse/NIFI-1730
(last comment). Also, I am now going to have
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/257
. . . and you almost scored ;) but. . . anyway, will try to wrap it up
tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/511#discussion_r67223717
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/511#discussion_r67223433
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-jolt-transform-json-ui/src/main/java/org/apache/nifi/web/util/CustomUIUtils.java
---
@@ -0,0 +1,88
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/328
@alopresto all done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/520#discussion_r67190218
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/519
+1, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/520
Also, looking at #519 it appears that this PR sits on top of #519, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/520
Aside from that dead default constructor I am ok to merge it. Let me know
if you feel like removing it as part of this effort.
---
If your project is set up for it, you can reply to this email and have
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/520#discussion_r67159721
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/522#discussion_r67159525
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowFileQueueResource.java
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/522#discussion_r67159381
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerResource.java
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/511
@YolandaMDavis While I believe it looks good, I think someone from the web
team has to look at it as well
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/511#discussion_r67157791
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-jolt-transform-json-ui/src/main/java/org/apache/nifi/web/util/CustomUIUtils.java
---
@@ -0,0 +1,88
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/511#discussion_r67157240
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/511#discussion_r67156788
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/511#discussion_r67156509
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java
Github user olegz closed the pull request at:
https://github.com/apache/nifi/pull/515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/328
@alopresto all is addressed. Let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/328#discussion_r67150175
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java
---
@@ -154,30 +164,21
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/328#discussion_r67149972
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java
---
@@ -154,30 +164,21
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/328#discussion_r67149454
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java
---
@@ -91,12 +92,21
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/328#discussion_r67149312
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java
---
@@ -154,30 +164,21
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/328#discussion_r67149210
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java
---
@@ -154,30 +164,21
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/527
@pvillard31 all done. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67040326
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,238
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/528
NIFI-2006 fixed NPE in PersistentProvenanceRepository
Fixed NPE in PersistentProvenanceRepository caused by attribute value being
null
added test
You can merge this pull request into a Git
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/527
NIFI-2009 removed 'annotationData' and 'validationContextFactory' insâ¦
â¦tance variables from StandardProcessNode
You can merge this pull request into a Git repository by running:
$ git pull
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/516
@mattyb149 I got one better ;) Try PR
https://github.com/apache/nifi/pull/515 as it stands now and then with this
change. That is how it was discovered. I've attached some notes in JIRA. Let me
know
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/515
@mcgilman so, this is the initial commit that essentially demonstrates the
approach that is discussed in JIRA. Basically the new ID _ inceptionId_ is
generated and is immutable and perpetual
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/397
I stepped away from it as I am trying to finish something else that is very
involved. Will get back to it once I am finished, but I am committed to getting
it in to both 0.7.0 and 1.0.
---
If your
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/468
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/324
@JPercivall comments are addressed, so please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/494
Merging.
@thadguidry for the future, please raise JIRA prior to submitting PR
(regardless how small/trivial the issue may be)
---
If your project is set up for it, you can reply to this email
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/487
@pvillard31gave it some time and it looks like with regard to testing this
one will be one of those exceptions. In other words there is no easy way to
reliably write a test case to validate
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/397
True, and I did the same ('brew install tesseract') and got this
```
Trying a mirror...
==> Downloading
ftp://ftp.simplesystems.org/pub/libpng/png/src/libpng16/libpng-1.6.17.tar
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/397
Ok, while all is good on Windows I can't seem to have any success building
those _.so_ files on OSx. Normally I would not worry about it that much but
given that Tesseract distribution includes DLLs
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/487
Well, while you can simulate the server behavior by changing SSH server
configs locally, indeed it would be impossible to ensure consistency on all
machines where build may be running. So the only thing
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/397
The DLLs are distributed with the Tesseract JAR, but not _.so_ or other OS
specific libs. Basically the current JAR only supports Windows out-of-the-box.
@joewitt If I understand correctly we need
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/397
@jdye64 I left one last comment. Once addressed I'll begin the merge
procedure. I will also take care of LICENSE and NOTICE
---
If your project is set up for it, you can reply to this email and have
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r65548155
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,355
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/487
NIFI-1956 added 'keyboard-interactive' option to SFTPTransfer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1956
Alternatively
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/397
@jdye64 I had a chance to play with it today. Looking good and is simple
enough (which I like, since it leaves enough room for new features/improvements
as we learn usage patterns).
Left
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r65247766
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,359
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r65247502
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,359
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r64785162
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,361
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/324#issuecomment-221935626
@markap14 the "idempotency" comment is valid and I agree for that alone we
don't need multiple threads. I'll look again to see if test name matches with
what I wa
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r64783794
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,361
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r64783731
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,361
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r64783373
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,361
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r64782839
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,361
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r64782640
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,361
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r64781939
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java
---
@@ -0,0 +1,361
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/397#issuecomment-221929351
Ok, so I'll start reviewing this, but wanted to mention that at the current
state there are merge conflicts so feel free to fix them whenever or let me
know and I can help
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/324#issuecomment-221925828
"...how come the that issue wouldn't cause all following tests to fail..."
some times it does. You may want to consult with Mark on that since that error
originat
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/324#issuecomment-221917899
The issue is not with before, but with _after_, since it effectively acts
as a _finally_ block. The way it was before if a test failed for whatever
reason
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/466
NIFI-1915 Fixed '$' escape logic.
Fixed '$' escape logic (if not followed by number) to use
Matcher.quoteReplacement(java.lang.String) to
suppress its special meaning so it could be treated
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/463#issuecomment-221441775
Closing it as there are more work to be done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user olegz closed the pull request at:
https://github.com/apache/nifi/pull/463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/392#issuecomment-221343071
+1, all is good, test are passing.
You'll need another PR for 0.x branch since the commits can not be cherry
picked cleanly.
---
If your project is set up for it, you
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/463
NIFI-1915 Fixed '$' escape logic.
Fixed '$' escape logic (if not followed by number) to use
Matcher.quoteReplacement(java.lang.String) to
suppress its special meaning so it could be treated
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/456#issuecomment-220795133
@aperepel all squashed and pushed, including the change from WARN to INFO
for log message.
Let me know if there is anything else.
---
If your project is set up
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/456#discussion_r64043923
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteProcess.java
---
@@ -181,7
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/456
NIFI-1905 enabled ExecuteProcess to terminate process
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1905
Alternatively you can
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63919932
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,237
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63918814
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,237
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63917779
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,237
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63908853
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,237
1 - 100 of 452 matches
Mail list logo
