Re: [EXT] Using github to merge PRs and just generally easier tracking of commits..

2021-01-05 Thread Joe Witt
I dont know if you can tweak the message in github before hitting the button as a reviewer. Now that I see how to tell who merged though in any case Im less concerned personally. On Tue, Jan 5, 2021 at 10:56 AM Peter Wicks (pwicks) wrote: > Should mergers be putting the “signed-off by: …” in

Re: [EXT] Using github to merge PRs and just generally easier tracking of commits..

2021-01-05 Thread Peter Wicks (pwicks)
Should mergers be putting the “signed-off by: …” in when they Merge PR’s through Github? I haven’t merged anything in a while, but I was putting this in the comment box when I merged, and it showed up on the commit the same way it did when I did it through the CLI: