[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 This has been merged into master. Discovered a few new items and identified a few old items that we'll still need to knock out. Another item that we still need to tackle is ensuring that all node

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/488 Modifications that you proposed look good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Also just created another PR to consider building something to automated the conversion of the nifi.properties [1]. [1] https://issues.apache.org/jira/browse/NIFI-1967 --- If your project

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into another issue around cluster coordinator selection. When the selected coordinator has a unheritable flow it is treated as the 'golden' copy as they are the coordinator.

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Just ran into an issue with the fields that are used in the flow fingerprint. I think we need to reconsider which fields are included. Specifically I had modified the penalty

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into a small issue with node (re)connection regarding Templates. It appears that Templates local to that node are replaced with the cluster set of Templates. There is an

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 I've been reviewing this PR and have some initial findings. As I'm reviewing I'm updating various comments and naming that still reflect the previous clustering model. I've gone

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if