[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/143#issuecomment-165207075 Addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/143#discussion_r47814247 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java --- @@ -474,6 +475,18

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/143#discussion_r47814878 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java --- @@ -474,6 +475,18

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/143#discussion_r47814866 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java --- @@ -474,6 +475,18 @@

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/143#discussion_r47814729 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java --- @@ -474,6 +475,18 @@

Re: [GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread Oleg Zhurakousky
Thank you Sumanth Just raised https://issues.apache.org/jira/browse/NIFI-1296 so you can track it and contribute if you have more details/expertise. My biggest concern is compatibility with older brokers. Currently even though we’ve upgraded to 0.9 it is still compatible with 0.8 brokers for

Re: [GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread Sumanth Chinthagunta
Hi Oleg, For my case NiFi (consumer) has to talk to Kafka cluster behind firewall and it was difficult got Kafka brokers and ZooKeeper ports opened. I noticed that 0.9.0.0 support consumers directly communicate to Kafka brokers with `bootstrap.servers` setting. it might be good idea if you

Re: [GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread xmlking
May be we can create getKafka2 for 0.9.0.0, leaving original form backward compatibility. I will try new consumer API tomorrow and share here. My concern with old consumer API is, it depends on zookeeper and worried, I may have to open multiple ports on firewall as described here

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/143#issuecomment-165296041 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled