Re: Looking for reviewer for Unit Test only PR (NiFi-5381)

2018-08-06 Thread Joe Witt
peter appreciate the sensitivity to asking for reviews. It is definitely tough to keep up with them. Ones that are security relevant are even more challenging. This one as is looks pretty safe - i'll try to review today. I think it would be good to talk more through the ideas you have for

Looking for reviewer for Unit Test only PR (NiFi-5381)

2018-08-06 Thread Peter Wicks (pwicks)
I try really hard not to ask for PR reviews... but I have a PR that only adds unit tests for GetSFTP and PutSFTP that's been open for about a month. I have a sizeable number of other code changes ready that affect these processors and wanted to get better unit tests in place before moving