Re: Should I postpone submitting PR's on seriously breaking changes until prep for 2.0?

2018-04-24 Thread Joe Witt
Peter, Ideally you can still make large/significant changes and a lot of work has gone into making this possible. Often you can create entirely new versions of key components, shift things to use them for new configs but still work with the older components by default, then deprecate older compon

Should I postpone submitting PR's on seriously breaking changes until prep for 2.0?

2018-04-23 Thread Peter Wicks (pwicks)
I have a couple ideas for changes that would cause wide spread breakage (like moving the DatabaseAdapter selection into the DBCP Service). >From what I've seen, this level of non-backwards compatibility should be >postponed until a major version change? Thanks, Peter