[GitHub] nifi issue #444: NIFI-1118 adding SplitText features of size limit and heade...

2016-06-02 Thread mosermw
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/444 +1 LGTM. contrib-check on nifi-standard-bundle passes. Old unit tests from NIFI-1649 continue to work and new unit tests make sense. Templates from NIFI-1649 continue to work the same. Will

Re: cron updating value used by another processor

2016-06-02 Thread Edgardo Vega
Bryan, It worked technically. The only issue I see if that I am seeing spiky performance. It goes from having nothing in the queue before the Fetch to having 50k and then back down. There are only 2 items in the cache right now. Cheers, Edgardo On Wed, Jun 1, 2016 at 9:29 PM, Edgardo Vega

[GitHub] nifi issue #473: NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyB...

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/473 @mcgilman updated the PR to address the thread-safety, a summary of the changes... - Created a single data structure to encapsulate all data structures used by the FileAuthorizer so there can be a

[GitHub] nifi issue #290: NIFI-856 Implements experimental ListenLumberjack Processor

2016-06-02 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/290 Hey @trixpan, Looks good! Thanks for the changes. Will get this merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #290: NIFI-856 Implements experimental ListenLumberjack Pr...

2016-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #490: NIFI-1959 Added length and timestamp to detect rollover

2016-06-02 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/490 It remains an issue I have not been able to solve at this point: the case where the new file contains more data than the tailed file before being moved. In this case we ends up in the same

[GitHub] nifi pull request #490: NIFI-1959 Added length and timestamp to detect rollo...

2016-06-02 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/490 NIFI-1959 Added length and timestamp to detect rollover It improves robustness of the processor in case the property “Rolling filename pattern” is not set and the tailed file is moved for some

[GitHub] nifi issue #256: NIFI-1578: Create PutSlack processor

2016-06-02 Thread adamonduty
Github user adamonduty commented on the issue: https://github.com/apache/nifi/pull/256 @rstjohn I fixed the channel validator issue, would you mind trying it again? I think the implementation of attachments with dynamic properties sounds reasonable, but I think it makes sense to try

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 I've been reviewing this PR and have some initial findings. As I'm reviewing I'm updating various comments and naming that still reflect the previous clustering model. I've gone

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/483 @bbende Was aware of that possibility. What I couldn't find is a way of easily doing the same from Expression Language. It would be nice to be able to access the flowfile lineage from

[GitHub] nifi pull request #489: NIFI-1951: Custom UIs

2016-06-02 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/489 NIFI-1951: Custom UIs - Removing deprecated NiFiWebContext and related classes. - Adding authorization to Custom UIs. - Fixing issue when creating ControllerService inline. - Addressing

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-06-02 Thread mans2singh
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/239 @jvwing - I've updated the code to catch and log the exception and continue processing kinesis records as you had recommended. I can remove REL_FAILURE since it is not being

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-02 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/483 Sounds quite good to me @trixpan . I would just not worry about the additional attributes - yet. You identified good standard ones and if we find the need for more then we can iterate. You agree?

[GitHub] nifi pull request #488: NIFI-1897: Refactoring to allow requests to be repli...

2016-06-02 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/488 NIFI-1897: Refactoring to allow requests to be replicated from a node to other nodes Nodes are now capable of replicating requests across the cluster and a Cluster Coordinator is auto-elected to

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/483 @joewitt Second processor should be ready, will work on harness later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] nifi pull request #397: NIFI-1815

2016-06-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/397#discussion_r65548155 --- Diff: nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/main/java/org/apache/nifi/processors/ocr/TesseractOCRProcessor.java --- @@ -0,0 +1,355 @@

[GitHub] nifi issue #485: NIFI-1948 Fixed encoding-version attribute not getting crea...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/485 +1 Looks good. Verified functionality exporting/importing templates across 0.x and 1.x versions. Merged to master. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #480: NIFI-1943 added proper ReadsAttribute to PutFile

2016-06-02 Thread trkurc
Github user trkurc commented on the issue: https://github.com/apache/nifi/pull/480 I will start reviewing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi issue #480: NIFI-1943 added proper ReadsAttribute to PutFile

2016-06-02 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/480 Thanks @trkurc, should be quite simple --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #485: NIFI-1948 Fixed encoding-version attribute not getting crea...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/485 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/482 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #397: NIFI-1815

2016-06-02 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/397 @jdye64 I left one last comment. Once addressed I'll begin the merge procedure. I will also take care of LICENSE and NOTICE --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request #485: NIFI-1948 Fixed encoding-version attribute not getti...

2016-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #479: NIFI-1937 GetHTTP configurable redirect cookie policy

2016-06-02 Thread trkurc
Github user trkurc commented on the issue: https://github.com/apache/nifi/pull/479 I'll review this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] nifi issue #480: NIFI-1943 added proper ReadsAttribute to PutFile

2016-06-02 Thread trkurc
Github user trkurc commented on the issue: https://github.com/apache/nifi/pull/480 @JPercivall - I'm +1 on this. Would you like to merge it in, or prefer I do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/482 This has been merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #482: NIFI-1928: Remove registration

2016-06-02 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #480: NIFI-1943 added proper ReadsAttribute to PutFile

2016-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/480 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #480: NIFI-1943 added proper ReadsAttribute to PutFile

2016-06-02 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/480 @trkurc I can take care of it, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/482 +1 looks good, verified registration form no longer exists and access denied page is presented instead --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi issue #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/472 @mcgilman I merged this to master but forgot to update the commit message. Can you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi pull request #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/472 Will do. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: back pressure

2016-06-02 Thread pradeepbill
Ok , I can confirm, I dont see the below exception after using 0.6.1 jars.Thanks again Bryan.I dont know what will happen when I get a burst of data (yet to hit that), but with the incubating jars I could not even process anything because of exception below. java.io.NotSerializableException: