+1 (binding)
Ran through the steps in the release helper guide. Noticed a few
release helper instructions that can be improved for next time (no
mention of bootstrap.sh),
but was able to figure it out by using the README file included in the
source release.
Hashes & sig all looked good. Was able
+1 (binding)
Comments
- Notice file copyright year needs to be 2020
- I did not enable python support but I get the minifi-python dir anyway
and log entry on startup such as
Caught Exception ModuleNotFoundError: No module named 'google'
Great progress with this release! Nice work. Building
+1 (binding)
Ran through release helper. Verified signature, checksums, build, tests,
etc. Looks good.
Thanks for RMing Arpad!
On Fri, Jan 10, 2020 at 3:39 PM Kevin Doran wrote:
> +1 (binding)
>
> Ran through the steps in the release helper guide. Noticed a few
> release helper instructions
+1 (binding)
I encountered a number of obstacles during this validation, some of which are
definitely because I haven’t worked on the C++ effort (or even built it) in at
least 6 months. These are not complaints, just wrinkles I captured so we can
improve this process for next time. Noted here
Ivan,
First of all, welcome and happy to see contribution!
Not sure I properly understand the co-referencing issue, could you be a bit
more specific?
What would you like to achieve with MiNiFi on this stack?
Cheers,
Arpad
On Fri, Jan 10, 2020 at 2:00 PM Ivan Serdyuk
wrote:
> Informing about
Informing about recent attempts to bootstrap:
https://github.com/hex-five/multizone-secure-iot-stack/issues/67
https://issues.apache.org/jira/browse/MINIFICPP-1112
.
It is not properly co-referenced, between github and Jira (not yet). That
should be fixed - and I am not familiar with project
+1, non-binding
Verifications performed:
SHA256 checksums downloaded: OK
SHA512 checksum of nifi-minifi-cpp-0.7.0-source.tar.gz sent in mail: OK
GPG signatures downloaded: OK
Git tag in email matches sources in nifi-minifi-cpp-0.7.0-source.tar.gz: OK
bootstrap.sh with default options && make &&
