[GitHub] nifi issue #490: NIFI-1959 Added length and timestamp to detect rollover

2016-06-02 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/490 It remains an issue I have not been able to solve at this point: the case where the new file contains more data than the tailed file before being moved. In this case we ends up in the same

[GitHub] nifi pull request #490: NIFI-1959 Added length and timestamp to detect rollo...

2016-06-02 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/490 NIFI-1959 Added length and timestamp to detect rollover It improves robustness of the processor in case the property “Rolling filename pattern” is not set and the tailed file is moved for some

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65755477 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java --- @@ -0,0 +1,352

[GitHub] nifi issue #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/492 I am running out of time right now, but will have a deeper look later and give it a try asap. As a general comment, I'd say, even if I know how boring it can be, that some comments in the code

[GitHub] nifi issue #257: NIFI-1537 Added SNMP processors

2016-06-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/257 @trixpan @olegz @michalklempa I rebased the PR against master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #487: NIFI-1956 added 'keyboard-interactive' option to SFTPTransf...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/487 @olegz Just to be sure before merging in: do you plan to add a unit test? My guess is that it is not possible to simulate this server-side behavior, but I want to confirm. --- If your

[GitHub] nifi issue #486: NIFI-1929: Improvements for PutHDFS attribute handling

2016-06-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/486 +1 @mattyb149 merged in master and 0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-08 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 I have played with it and it works great. One remark: I am wondering if the 'HDFS_PATH_TO_WATCH' property should be improved: - accept the expression language to handle time-stamped

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65879551 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/EventAttributes.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65878804 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65878170 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65878313 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi issue #487: NIFI-1956 added 'keyboard-interactive' option to SFTPTransf...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/487 Agree. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65967740 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 @jjmeyer0 Yes you're absolutely right, I was not suggesting to have the three options together but rather think about what could be done to give more flexibility. I think there is a processor

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 Thanks @mans2singh ! I'll have a look asap (probably on Sunday or next week). Regarding the provenance event, I think we could have a SEND event for each flow file successfully sent to Ignite

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66513208 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66515866 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/AbstractIgniteProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66516313 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/resources/ignite-client.xml --- @@ -0,0 +1,26 @@ + + +http

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66513705 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66514855 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66514230 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/AbstractIgniteCacheProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66513495 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66510540 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/AbstractIgniteProcessor.java

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 @mans2singh Could you check all the lines marked as removed? I believe there should not be any and this is probably because of some settings in your IDE. --- If your project is set up for it, you

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66512938 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi issue #527: NIFI-2009 removed 'annotationData' and 'validationContextFa...

2016-06-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/527 LGTM +1. Do you mind fixing the import auto-ordering? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #527: NIFI-2009 removed 'annotationData' and 'validationContextFa...

2016-06-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/527 @olegz It seems it is in conflict with 0.x branch, could you check if I am wrong and if not submit a PR for 0.x? --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 Your changes look good to me. Let me know if you want to have a look to enable EL/RegEx on HDFS_PATH_TO_WATCH property (ReplaceText processor seems to accept both regex and expression language

[GitHub] nifi issue #521: NIFI-1998: Upgraded Cassandra driver to 3.0.2

2016-06-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/521 reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #521: NIFI-1998: Upgraded Cassandra driver to 3.0.2

2016-06-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/521 LGTM +1. Merged both in 0.x and master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #481: NiFi 1945 - Corrects minor issue in HashContent "

2016-06-01 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/481 Good catch. Will merge. However not sure why the travis build failed... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1915 Fixed '$' escape logic.

2016-06-01 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/466 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-14 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 @mans2singh Just had a new look and ran a workflow to test the processor. Few remarks even though I am not familiar with Ignite... First, I am not sure to see how I can check the content

[GitHub] nifi issue #257: NIFI-1537 Added SNMP processors

2016-06-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/257 @olegz half-time ;) done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67423663 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67424962 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -55,4 +55,35 @@ public void onTrigger(final ProcessContext ctx

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 @jjmeyer0 LGTM +1 tested with workflows, mvn build OK. Merged in master, but would you mind opening a specific PR for 0.x branch (Java 7 compatible): GetHDFSEvents.java:[208,78] error: local

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67428396 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi issue #551: Removed duplicate dependency declaration from nifi-standard...

2016-06-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/551 Merged in master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #552: NIFI-2066 dynamic port allocation in SNMP processors...

2016-06-21 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/552 NIFI-2066 dynamic port allocation in SNMP processors unit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-2066

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r67825492 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/AbstractEnrichProcessor.java --- @@ -0,0

[GitHub] nifi pull request #379: NIFI-1022 Added Tachyon/Alluxio processors

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/379#discussion_r67956841 --- Diff: nifi-nar-bundles/nifi-alluxio-bundle/nifi-alluxio-processors/src/main/java/org/apache/nifi/processors/alluxio/AbstractAlluxioProcessor.java

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2016-06-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/379 Thanks for the review @apiri! I still need to take into account some of your comments but I rebased the PR against master. While doing some additional testing, for a reason I can't explain yet

[GitHub] nifi issue #534: Fix for NIFI-1838 & NIFI-1152

2016-06-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/534 thanks @PuspenduBanerjee, I'm quite busy this WE, will have another look asap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #398: NIFI-1751 Added proxy authentication in InvokeHttp processo...

2016-06-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/398 Hey @apiri, Many thanks for the review! Regarding HTTPS, at the time I submitted the PR I was testing it with CCProxy (on Windows computer). I can't test it again with this setup

[GitHub] nifi issue #545: NIFI-2009 port for 0.x

2016-06-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/545 Thanks @olegz! I just merged it into 0.x, could you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #547: NIFI-2060 - fixed unit tests to be compatible with 2...

2016-06-20 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/547 NIFI-2060 - fixed unit tests to be compatible with 2.7.x It’s a shame to limit what is tested here (in terms of event types) but it seems to be the only way to have both 2.6 and 2.7 lines

[GitHub] nifi issue #398: NIFI-1751 Added proxy authentication in InvokeHttp processo...

2016-06-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/398 Yep, not sure it's worth it. I think it is fine to let the PR as is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor

2016-06-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/272 It should be OK, let me know if not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67390898 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -16,6 +16,9 @@ */ package org.apache.nifi.util

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67391289 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -36,7 +36,7 @@ public void testPenalizeFlowFileFromProcessor

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67392290 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -55,4 +55,35 @@ public void onTrigger(final ProcessContext ctx

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67390513 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -587,13 +589,15 @@ public void transfer(final FlowFile flowFile, final

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r68430574 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi issue #536: NIFI-1037 Ported processor for HDFS' inotify events to 0.x.

2016-06-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/536 Thanks @JPercivall! I didn't realize that... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-27 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 Hi @mans2singh, I didn't find time to give it a new try, but I hope I will this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #401: NIFI-1832 Allowing expression language in properties...

2016-06-17 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #536: NIFI-1037 Ported processor for HDFS' inotify events to 0.x.

2016-06-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/536 @jjmeyer0 Thanks! I just merged it in 0.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1063

2016-02-16 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/226 NIFI-1063 NIFI-1063 Logging exception in PutHDFS You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-1063 Alternatively you

[GitHub] nifi pull request: NIFI-1282

2016-02-16 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/228 NIFI-1282 Fixed error message when attempting to start a disabled port You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI

[GitHub] nifi pull request: NIFI-1252

2016-02-16 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/229 NIFI-1252 Allows empty private key passphrase by removing the validator on the property. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-17 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/232 NIFI-1521 Allows use of SSL in AMQP Processor Allows use of SSL in AMQP Processor You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-17 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185270244 Well I must admit I locally tested the change with a RabbitMQ server, but that's all. I had a look at the existing unit tests for AMQP processors but I am not sure

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/232#discussion_r53195449 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -84,6

[GitHub] nifi pull request: NIFI-1252

2016-02-17 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-18 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185598549 Should I consider a modification on the SSL context to let the user choose the client authentication policy? From what I see in the InvokeHTTP, this is NONE

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-18 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185642080 I added the use of SSL context and modified the pom file of nifi-amqp-processors to have: ```xml org.apache.nifi nifi

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-03-10 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-194834756 I just re-based the PR. Let me know if something else is needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

2016-03-14 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/272#issuecomment-196200486 Definitely agree with you that this API should not act this way. Anyway, just to clarify, this is only in the case there is no body/content sent

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

2016-03-12 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/272#issuecomment-195793923 Due to JIRA unavailability, I think the PR has not been linked to issue in JIRA. Just adding a comment to mention the PR in JIRA. --- If your project is set up

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

2016-03-14 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/272#issuecomment-196309847 @joewitt yes I can have a look this afternoon. I'll try to propose something before the end of the day. --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-1755 Fixed remote process group status cou...

2016-04-13 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/347 NIFI-1755 Fixed remote process group status counts by only considering connected remote ports You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

2016-04-11 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/324#issuecomment-208369542 @olegz Tests on master are OK but not when testing this PR. Windows 10 / Maven 3.3.9 : Java 1.0.8_74

[GitHub] nifi pull request: NIFI-1724 Added properties to configure log lev...

2016-04-13 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/348 NIFI-1724 Added properties to configure log level when file not found and permission denied on FetchFile processor You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi pull request: NIFI-1732 Added timeout property to override 30...

2016-04-08 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/337 NIFI-1732 Added timeout property to override 30s default when handling HTTP requests You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request: NIFI-1732 Added timeout property to override 30...

2016-04-08 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/337#issuecomment-207403440 @markap14 Thanks for the comments, I updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

2016-03-20 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/292#issuecomment-199134795 Everything OK, I'm a :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

2016-03-21 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/272#issuecomment-199144952 I updated the PR with a true/false "send body" property, should be in line with last comments. Let me know if not. --- If your project is set up for it, you

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

2016-03-22 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/272#issuecomment-199714780 @taftster Thanks Adam. I updated the PR regarding your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

2016-03-22 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/297#issuecomment-199874747 I'm a +1, all tests previously in failure are now OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

2016-03-22 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/297#issuecomment-199871907 Testing on Windows 7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1685 Optimize database Junit tests to redu...

2016-03-25 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/304#discussion_r57464551 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutSQL.java --- @@ -144,6

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

2016-03-20 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198968796 Tried a mvn clean install without success on my side (I missed something?): [mvn_output.txt](https://github.com/apache/nifi/files/181411/mvn_output.txt

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

2016-03-20 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198987604 @trkurc I am currently checking on my side why the other unit tests are in failure. But as you said, this is not related to this PR, so it is OK for me. --- If your

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

2016-03-20 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198970178 Windows 7 Pro / Maven 3.3.9 / Java 1.8.0_74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

2016-03-20 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198982574 Sorry for the delay... I am on a different computer than usual and forgot to check the git property. Did a full clone again (so slow with airport wifi...) and checked

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

2016-03-20 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198994990 Just for the record, the error is because of my local env. This is fixed by setting the locale to US on the scanner: `scanner.useLocale(java.util.Locale.US

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-24 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-200748951 @olegz I just rebased the PR. As @michalklempa mentioned, you can use online SNMP service provided by snmpsim (http://snmpsim.sourceforge.net/public-snmp

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/257#discussion_r55185061 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPUtils.java --- @@ -0,0 +1,268

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-06 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/257 NIFI-1537 Added SNMP processors Processors for SNMP set/get/walk operations over SNMP v1, v2c & v3 using SNMP4J library. You can merge this pull request into a Git repository by run

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-07 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-193298687 Oleg, yes sure, will do! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1332 Fixed HTTP-204 handling + unit test

2016-03-07 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/259 NIFI-1332 Fixed HTTP-204 handling + unit test You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-1332 Alternatively you can

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-07 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-193330177 Pre-requisite: NIFI-1595 has to be merged in before --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request: NIFI-1685 Optimize database Junit tests to redu...

2016-03-29 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/304#issuecomment-202778901 Tested and contrib-checked. Before: Running org.apache.nifi.processors.standard.TestPutSQL Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-04-04 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-205493328 @olegz Following comments on JIRA, I reverted modifications on SSL Context service and added a Client Auth property (as it has been done in Cassandra processors). I

[GitHub] nifi pull request: NIFI-1296, NIFI-1680, NIFI-1764 implemented new...

2016-04-24 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/366#issuecomment-213925464 @olegz @joewitt I updated my last comment to reflect the discussion I had with Oleg regarding the task counter: there is no issue, it was my mistake during debug

[GitHub] nifi pull request: NIFI-1816 Added provenance event SEND in Handle...

2016-04-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/389#discussion_r61540826 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java

[GitHub] nifi pull request: NIFI-1296, NIFI-1680, NIFI-1764 implemented new...

2016-04-23 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/366#issuecomment-213764931 I think there is an issue on Consumer side. Here is my test case: GenerateFlowFile -> ReplaceText -> PublishKafka ConsuleKafka -> UpdateAttribute -

[GitHub] nifi pull request: NIFI-1296, NIFI-1680, NIFI-1764 implemented new...

2016-04-23 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/366#discussion_r60829110 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/test/java/org/apache/nifi/processors/kafka/pubsub

  1   2   >