[GitHub] nifi pull request: NIFI-1916 Updating FileAuthorizer to extend AbstractPolic...

2016-05-31 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/473 @bbende Just realized that we'll need to introduce some thread safety here. The RevisionManager in the web tier will handle locking during the User/Group/Policy CRUD operations. However,

[GitHub] nifi pull request: NIFI-1916 Updating FileAuthorizer to extend AbstractPolic...

2016-05-31 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/473#discussion_r65270822 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAuthorizer.java --- @@

[GitHub] nifi pull request: NIFI-1916 Updating FileAuthorizer to extend AbstractPolic...

2016-05-31 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/473#discussion_r65268067 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -28,15 +28,15 @@ private final String identifier;