Re: Unused X-ProxyContextPath header in ApplicationResource

[Andy LoPresto]

Hi Adam,

Not sure if the unused constant in that class is just a remnant from a move or 
refactoring that wasn’t cleaned up, but the header itself is used in 
WebUtils.java [1] during request processing to determine the context path. That 
method is used in determining the resource path in ApplicationResource.java [2] 
and CatchAllFilter.java [3].



[1] 
https://github.com/apache/nifi/blob/master/nifi-commons/nifi-web-utils/src/main/java/org/apache/nifi/web/util/WebUtils.java#L214
 

[2] 
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ApplicationResource.java#L158
 

[3] 
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-error/src/main/java/org/apache/nifi/web/filter/CatchAllFilter.java#L72
 



Andy LoPresto
alopre...@apache.org
alopresto.apa...@gmail.com
PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69

> On May 15, 2018, at 12:02 PM, Martini, Adam  wrote:
> 
> Hello all,
> 
> I am wondering if there is any intention of using the X-ProxyContextPath 
> header in the org.apache.nifi.web.api.ApplicationResource class?
> 
> The class defines the static:
> public static final String PROXY_CONTEXT_PATH_HTTP_HEADER = 
> "X-ProxyContextPath";
> 
> However, it is unused and perhaps there is a good reason for this. Please let 
> me know if this is on our development radar. Also, let me know if there is a 
> different use for this header than I am aware of.
> 
> Thanks!
> 
> Adam Martini
> Senior Developer, Nike Digital



signature.asc
Description: Message signed with OpenPGP using GPGMail

Unused X-ProxyContextPath header in ApplicationResource

[Martini, Adam]

Hello all,

I am wondering if there is any intention of using the X-ProxyContextPath header 
in the org.apache.nifi.web.api.ApplicationResource class?

The class defines the static:
public static final String PROXY_CONTEXT_PATH_HTTP_HEADER = 
"X-ProxyContextPath";

However, it is unused and perhaps there is a good reason for this. Please let 
me know if this is on our development radar. Also, let me know if there is a 
different use for this header than I am aware of.

Thanks!

Adam Martini
Senior Developer, Nike Digital