[jira] [Commented] (NLPCRAFT-23) Refactor sqlgen tool.
[ https://issues.apache.org/jira/browse/NLPCRAFT-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063875#comment-17063875 ] Sergey Kamov commented on NLPCRAFT-23: -- ready for review in branch NLPCRAFT-23 based on NLPCRAFT-13 > Refactor sqlgen tool. > - > > Key: NLPCRAFT-23 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-23 > Project: NLPCraft > Issue Type: Improvement > Components: model >Reporter: Aaron Radzinski >Assignee: Sergey Kamov >Priority: Major > > # SQL joins should have a type (inner by default) that should be > auto-detected, if possible. > # Default sorting should support different table using 'table.column#order' > syntax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-23) Refactor sqlgen tool.
[ https://issues.apache.org/jira/browse/NLPCRAFT-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-23. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Implemented > Refactor sqlgen tool. > - > > Key: NLPCRAFT-23 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-23 > Project: NLPCraft > Issue Type: Improvement > Components: model >Reporter: Aaron Radzinski >Assignee: Aaron Radzinski >Priority: Major > > # SQL joins should have a type (inner by default) that should be > auto-detected, if possible. > # Default sorting should support different table using 'table.column#order' > syntax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-21) Error running all tests in the project.
[ https://issues.apache.org/jira/browse/NLPCRAFT-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-21: Assignee: Aaron Radzinski (was: Sergey Kamov) > Error running all tests in the project. > --- > > Key: NLPCRAFT-21 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-21 > Project: NLPCraft > Issue Type: Bug > Components: probe, test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.5.0 > > > 1) When you start all tests of the project, embedded probes cannot be started > after stop in previous tests. > Mar-19 18:08:31 [ERROR] Failed to start probe due to unexpected error. > java.lang.IllegalArgumentException: requirement failed > at scala.Predef$.require(Predef.scala:212) ~[scala-library-2.11.12.jar:?] > at org.apache.nlpcraft.common.NCService.start(NCService.scala:49) > ~[classes/:?] > 2) Part of tests use embedded probe, some require started probe, so all tests > never passed. I guess we have to use the same approach for all tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-15) Refactor probe enrichers to avoid impl knowledge about repeat execution.
[ https://issues.apache.org/jira/browse/NLPCRAFT-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-15. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed > Refactor probe enrichers to avoid impl knowledge about repeat execution. > > > Key: NLPCRAFT-15 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-15 > Project: NLPCraft > Issue Type: Improvement > Components: probe >Reporter: Aaron Radzinski >Assignee: Aaron Radzinski >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-24) Nested elements aren't detected well
Sergey Kamov created NLPCRAFT-24: Summary: Nested elements aren't detected well Key: NLPCRAFT-24 URL: https://issues.apache.org/jira/browse/NLPCRAFT-24 Project: NLPCraft Issue Type: Bug Components: probe Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.5.0 Test "nested.model", question " ". Second date is not recognized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-24) Nested elements aren't detected well
[ https://issues.apache.org/jira/browse/NLPCRAFT-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-24. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed > Nested elements aren't detected well > > > Key: NLPCRAFT-24 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-24 > Project: NLPCraft > Issue Type: Bug > Components: probe >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.5.0 > > > Test "nested.model", question " ". Second date is not recognized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-24) Nested elements aren't detected well
[ https://issues.apache.org/jira/browse/NLPCRAFT-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065915#comment-17065915 ] Sergey Kamov commented on NLPCRAFT-24: -- It wasn't a bug, but in branch 24 I have refactored test infrastructure and added small additional tests for the 'nested elements' model. Please look at it. > Nested elements aren't detected well > > > Key: NLPCRAFT-24 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-24 > Project: NLPCraft > Issue Type: Bug > Components: probe >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.5.0 > > > Test "nested.model", question " ". Second date is not recognized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-27) Refactor tests for examples to use embedded probe.
[ https://issues.apache.org/jira/browse/NLPCRAFT-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-27. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed > Refactor tests for examples to use embedded probe. > -- > > Key: NLPCRAFT-27 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-27 > Project: NLPCraft > Issue Type: Task > Components: examples >Reporter: Aaron Radzinski >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-21) Error running all tests in the project.
[ https://issues.apache.org/jira/browse/NLPCRAFT-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066860#comment-17066860 ] Sergey Kamov commented on NLPCRAFT-21: -- Fixed in NLPCRAFT-27 > Error running all tests in the project. > --- > > Key: NLPCRAFT-21 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-21 > Project: NLPCraft > Issue Type: Bug > Components: probe, test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.5.0 > > > 1) When you start all tests of the project, embedded probes cannot be started > after stop in previous tests. > Mar-19 18:08:31 [ERROR] Failed to start probe due to unexpected error. > java.lang.IllegalArgumentException: requirement failed > at scala.Predef$.require(Predef.scala:212) ~[scala-library-2.11.12.jar:?] > at org.apache.nlpcraft.common.NCService.start(NCService.scala:49) > ~[classes/:?] > 2) Part of tests use embedded probe, some require started probe, so all tests > never passed. I guess we have to use the same approach for all tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-21) Error running all tests in the project.
[ https://issues.apache.org/jira/browse/NLPCRAFT-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-21. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed > Error running all tests in the project. > --- > > Key: NLPCRAFT-21 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-21 > Project: NLPCraft > Issue Type: Bug > Components: probe, test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.5.0 > > > 1) When you start all tests of the project, embedded probes cannot be started > after stop in previous tests. > Mar-19 18:08:31 [ERROR] Failed to start probe due to unexpected error. > java.lang.IllegalArgumentException: requirement failed > at scala.Predef$.require(Predef.scala:212) ~[scala-library-2.11.12.jar:?] > at org.apache.nlpcraft.common.NCService.start(NCService.scala:49) > ~[classes/:?] > 2) Part of tests use embedded probe, some require started probe, so all tests > never passed. I guess we have to use the same approach for all tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-27) Refactor tests for examples to use embedded probe.
[ https://issues.apache.org/jira/browse/NLPCRAFT-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066861#comment-17066861 ] Sergey Kamov commented on NLPCRAFT-27: -- Fixed in NLPCRAFT-27 > Refactor tests for examples to use embedded probe. > -- > > Key: NLPCRAFT-27 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-27 > Project: NLPCraft > Issue Type: Task > Components: examples >Reporter: Aaron Radzinski >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-4) Test examples under Windows.
[ https://issues.apache.org/jira/browse/NLPCRAFT-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067642#comment-17067642 ] Sergey Kamov commented on NLPCRAFT-4: - win10, java 8, Idea2018.3. All tests passed in the master branch (12 passed, 1 ignored because disabled (PhoneTest)) > Test examples under Windows. > > > Key: NLPCRAFT-4 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-4 > Project: NLPCraft > Issue Type: Task > Components: test >Reporter: Aaron Radzinski >Assignee: Sergey Kamov >Priority: Major > Labels: newbie > Fix For: 0.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-4) Test examples under Windows.
[ https://issues.apache.org/jira/browse/NLPCRAFT-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-4. - Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed > Test examples under Windows. > > > Key: NLPCRAFT-4 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-4 > Project: NLPCraft > Issue Type: Task > Components: test >Reporter: Aaron Radzinski >Assignee: Aaron Radzinski >Priority: Major > Labels: newbie > Fix For: 0.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NLPCRAFT-7) List of complex DSL examples.
[ https://issues.apache.org/jira/browse/NLPCRAFT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov updated NLPCRAFT-7: Summary: List of complex DSL examples. (was: List of complex DSL examles.) > List of complex DSL examples. > - > > Key: NLPCRAFT-7 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-7 > Project: NLPCraft > Issue Type: Task > Components: docs >Reporter: Aaron Radzinski >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-28) Suppot maven tests
Sergey Kamov created NLPCRAFT-28: Summary: Suppot maven tests Key: NLPCRAFT-28 URL: https://issues.apache.org/jira/browse/NLPCRAFT-28 Project: NLPCraft Issue Type: Test Components: test Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.5.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-28) Suppot maven tests
[ https://issues.apache.org/jira/browse/NLPCRAFT-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-28. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed 1) All tests refactored as junit tests (Please check junit tests names) 2) New server REST URL added: localhost:8081/api/v1/health (Note, it is GET) 3) Tests on phase `test` are skipped (as before) 4) All tests executed on phase `verify` (mvn verify) as integration tests. Further, tests can be divided into two parts: simple and integration, they will be executed on different phases. Branch NLPCRAFT-28 > Suppot maven tests > -- > > Key: NLPCRAFT-28 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-28 > Project: NLPCraft > Issue Type: Test > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: High > Fix For: 0.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-28) Suppot maven tests
[ https://issues.apache.org/jira/browse/NLPCRAFT-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070283#comment-17070283 ] Sergey Kamov commented on NLPCRAFT-28: -- 5) Note that tests localed in main source folder (example tests) aren't performed via maven `verify` phase > Suppot maven tests > -- > > Key: NLPCRAFT-28 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-28 > Project: NLPCraft > Issue Type: Test > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: High > Fix For: 0.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-29) Refactor prepare.sh/pom.xml to have both "asf" and "binary" releaes.
[ https://issues.apache.org/jira/browse/NLPCRAFT-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070870#comment-17070870 ] Sergey Kamov commented on NLPCRAFT-29: -- Please check 1) Now 2 signed zips created See zips folder content: zips/apache-nlpcraft-bin-0.5.zip zips/apache-nlpcraft-bin-0.5.zip.md5 zips/apache-nlpcraft-bin-0.5.zip.sha1 zips/apache-nlpcraft-bin-0.5.zip.sha256 zips/apache-nlpcraft-bin-0.5.zip.sig zips/apache-nlpcraft-src-0.5.zip zips/apache-nlpcraft-src-0.5.zip.md5 zips/apache-nlpcraft-src-0.5.zip.sha1 zips/apache-nlpcraft-src-0.5.zip.sha256 zips/apache-nlpcraft-src-0.5.zip.sig 2) zips/apache-nlpcraft-bin-0.5.zip - as before Content: zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/bin/ zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/build/ zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/javadoc/ zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/openapi/ zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/sql/ zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/src/ zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/LICENSE zips/apache-nlpcraft-bin-0.5.zip/apache-nlpcraft/NOTICE 3) zips/apache-nlpcraft-src-0.5.zip Deleted: build, javadoc folders Added: pom.xml, assembly.xml, README.md files Content: zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/openapi/ zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/sql/ zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/src/ zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/NOTICE zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/README.md zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/assembly.xml zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/LICENSE zips/apache-nlpcraft-src-0.5.zip/apache-nlpcraft/pom.xml 4) >> remove '*.iml' files from the release - Do you have these files in prepared zip? I don't and can't find how it can be added to zip. > Refactor prepare.sh/pom.xml to have both "asf" and "binary" releaes. > > > Key: NLPCRAFT-29 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-29 > Project: NLPCraft > Issue Type: Task > Components: build >Reporter: Aaron Radzinski >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.5.0 > > > prepare.sh script should be refactored to create two "zip" folders: > * 'src' for standard ASF release (source code only release) > * 'bin' for additional non-ASF binary release (source code + built all-deps > JAR) > Current prepare.sh script builds 'bin' release. The following needs to change: > * remove '*.iml' files from the release > Source 'src' release ZIP should contain: > * pom.xml + all necessary files to build JARs > * NO built JAR files > * README files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-29) Refactor prepare.sh/pom.xml to have both "asf" and "binary" releaes.
[ https://issues.apache.org/jira/browse/NLPCRAFT-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-29: Assignee: Aaron Radzinski (was: Sergey Kamov) > Refactor prepare.sh/pom.xml to have both "asf" and "binary" releaes. > > > Key: NLPCRAFT-29 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-29 > Project: NLPCraft > Issue Type: Task > Components: build >Reporter: Aaron Radzinski >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.5.0 > > > prepare.sh script should be refactored to create two "zip" folders: > * 'src' for standard ASF release (source code only release) > * 'bin' for additional non-ASF binary release (source code + built all-deps > JAR) > Current prepare.sh script builds 'bin' release. The following needs to change: > * remove '*.iml' files from the release > Source 'src' release ZIP should contain: > * pom.xml + all necessary files to build JARs > * NO built JAR files > * README files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-30) Finish SQL example
Sergey Kamov created NLPCRAFT-30: Summary: Finish SQL example Key: NLPCRAFT-30 URL: https://issues.apache.org/jira/browse/NLPCRAFT-30 Project: NLPCraft Issue Type: New Feature Components: examples Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-30) Finish SQL example
[ https://issues.apache.org/jira/browse/NLPCRAFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072771#comment-17072771 ] Sergey Kamov commented on NLPCRAFT-30: -- SQL example code moved to NLPCRAFT-30 branch. > Finish SQL example > -- > > Key: NLPCRAFT-30 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-30 > Project: NLPCraft > Issue Type: New Feature > Components: examples >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-31) Tests should always stop all started components.
Sergey Kamov created NLPCRAFT-31: Summary: Tests should always stop all started components. Key: NLPCRAFT-31 URL: https://issues.apache.org/jira/browse/NLPCRAFT-31 Project: NLPCraft Issue Type: Improvement Components: test Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 Even if the test failed, it should always stop all started components. Otherwise, the next suite's tests failed when starting. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-31) Tests should always stop all started components.
[ https://issues.apache.org/jira/browse/NLPCRAFT-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-31. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed ready for review NLPCRAFT-31 > Tests should always stop all started components. > - > > Key: NLPCRAFT-31 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-31 > Project: NLPCraft > Issue Type: Improvement > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Even if the test failed, it should always stop all started components. > Otherwise, the next suite's tests failed when starting. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-35) Fix java tests.
Sergey Kamov created NLPCRAFT-35: Summary: Fix java tests. Key: NLPCRAFT-35 URL: https://issues.apache.org/jira/browse/NLPCRAFT-35 Project: NLPCraft Issue Type: Improvement Components: test Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 Convert them as scala tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-36) Support 2 different test folders (scala and java)
Sergey Kamov created NLPCRAFT-36: Summary: Support 2 different test folders (scala and java) Key: NLPCRAFT-36 URL: https://issues.apache.org/jira/browse/NLPCRAFT-36 Project: NLPCraft Issue Type: Improvement Components: test Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.6.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-35) Fix java tests.
[ https://issues.apache.org/jira/browse/NLPCRAFT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-35. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed fixed in NLPCRAFT-35 (`maven package` command tested under windows, passed) > Fix java tests. > > > Key: NLPCRAFT-35 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-35 > Project: NLPCraft > Issue Type: Improvement > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Convert them as scala tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-37) NCModel#onMatchedIntent behaviour
Sergey Kamov created NLPCRAFT-37: Summary: NCModel#onMatchedIntent behaviour Key: NLPCRAFT-37 URL: https://issues.apache.org/jira/browse/NLPCRAFT-37 Project: NLPCraft Issue Type: Improvement Components: probe Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.6.0 1) We can't use super.onMatchedIntent in implementations because NCModel is interface. Maybe better to have constant default values? 2) If onMatchedIntent returns false and single variant found, we have endless cycle. User can check it on probe side, but maybe safer to check it on server side and throw some error? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NLPCRAFT-37) NCModel#onMatchedIntent behaviour
[ https://issues.apache.org/jira/browse/NLPCRAFT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov updated NLPCRAFT-37: - Description: 1) We can't use super.onMatchedIntent in implementations because NCModel is the interface. Maybe better to have constant default values? 2) If onMatchedIntent returns false and single variant found, we have an endless cycle. Users can check it on the probe side, but maybe safer to check it on the server-side and throw some error? 3) onMatchedIntent should return boolean and sometimes throw an exception. Maybe better to return some enumeration values? (Note that some `on` methods can throw rejection exception, but some can't. ) was: 1) We can't use super.onMatchedIntent in implementations because NCModel is interface. Maybe better to have constant default values? 2) If onMatchedIntent returns false and single variant found, we have endless cycle. User can check it on probe side, but maybe safer to check it on server side and throw some error? > NCModel#onMatchedIntent behaviour > - > > Key: NLPCRAFT-37 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-37 > Project: NLPCraft > Issue Type: Improvement > Components: probe >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > 1) We can't use super.onMatchedIntent in implementations because NCModel is > the interface. > Maybe better to have constant default values? > 2) If onMatchedIntent returns false and single variant found, we have an > endless cycle. > Users can check it on the probe side, but maybe safer to check it on the > server-side and throw some error? > 3) onMatchedIntent should return boolean and sometimes throw an exception. > Maybe better to return some enumeration values? (Note that some `on` methods > can throw rejection exception, but some can't. ) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-41) Synonyms generation tool
Sergey Kamov created NLPCRAFT-41: Summary: Synonyms generation tool Key: NLPCRAFT-41 URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 Project: NLPCraft Issue Type: New Feature Components: probe Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-42) Moder examples validation.
Sergey Kamov created NLPCRAFT-42: Summary: Moder examples validation. Key: NLPCRAFT-42 URL: https://issues.apache.org/jira/browse/NLPCRAFT-42 Project: NLPCraft Issue Type: New Feature Components: examples Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.6.0 All sentences should be valid and should be automatically processed by model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-43) SQL example developer test
Sergey Kamov created NLPCRAFT-43: Summary: SQL example developer test Key: NLPCRAFT-43 URL: https://issues.apache.org/jira/browse/NLPCRAFT-43 Project: NLPCraft Issue Type: New Feature Components: test Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 We should add a test based on NCEnricherBaseSpec (like NCEnricherLimitSpec) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-44) POM update
Sergey Kamov created NLPCRAFT-44: Summary: POM update Key: NLPCRAFT-44 URL: https://issues.apache.org/jira/browse/NLPCRAFT-44 Project: NLPCraft Issue Type: Improvement Components: build Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 Fixes maven release related issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-44) POM update
[ https://issues.apache.org/jira/browse/NLPCRAFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-44. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed ready for review NLPCRAFT-44 > POM update > -- > > Key: NLPCRAFT-44 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-44 > Project: NLPCraft > Issue Type: Improvement > Components: build >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Fixes maven release related issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-45) Site example error.
Sergey Kamov created NLPCRAFT-45:
Summary: Site example error.
Key: NLPCRAFT-45
URL: https://issues.apache.org/jira/browse/NLPCRAFT-45
Project: NLPCraft
Issue Type: Bug
Components: examples, website
Reporter: Sergey Kamov
Assignee: Aaron Radzinski
Fix For: 0.6.0
[https://nlpcraft.apache.org/examples/alarm_clock.html]
Example body:
{{ctx.getQueryContext().getRequest().getNormalizedText() ..}}
{{getQueryContext}} is obsolete method name,
Please find and fix all related places
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (NLPCRAFT-46) Release instructions
Sergey Kamov created NLPCRAFT-46: Summary: Release instructions Key: NLPCRAFT-46 URL: https://issues.apache.org/jira/browse/NLPCRAFT-46 Project: NLPCraft Issue Type: Bug Components: docs Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 Prepare release instructions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-47) Elements matching priorities.
Sergey Kamov created NLPCRAFT-47: Summary: Elements matching priorities. Key: NLPCRAFT-47 URL: https://issues.apache.org/jira/browse/NLPCRAFT-47 Project: NLPCraft Issue Type: Improvement Components: probe Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.6.0 1) sort, limit, relation - should have lower priority comparing to user elements for example: "orders" as user element and as nlpcraft:sort -> user element should win 2) user element priorities - can we add such possibility? Example: - user define 2 elements - both of the catch synonym X - element 1 and element 2 are equal for system. Can we allow to define higher priority for element 1? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (NLPCRAFT-37) NCModel#onMatchedIntent behaviour
[ https://issues.apache.org/jira/browse/NLPCRAFT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov closed NLPCRAFT-37. Resolution: Fixed > NCModel#onMatchedIntent behaviour > - > > Key: NLPCRAFT-37 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-37 > Project: NLPCraft > Issue Type: Improvement > Components: probe >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > 1) We can't use super.onMatchedIntent in implementations because NCModel is > the interface. > Maybe better to have constant default values? > 2) If onMatchedIntent returns false and single variant found, we have an > endless cycle. > Users can check it on the probe side, but maybe safer to check it on the > server-side and throw some error? > 3) onMatchedIntent should return boolean and sometimes throw an exception. > Maybe better to return some enumeration values? (Note that some `on` methods > can throw rejection exception, but some can't. ) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-43) SQL example developer test
[ https://issues.apache.org/jira/browse/NLPCRAFT-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-43. -- Resolution: Implemented ready for review in NLPCRAFT-30 org.apache.nlpcraft.examples.sql.NCSqlModelSpec > SQL example developer test > -- > > Key: NLPCRAFT-43 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-43 > Project: NLPCraft > Issue Type: New Feature > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > We should add a test based on NCEnricherBaseSpec (like NCEnricherLimitSpec) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-30) Finish SQL example
[ https://issues.apache.org/jira/browse/NLPCRAFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-30. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Implemented ready for review in NLPCRAFT-30 # Note please - there are some new TODO (mostly javadoc should be added) # Implementation is ready in general. But I want to have feedback from other developers - which sentences do we want to support in our SQL example? See please org.apache.nlpcraft.examples.sql.NCSqlModelSpec and org.apache.nlpcraft.examples.sql.SqlModelTest # Also, try this model as usual during development - start org.apache.nlpcraft.server.NCServer - start org.apache.nlpcraft.examples.sql.db.SqlServerRunner - start org.apache.nlpcraft.probe.NCProbe with given model org.apache.nlpcraft.examples.sql.SqlModel > Finish SQL example > -- > > Key: NLPCRAFT-30 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-30 > Project: NLPCraft > Issue Type: New Feature > Components: examples >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-43) SQL example developer test
[ https://issues.apache.org/jira/browse/NLPCRAFT-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-43: Assignee: Aaron Radzinski (was: Sergey Kamov) > SQL example developer test > -- > > Key: NLPCRAFT-43 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-43 > Project: NLPCraft > Issue Type: New Feature > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > We should add a test based on NCEnricherBaseSpec (like NCEnricherLimitSpec) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-46) Release instructions
[ https://issues.apache.org/jira/browse/NLPCRAFT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-46. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed Ready for review in branch NLPCRAFT-46 Please look at bin/MAVEN-RELEASE.md - you can add content related to Apache release configuration and process issues. > Release instructions > > > Key: NLPCRAFT-46 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-46 > Project: NLPCraft > Issue Type: Bug > Components: docs >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Prepare release instructions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-48) Add java client project to Jenkins and update README badges.
[ https://issues.apache.org/jira/browse/NLPCRAFT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106327#comment-17106327 ] Sergey Kamov commented on NLPCRAFT-48: -- Look at main project pom.xml com.bazaarvoice.maven.plugin (for start the server on pre-integration phase) > Add java client project to Jenkins and update README badges. > > > Key: NLPCRAFT-48 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-48 > Project: NLPCraft > Issue Type: Task > Components: build, java-client >Reporter: Aaron Radzinski >Assignee: Sergey Makov >Priority: Major > Fix For: 0.6.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-46) Release instructions
[
https://issues.apache.org/jira/browse/NLPCRAFT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106573#comment-17106573
]
Sergey Kamov commented on NLPCRAFT-46:
--
# Should I copy file into the project "java client project" (same file required)
# Revert please
\{YOUR_APACHE_PASSWORD_CODE}{} - are important
> Release instructions
>
>
> Key: NLPCRAFT-46
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-46
> Project: NLPCraft
> Issue Type: Bug
> Components: docs
>Reporter: Sergey Kamov
>Assignee: Sergey Kamov
>Priority: Major
> Fix For: 0.6.0
>
>
> Prepare release instructions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-46) Release instructions
[ https://issues.apache.org/jira/browse/NLPCRAFT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-46: Assignee: Aaron Radzinski (was: Sergey Kamov) > Release instructions > > > Key: NLPCRAFT-46 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-46 > Project: NLPCraft > Issue Type: Bug > Components: docs >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Prepare release instructions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-46) Release instructions
[ https://issues.apache.org/jira/browse/NLPCRAFT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107027#comment-17107027 ] Sergey Kamov commented on NLPCRAFT-46: -- Comments added, File copied to the 'java client' project > Release instructions > > > Key: NLPCRAFT-46 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-46 > Project: NLPCraft > Issue Type: Bug > Components: docs >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Prepare release instructions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-46) Release instructions
[ https://issues.apache.org/jira/browse/NLPCRAFT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-46: Assignee: Aaron Radzinski (was: Sergey Kamov) > Release instructions > > > Key: NLPCRAFT-46 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-46 > Project: NLPCraft > Issue Type: Bug > Components: docs >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Prepare release instructions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NLPCRAFT-49) Probe hangs on stop
[
https://issues.apache.org/jira/browse/NLPCRAFT-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Kamov updated NLPCRAFT-49:
-
Fix Version/s: 0.6.0
> Probe hangs on stop
> ---
>
> Key: NLPCRAFT-49
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-49
> Project: NLPCraft
> Issue Type: Bug
> Components: probe
>Reporter: Sergey Makov
>Assignee: Aaron Radzinski
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.6.0
>
>
> While setting up Github Actions I noticed that build frequently hangs on
> Linux+JDK 11.
> Here are the last lines of build output:
> {code}
> 2020-05-14T15:14:35.5993184Z May-14 15:14:35 [INFO ] Dialog flow manager GC
> stopped
> 2020-05-14T15:14:35.5994606Z May-14 15:14:35 [INFO ] NCDialogFlowManager
> stopped.
> {code}
> Looks like there is some issue with threads/sockets termination in
> {{NCCommandManager}} as it stops next after {{NCDialogFlowManager}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (NLPCRAFT-46) Release instructions
[ https://issues.apache.org/jira/browse/NLPCRAFT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov closed NLPCRAFT-46. > Release instructions > > > Key: NLPCRAFT-46 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-46 > Project: NLPCraft > Issue Type: Bug > Components: docs >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Prepare release instructions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-50) Function enricher
Sergey Kamov created NLPCRAFT-50:
Summary: Function enricher
Key: NLPCRAFT-50
URL: https://issues.apache.org/jira/browse/NLPCRAFT-50
Project: NLPCraft
Issue Type: Improvement
Components: probe
Reporter: Sergey Kamov
Assignee: Aaron Radzinski
Fix For: 0.6.0
The base idea of function enricher is search of the maximum count of various
functions, with references to other elements.
For example:
Some model has user element 'x:temp' with synonym 'temperature'
So, for the sentence 'show me average temperature', token 'average' should
be detected as element 'nlpcraft:function' with type 'avg' and relation
to 'x:temp' element.
1. In general, functions can be
- without argument
- with one argument
- with many arguments
2. Functions with arguments should have references to some other elements
It can be a user element or some predefined elements like 'nlp:geo' etc.
Look at supported elements in the documentation.
(I suggest to define a table, which describes, which functions can be
related with which elements)
3. How to detect
Example:
- average temperature - ok (element 'x:temp' is after word 'average')
- temperature average - skipped(such functions cannot be after their
references)
- average - skipped (it doesn't have sense without any references)
- average temperature - skipped (references should
be after word without such gaps)
- average the temperature - ok (gaps which contain only stopwords are
possible)
4. This enricher should create a token with
- name 'nlpcraft:function',
- mandatory String property 'type' (function name),
- optional java.util.List property 'indexes', which
- omitted for function without arguments
- has one length list of indexes for function with one argument
("indexes" field name is hardcoded for internal enrichers and used in
some related components)
Maybe some additional optional parameters can be passed.
5. Supported functions kinds can be
- main math
- sql
- etc
(We can start from math and sql functions, and extend supported kinds
on next steps)
6. Look at Limit, Relation and Sort enrichers as examples,
- they have such references to other elements via 'indexes' fields.
- also, note please that this enricher also should be called in the loop
(as mentioned above) because can have references to nested elements.
- look also please, how stop-words processed in these enrichers.
(if functions with multiple word-names exist, stopwords are suitable
inside these names, like 'X the Y' is ok as 'X Y' , where 'X Y' is
multiple words valid function name)
7. Functions names and all their synonyms (I guess mostly it can be
shortcuts) can be hardcoded.
Look at
org.apache.nlpcraft.server.nlp.enrichers.coordinate.NCCoordinatesEnricher
as example for numeric measures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (NLPCRAFT-43) SQL example developer test
[ https://issues.apache.org/jira/browse/NLPCRAFT-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov closed NLPCRAFT-43. > SQL example developer test > -- > > Key: NLPCRAFT-43 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-43 > Project: NLPCraft > Issue Type: New Feature > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > We should add a test based on NCEnricherBaseSpec (like NCEnricherLimitSpec) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (NLPCRAFT-30) Finish SQL example
[ https://issues.apache.org/jira/browse/NLPCRAFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov closed NLPCRAFT-30. > Finish SQL example > -- > > Key: NLPCRAFT-30 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-30 > Project: NLPCraft > Issue Type: New Feature > Components: examples >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-62) Tests failed
Sergey Kamov created NLPCRAFT-62: Summary: Tests failed Key: NLPCRAFT-62 URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 Project: NLPCraft Issue Type: Bug Components: test Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.6.0 Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117001#comment-17117001 ] Sergey Kamov commented on NLPCRAFT-62: -- mvn verify under win doesn't work (SQL example) > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-62: Assignee: Sergey Kamov (was: Aaron Radzinski) > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-62: Assignee: Aaron Radzinski (was: Sergey Kamov) > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-62: Assignee: Sergey Kamov (was: Aaron Radzinski) > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117528#comment-17117528 ] Sergey Kamov commented on NLPCRAFT-62: -- - fixed and ready for review in the branch NLPCRAFT-62 - `mvn verify` works fine in the branch NLPCRAFT-62 under win (java8) > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-62. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-63) Integration tests under windows
Sergey Kamov created NLPCRAFT-63: Summary: Integration tests under windows Key: NLPCRAFT-63 URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 Project: NLPCraft Issue Type: Bug Components: test Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.6.0 Tests passed under IDE, but still don't work from maven CLI INFO] [INFO] Results: [INFO] [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 05:06 min [INFO] Finished at: 2020-05-27T11:48:43+03:00 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (integration-tests) on project nlpcraft: There are test failures. [ERROR] [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was cmd.exe /X /C ""C:\Program Files\Java\jdk1.8.0_172\jre\bin\java" -jar C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp surefire_08854107770478331433tmp" [ERROR] Process Exit Code: 0 [ERROR] Crashed tests: [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was cmd.exe /X /C ""C:\Program Files\Java\jdk1.8.0_172\jre\bin\java" -jar C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp surefire_08854107770478331433tmp" [ERROR] Process Exit Code: 0 [ERROR] Crashed tests: [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) [ERROR] at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) [ERROR] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [ERROR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [ERROR] at java.lang.reflect.Method.invoke(Method.java:498) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) [ERROR] at or
[jira] [Commented] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117541#comment-17117541 ] Sergey Kamov commented on NLPCRAFT-62: -- Additional related ticket created NLPCRAFT-63 > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117603#comment-17117603 ] Sergey Kamov commented on NLPCRAFT-63: -- command 'mvn clean verify > log.txt' - 4 times passed ok command 'mvn clean verify' - 4 times failed with the same error. Don't know the reason > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) > [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Nat
[jira] [Created] (NLPCRAFT-64) Examples model tests
Sergey Kamov created NLPCRAFT-64: Summary: Examples model tests Key: NLPCRAFT-64 URL: https://issues.apache.org/jira/browse/NLPCRAFT-64 Project: NLPCraft Issue Type: Bug Components: test Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.7.0 Examples model tests located in src folder (not tests), so they aren't started with `mvn verify`. Better to fix it somehow and force them to be started with maven. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117603#comment-17117603 ] Sergey Kamov edited comment on NLPCRAFT-63 at 5/27/20, 10:48 AM: - - from cmd - command 'mvn clean verify > log.txt' - 4 times passed ok - from IDEA terminal - command 'mvn clean verify > log.txt' - 4 times passed ok - from cmd - command 'mvn clean verify' - 4 times failed with the same error. Seems it has some problems with CMD console. Can someone reproduce it? was (Author: sergeykamov): command 'mvn clean verify > log.txt' - 4 times passed ok command 'mvn clean verify' - 4 times failed with the same error. Don't know the reason > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.
[jira] [Commented] (NLPCRAFT-59) Remove old dockerhub account/location for NLPCraft.
[ https://issues.apache.org/jira/browse/NLPCRAFT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117830#comment-17117830 ] Sergey Kamov commented on NLPCRAFT-59: -- `nlpcraftserver` tags deleted account `nlpcraftserver` deactivated. Waht about incubator-nlpcraft/docker files? > Remove old dockerhub account/location for NLPCraft. > --- > > Key: NLPCRAFT-59 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-59 > Project: NLPCraft > Issue Type: Task > Components: build >Reporter: Aaron Radzinski >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-59) Remove old dockerhub account/location for NLPCraft.
[ https://issues.apache.org/jira/browse/NLPCRAFT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-59: Assignee: Aaron Radzinski (was: Sergey Kamov) > Remove old dockerhub account/location for NLPCraft. > --- > > Key: NLPCRAFT-59 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-59 > Project: NLPCraft > Issue Type: Task > Components: build >Reporter: Aaron Radzinski >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-8) Develop full SQL example.
[ https://issues.apache.org/jira/browse/NLPCRAFT-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-8: --- Assignee: Aaron Radzinski (was: Sergey Kamov) > Develop full SQL example. > - > > Key: NLPCRAFT-8 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-8 > Project: NLPCraft > Issue Type: Task > Components: examples >Reporter: Aaron Radzinski >Assignee: Aaron Radzinski >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-8) Develop full SQL example.
[ https://issues.apache.org/jira/browse/NLPCRAFT-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117832#comment-17117832 ] Sergey Kamov commented on NLPCRAFT-8: - can be closed? > Develop full SQL example. > - > > Key: NLPCRAFT-8 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-8 > Project: NLPCraft > Issue Type: Task > Components: examples >Reporter: Aaron Radzinski >Assignee: Sergey Kamov >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-12) Introduce 'not' function.
[
https://issues.apache.org/jira/browse/NLPCRAFT-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117835#comment-17117835
]
Sergey Kamov commented on NLPCRAFT-12:
--
I guess it can be closed because NLPCRAFT-50 created (Maybe better to mention
"not" function in NLPCRAFT-50)
> Introduce 'not' function.
> -
>
> Key: NLPCRAFT-12
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-12
> Project: NLPCraft
> Issue Type: New Feature
> Components: server
>Reporter: Aaron Radzinski
>Assignee: Sergey Kamov
>Priority: Major
>
> {color:#24292e}We have to extend function enricher and add "not" type (it
> should have indexes to the main element){color}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-12) Introduce 'not' function.
[
https://issues.apache.org/jira/browse/NLPCRAFT-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Kamov reassigned NLPCRAFT-12:
Assignee: Aaron Radzinski (was: Sergey Kamov)
> Introduce 'not' function.
> -
>
> Key: NLPCRAFT-12
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-12
> Project: NLPCraft
> Issue Type: New Feature
> Components: server
>Reporter: Aaron Radzinski
>Assignee: Aaron Radzinski
>Priority: Major
>
> {color:#24292e}We have to extend function enricher and add "not" type (it
> should have indexes to the main element){color}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NLPCRAFT-41) Synonyms generation tool
[ https://issues.apache.org/jira/browse/NLPCRAFT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov updated NLPCRAFT-41: - Fix Version/s: (was: 0.6.0) 0.7.0 > Synonyms generation tool > > > Key: NLPCRAFT-41 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 > Project: NLPCraft > Issue Type: New Feature > Components: probe >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (NLPCRAFT-41) Synonyms generation tool
[ https://issues.apache.org/jira/browse/NLPCRAFT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reopened NLPCRAFT-41: -- Assignee: Aaron Radzinski (was: Sergey Kamov) Why was it closed? Generator is still in progress. > Synonyms generation tool > > > Key: NLPCRAFT-41 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 > Project: NLPCraft > Issue Type: New Feature > Components: probe >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118534#comment-17118534 ] Sergey Kamov commented on NLPCRAFT-63: -- Can be resolved for my laptop if src/test/resources/log4j2.xml level for org.apache.nlpcraft changed from TRACE to DEBUG Will we do it? > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) > [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[jira] [Assigned] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-63: Assignee: Aaron Radzinski (was: Sergey Kamov) > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) > [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > [ERROR] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > [ERROR] at > sun.reflect.DelegatingMeth
[jira] [Assigned] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-63: Assignee: Aaron Radzinski (was: Sergey Kamov) > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) > [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > [ERROR] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > [ERROR] at > sun.reflect.DelegatingMeth
[jira] [Commented] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118847#comment-17118847 ] Sergey Kamov commented on NLPCRAFT-63: -- I guess it can be because the server produces too many trace logs. The server started as the separated process on preintegration phase, with such huge logs it can be incorrectly processed by maven plugins under some environments (win) it is only suspicion. > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.a
[jira] [Resolved] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov resolved NLPCRAFT-63. -- Assignee: Aaron Radzinski (was: Sergey Kamov) Resolution: Fixed > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) > [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > [ERROR] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > [ERROR] at > sun.ref
[jira] [Commented] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118936#comment-17118936 ] Sergey Kamov commented on NLPCRAFT-63: -- fixed in master > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.6.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) > [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > [ERROR] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > [ERROR] at > sun.reflect.D
[jira] [Closed] (NLPCRAFT-62) Tests failed
[ https://issues.apache.org/jira/browse/NLPCRAFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov closed NLPCRAFT-62. > Tests failed > > > Key: NLPCRAFT-62 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-62 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.7.0 > > > Run `mvn clean verify` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-41) Synonyms generation tool
[ https://issues.apache.org/jira/browse/NLPCRAFT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119418#comment-17119418 ] Sergey Kamov commented on NLPCRAFT-41: -- Could you create new PR (instead of current) based on our infrastructure (or repository)? So we can accept it and continue. Additionally, with this PR please move everything from incubator-nlpcraft/enricher/ to incubator-nlpcraft/src/main/python/ - please name it rightly (it is not enricher as now, it is not bert, I don't have ideas about the right name, I'll suggest later if I can find) > Synonyms generation tool > > > Key: NLPCRAFT-41 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 > Project: NLPCraft > Issue Type: New Feature > Components: probe >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-41) Synonyms generation tool
[ https://issues.apache.org/jira/browse/NLPCRAFT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-41: Assignee: (was: Aaron Radzinski) > Synonyms generation tool > > > Key: NLPCRAFT-41 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 > Project: NLPCraft > Issue Type: New Feature > Components: probe >Reporter: Sergey Kamov >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-41) Synonyms generation tool
[ https://issues.apache.org/jira/browse/NLPCRAFT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-41: Assignee: Sergey Kamov > Synonyms generation tool > > > Key: NLPCRAFT-41 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 > Project: NLPCraft > Issue Type: New Feature > Components: probe >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-41) Synonyms generation tool
[ https://issues.apache.org/jira/browse/NLPCRAFT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-41: Assignee: (was: Sergey Kamov) > Synonyms generation tool > > > Key: NLPCRAFT-41 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 > Project: NLPCraft > Issue Type: New Feature > Components: probe >Reporter: Sergey Kamov >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NLPCRAFT-41) Synonyms generation tool
[ https://issues.apache.org/jira/browse/NLPCRAFT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov reassigned NLPCRAFT-41: Assignee: Gleb > Synonyms generation tool > > > Key: NLPCRAFT-41 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-41 > Project: NLPCraft > Issue Type: New Feature > Components: probe >Reporter: Sergey Kamov >Assignee: Gleb >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (NLPCRAFT-63) Integration tests under windows
[ https://issues.apache.org/jira/browse/NLPCRAFT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov closed NLPCRAFT-63. > Integration tests under windows > --- > > Key: NLPCRAFT-63 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-63 > Project: NLPCraft > Issue Type: Bug > Components: test >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.7.0 > > > Tests passed under IDE, but still don't work from maven CLI > > INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:06 min > [INFO] Finished at: 2020-05-27T11:48:43+03:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test > (integration-tests) on project nlpcraft: There are test failures. > [ERROR] > [ERROR] Please refer to c:\apache\incubator-nlpcraft\target\surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The > forked VM terminated without properly saying goodbye. VM crash or System.exit > called? > [ERROR] Command was cmd.exe /X /C ""C:\Program > Files\Java\jdk1.8.0_172\jre\bin\java" -jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833\surefirebooter70663853347083315.jar > C:\Users\kamov\AppData\Local\Temp\surefire2860438661498158833 > 2020-05-27T11-44-46_908-jvmRun1 surefire3574068465121536914tmp > surefire_08854107770478331433tmp" > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) > [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) > [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > [ERROR] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > [ERROR] at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > [
[jira] [Commented] (NLPCRAFT-67) Python machine learning module
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov commented on NLPCRAFT-67:
--
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{{{}}
{{ "sentence": "sentence", }}
{{ "simple:" true, }}
{{ "lower": 1, }}
{{ "upper": 1, }}
{{ "limit": 1}}
{{ }}}
Batch request can be
{{{}}
{{ "sentence": "sentence", }}
{{ "simple": true, }}
{{ "lower": 1, }}
{{ "indexes": [}}
{{ {}}
{{ "upper": 1, }}
{{ "limit": 1}}
{{ },}}
{{ {}}
{{ "upper": 2, }}
{{ "limit": 2}}
{{ }}}
{{ ]}}
{{ }}}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
> Python machine learning module
> ---
>
> Key: NLPCRAFT-67
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-67
> Project: NLPCraft
> Issue Type: New Feature
>Reporter: Gleb
>Assignee: Gleb
>Priority: Major
> Fix For: 0.7.0
>
>
> Python part which consists of Bert masked word prediction and FastText
> synonyms filter
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (NLPCRAFT-67) Python machine learning module
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:36 AM:
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{
"sentence": "sentence",
"simple:" true,
"lower": 1,
"upper": 1,
"limit": 1
}
Batch request can be
{
"sentence": "sentence",
"simple": true,
"lower": 1,
"indexes": [
{
"upper": 1,
"limit": 1
},
{
"upper": 2,
"limit": 2
}
]
}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
was (Author: sergeykamov):
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{{{}}
{{ "sentence": "sentence", }}
{{ "simple:" true, }}
{{ "lower": 1, }}
{{ "upper": 1, }}
{{ "limit": 1}}
{{ }}}
Batch request can be
{{{}}
{{ "sentence": "sentence", }}
{{ "simple": true, }}
{{ "lower": 1, }}
{{ "indexes": [}}
{{ {}}
{{ "upper": 1, }}
{{ "limit": 1}}
{{ },}}
{{ {}}
{{ "upper": 2, }}
{{ "limit": 2}}
{{ }}}
{{ ]}}
{{ }}}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
> Python machine learning module
> ---
>
> Key: NLPCRAFT-67
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-67
> Project: NLPCraft
> Issue Type: New Feature
>Reporter: Gleb
>Assignee: Gleb
>Priority: Major
> Fix For: 0.7.0
>
>
> Python part which consists of Bert masked word prediction and FastText
> synonyms filter
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (NLPCRAFT-67) Python machine learning module
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:37 AM:
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{{ {
"sentence": "sentence",
"simple:" true,
"lower": 1,
"upper": 1,
"limit": 1
}}}
Batch request can be
{{{
"sentence": "sentence",
"simple": true,
"lower": 1,
"indexes": [
{
"upper": 1,
"limit": 1
},
{
"upper": 2,
"limit": 2
}
]
}}}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
was (Author: sergeykamov):
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{
"sentence": "sentence",
"simple:" true,
"lower": 1,
"upper": 1,
"limit": 1
}
Batch request can be
{
"sentence": "sentence",
"simple": true,
"lower": 1,
"indexes": [
{
"upper": 1,
"limit": 1
},
{
"upper": 2,
"limit": 2
}
]
}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
> Python machine learning module
> ---
>
> Key: NLPCRAFT-67
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-67
> Project: NLPCraft
> Issue Type: New Feature
>Reporter: Gleb
>Assignee: Gleb
>Priority: Major
> Fix For: 0.7.0
>
>
> Python part which consists of Bert masked word prediction and FastText
> synonyms filter
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (NLPCRAFT-67) Python machine learning module
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:38 AM:
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{quote}{
"sentence": "sentence",
"simple:" true,
"lower": 1,
"upper": 1,
"limit": 1
}{quote}
Batch request can be
{quote}
{
"sentence": "sentence",
"simple": true,
"lower": 1,
"indexes": [
{
"upper": 1,
"limit": 1
},
{
"upper": 2,
"limit": 2
}
]
}{quote}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
was (Author: sergeykamov):
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{{ {
"sentence": "sentence",
"simple:" true,
"lower": 1,
"upper": 1,
"limit": 1
}}}
Batch request can be
{{{
"sentence": "sentence",
"simple": true,
"lower": 1,
"indexes": [
{
"upper": 1,
"limit": 1
},
{
"upper": 2,
"limit": 2
}
]
}}}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
> Python machine learning module
> ---
>
> Key: NLPCRAFT-67
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-67
> Project: NLPCraft
> Issue Type: New Feature
>Reporter: Gleb
>Assignee: Gleb
>Priority: Major
> Fix For: 0.7.0
>
>
> Python part which consists of Bert masked word prediction and FastText
> synonyms filter
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (NLPCRAFT-67) Python machine learning module
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:49 AM:
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
Request (sentence: String, simple: Boolean, lower: Int, upper: Int, limit: Int)
Batch request can be
Request (sentence: String, simple: Boolean, limit: Int, indexes: List[Index]),
where Index is (lower: Int, upper: Int)
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
was (Author: sergeykamov):
Hi, I guess we need
1. Move sources under src/main/python with name mlserver ? (or something like
this)
2. Rename endpoint `synonyms` to `suggestions` (maybe another, but not
`synonyms`, it can confuse)
3. We already have `limit` request parameter
I guess we have to add `score` request parameter (it means minimal score for
response data)
Both optional. Both can be used together.
By default score can be 0, limit - 100 (?)
4. Let's investigate performance issue (batch mode, GPU mode etc)
If performance improvement doable, let's define a new endpoint for batch mode?
Current request is
{quote}{
"sentence": "sentence",
"simple:" true,
"lower": 1,
"upper": 1,
"limit": 1
}{quote}
Batch request can be
{quote}
{
"sentence": "sentence",
"simple": true,
"lower": 1,
"indexes": [
{
"upper": 1,
"limit": 1
},
{
"upper": 2,
"limit": 2
}
]
}{quote}
Maybe the second format is enough and we don't need both.
The problems is that we need performance possibility understanding because its
restriction can influence on dynamic enricher design,
So we don't need performance ASAP, but need API and understanding - can we
achieve reasonable performance or not.
5. Will we support multiple word synonyms processings?
We have the following possibilities
- drop it. - if yes - let's change API. Instead of pair `lower` and `upper` we
need one `index`
- we can improve support it it is possible in the foreseeable future - so we
keep current API
- we can keep current API but postpone multiple word processings
investigations. We can do so, but if we really hope to reopen to it. Otherwise
- lets' don't keep garbage.
> Python machine learning module
> ---
>
> Key: NLPCRAFT-67
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-67
> Project: NLPCraft
> Issue Type: New Feature
>Reporter: Gleb
>Assignee: Gleb
>Priority: Major
> Fix For: 0.7.0
>
>
> Python part which consists of Bert masked word prediction and FastText
> synonyms filter
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NLPCRAFT-42) Model examples validation.
[ https://issues.apache.org/jira/browse/NLPCRAFT-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov updated NLPCRAFT-42: - Summary: Model examples validation. (was: Moder examples validation.) > Model examples validation. > -- > > Key: NLPCRAFT-42 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-42 > Project: NLPCraft > Issue Type: New Feature > Components: examples >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Normal > Fix For: 0.7.0 > > > All sentences should be valid and should be automatically processed by model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-70) ML server enricher
Sergey Kamov created NLPCRAFT-70: Summary: ML server enricher Key: NLPCRAFT-70 URL: https://issues.apache.org/jira/browse/NLPCRAFT-70 Project: NLPCraft Issue Type: Task Components: server Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.7.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-67) Python machine learning module
[ https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120857#comment-17120857 ] Sergey Kamov commented on NLPCRAFT-67: -- 6. Please add `health` endpoint, which can be used for check that server is started. > Python machine learning module > --- > > Key: NLPCRAFT-67 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-67 > Project: NLPCraft > Issue Type: New Feature >Reporter: Gleb >Assignee: Gleb >Priority: Major > Fix For: 0.7.0 > > > Python part which consists of Bert masked word prediction and FastText > synonyms filter -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-71) Add 'health' endpoint to spacy_proxy server
Sergey Kamov created NLPCRAFT-71: Summary: Add 'health' endpoint to spacy_proxy server Key: NLPCRAFT-71 URL: https://issues.apache.org/jira/browse/NLPCRAFT-71 Project: NLPCraft Issue Type: Task Components: server Reporter: Sergey Kamov Assignee: Sergey Kamov Fix For: 0.7.0 Fix related code in org.apache.nlpcraft.server.nlp.core.spacy.NCSpaCyNerEnricher#start method. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-72) POM fixes.
Sergey Kamov created NLPCRAFT-72: Summary: POM fixes. Key: NLPCRAFT-72 URL: https://issues.apache.org/jira/browse/NLPCRAFT-72 Project: NLPCraft Issue Type: Improvement Components: build Reporter: Sergey Kamov Assignee: Sergey Makov Fix For: 0.7.0, 0.6.0 We have to fix Stanford library usage in pom.xml. We have to do these dependencies optional. ( Now it excluded only on the `release` phase.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NLPCRAFT-12) Introduce 'not' function.
[
https://issues.apache.org/jira/browse/NLPCRAFT-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Kamov updated NLPCRAFT-12:
-
Fix Version/s: 0.7.0
> Introduce 'not' function.
> -
>
> Key: NLPCRAFT-12
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-12
> Project: NLPCraft
> Issue Type: New Feature
> Components: server
>Reporter: Aaron Radzinski
>Assignee: Aaron Radzinski
>Priority: Major
> Fix For: 0.7.0
>
>
> {color:#24292e}We have to extend function enricher and add "not" type (it
> should have indexes to the main element){color}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (NLPCRAFT-74) Weather example
Sergey Kamov created NLPCRAFT-74: Summary: Weather example Key: NLPCRAFT-74 URL: https://issues.apache.org/jira/browse/NLPCRAFT-74 Project: NLPCraft Issue Type: Improvement Components: test Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.7.0 Sometimes weather free external service doesn't work well. We have to exclude weather tests from the suite or improve them (they shouldn't failed if external weather service errors) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-75) Fix warings
Sergey Kamov created NLPCRAFT-75: Summary: Fix warings Key: NLPCRAFT-75 URL: https://issues.apache.org/jira/browse/NLPCRAFT-75 Project: NLPCraft Issue Type: Improvement Components: test Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.7.0 When the first request to the server from the new connected probe, we have some warning (see below) Seems they are related to ignite cache usage with scala classes. Should be fixed. [INFO] Jun-09|14:21:36|WARN | Class "scala.collection.immutable.HashSet$SerializationProxy" cannot be serialized using BinaryMarshaller because it either implements Externalizable interface or have writeObject/readObject methods. OptimizedMarshaller will be used instead and class instances will be deserialized on the server. Please ensure that all nodes have this class in classpath. To enable binary serialization either implement Binarylizable interface or set explicit serializer using BinaryTypeConfiguration.setSerializer() method. [INFO] Jun-09|14:21:36|WARN | Class "scala.collection.immutable.HashSet$SerializationProxy" cannot be serialized using BinaryMarshaller because it either implements Externalizable interface or have writeObject/readObject methods. OptimizedMarshaller will be used instead and class instances will be deserialized on the server. Please ensure that all nodes have this class in classpath. To enable binary serialization either implement Binarylizable interface or set explicit serializer using BinaryTypeConfiguration.setSerializer() method. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-77) Ignite cache should be cleared before suite started
Sergey Kamov created NLPCRAFT-77: Summary: Ignite cache should be cleared before suite started Key: NLPCRAFT-77 URL: https://issues.apache.org/jira/browse/NLPCRAFT-77 Project: NLPCraft Issue Type: Improvement Components: test Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.7.0 On integration tests phase we have to clear ignite cache files. (We can use some flag for servewr start or something like this) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NLPCRAFT-67) Python machine learning module
[ https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130657#comment-17130657 ] Sergey Kamov commented on NLPCRAFT-67: -- Thank you. I have tried to use it for static suggestions generation. It works fine (branch 41) Some questions: - you wrote that you did 3) - but I can't find `score` parameter in your API description (`limit` parameter exists, but not `score`) - the response contains 4 fields, one is string field (position 2) - it is suggested word, but can you describe remained 3 double values (field 0, 1, 3) BTW: maybe better shift response fields? for example [string, double1, double2, double3] instead of [double1, double2, string, double3] ? > Python machine learning module > --- > > Key: NLPCRAFT-67 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-67 > Project: NLPCraft > Issue Type: New Feature >Reporter: Gleb >Assignee: Gleb >Priority: Major > Fix For: 0.7.0 > > > Python part which consists of Bert masked word prediction and FastText > synonyms filter -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NLPCRAFT-70) ContextWord server side enricher
[ https://issues.apache.org/jira/browse/NLPCRAFT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov updated NLPCRAFT-70: - Summary: ContextWord server side enricher (was: ML server enricher) > ContextWord server side enricher > > > Key: NLPCRAFT-70 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-70 > Project: NLPCraft > Issue Type: Task > Components: server >Reporter: Sergey Kamov >Assignee: Sergey Kamov >Priority: Major > Fix For: 0.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
