Re: Upgrading Selenium

2023-01-20 Thread Markus Jelsma
> There must be a way, some how, some time. There isn't: https://github.com/seleniumhq/selenium-google-code-issue-archive/issues/141 Op do 19 jan. 2023 om 15:23 schreef Markus Jelsma < markus.jel...@openindex.io>: > > This makes some sense if you do not know anything about the URL. > > - a HEAD

Re: Upgrading Selenium

2023-01-19 Thread Markus Jelsma
> This makes some sense if you do not know anything about the URL. > - a HEAD request could do almost the same > - often one knows whether there are only HTML pages or also PDFs, zip files, >and other stuff not suitable for Selenium. Could make the HEAD request >optional. Ah crap, i forgot

Re: Upgrading Selenium

2023-01-19 Thread Sebastian Nagel
Hi Kamil, hi Markus, upgrading the Selenium plugin is very appreciated! > Besides that, the plugin also needs some overhaul. Definitely. > It currently first downloads the URL with HttpClient, and then, depending on > MIME-type, it may or may not forward the URL to Selenium so it can be > down

Re: Upgrading Selenium

2023-01-18 Thread Kamil Mroczek
Thanks Markus. Let me submit the upgrade first to get my first commit in and then go from there. That optimization of reducing the number of HTTP requests will useful so I will look into that. On Tue, Jan 17, 2023 at 1:56 PM Markus Jelsma wrote: > Hello Kamil, > > Yes, the plugin needs some upgr

Re: Upgrading Selenium

2023-01-17 Thread Markus Jelsma
Hello Kamil, Yes, the plugin needs some upgrading indeed. We use a modern version of it elsewhere and it works really well, at least better than HtmlUnit. Besides that, the plugin also needs some overhaul. It currently first downloads the URL with HttpClient, and then, depending on MIME-type, it

Upgrading Selenium

2023-01-17 Thread Kamil Mroczek
Hello, I am sending a message to inquire whether I should submit a patch which updates selenium to the latest version. Although it is a major version upgrade to the library, very few code changes were needed to update. For a preview of the changes I made you can look here