Build failed in Jenkins: NuttX-Nightly-Build #63

See Changes: -- [...truncated 505.07 KB...] Copy files Select CONFIG_HOST_LINUX=y Refreshing... Building NuttX...

Re: Should we relax precheck a little bit?

Maciej, Thank you! I didn't know about the IndentPPDirectives option! I will try it! :) -adam On Fri, Mar 13, 2020 at 5:16 PM Maciej Wójcik wrote: > Are you sure that clang-format cannot indent macros? What about > > IndentPPDirectives: PPDIS_AfterHash > > It also treats the outmost macro

Re: Should we relax precheck a little bit?

Are you sure that clang-format cannot indent macros? What about IndentPPDirectives: PPDIS_AfterHash It also treats the outmost macro in headers in a special way. On Sat, 14 Mar 2020, 01:03 Adam Feuer, wrote: > David, > > Re: whatstyle, I ran it overnight on the c files in sched/ and came up

Re: Should we relax precheck a little bit?

David, Re: whatstyle, I ran it overnight on the c files in sched/ and came up with a clang-format that does somewhat ok. Thanks for pointing that program out. By looking at the output of the diff, I learned a lot about how hard it is to manually format programs. :) Anyway, the biggest problem

Re: pthread_mutex_lock() and signals

Nathan, There is one issue we have to be careful about:  pthread _mutex_timedlock():  It needs the signal in order to wake up and return from the wait. pthread_mutex_lock() just calls pthread_mutex_timedlock() with and time value of NULL.  So it is this NULL argument that is passed must

Re: pthread_mutex_lock() and signals

On Fri, Mar 13, 2020 at 6:17 PM Gregory Nutt wrote: > > If pthread_mutex_timedlock() would call pthread_mutex_take() with a > > intr value of false, instead of true as it is doing now, that would > > cause pthread_sem_take() to call nxsem_wait_uninterruptible(). > > > > But, I am *not* rushing to

Re: [PATCH] apps, system/cu fix and additional option

Ok, thanks! сб, 14 мар. 2020 г. в 01:08, Abdelatif Guettouche < abdelatif.guettou...@gmail.com>: > Hi, > > Thanks. I created a PR based on your patches > (https://github.com/apache/incubator-nuttx-apps/pull/122) > Github PRs pass through the CI checks and make the review process smother. > If

Re: pthread_mutex_lock() and signals

If pthread_mutex_timedlock() would call pthread_mutex_take() with a intr value of false, instead of true as it is doing now, that would cause pthread_sem_take() to call nxsem_wait_uninterruptible(). But, I am *not* rushing to change this, because I don't know what else it might affect (and

Re: pthread_mutex_lock() and signals

On Fri, Mar 13, 2020 at 6:12 PM Gregory Nutt wrote: > On 3/13/2020 4:00 PM, Gregory Nutt wrote: > > Sounds like it needs to call nxsig_wait_uninterruptible instead of > > nxsig_wait somewhere in sched/pthread/ > > s/nxsig_wait/nxsem_wait/g > > The calling sequence is: > >

Re: pthread_mutex_lock() and signals

On 3/13/2020 4:00 PM, Gregory Nutt wrote: Sounds like it needs to call nxsig_wait_uninterruptible instead of nxsig_wait somewhere in sched/pthread/ s/nxsig_wait/nxsem_wait/g The calling sequence is: libs/libc/phthread:pthread_mutex_lock() ->

Re: [PATCH] apps, system/cu fix and additional option

Hi, Thanks. I created a PR based on your patches (https://github.com/apache/incubator-nuttx-apps/pull/122) Github PRs pass through the CI checks and make the review process smother. If you can use Github, please for future contributions submit PRs at https://github.com/apache/incubator-nuttx and

Re: pthread_mutex_lock() and signals

Sounds like it needs to call nxsig_wait_uninterruptible instead of nxsig_wait somewhere in sched/pthread/ On 3/13/2020 3:59 PM, Nathan Hartman wrote: According to the description of pthread_mutex_lock() (in the function's comment block): "If a signal is delivered to a thread waiting for a

pthread_mutex_lock() and signals

According to the description of pthread_mutex_lock() (in the function's comment block): "If a signal is delivered to a thread waiting for a mutex, upon return from the signal handler the thread resumes waiting for the mutex as if it was not interrupted." But I don't see it. From my reading of

Re: [PATCH] apps, system/cu fix and additional option

Hi, Resend txts сб, 14 мар. 2020 г. в 00:31, Abdelatif Guettouche < abdelatif.guettou...@gmail.com>: > Hi Oleg, > > Unfortunately the patch didn't make it through. > Could you please resend it again with a .txt extension or open a PR in > https://github.com/apache/incubator-nuttx-apps > > On

Re: [PATCH] apps, system/cu fix and additional option

Hi Oleg, Unfortunately the patch didn't make it through. Could you please resend it again with a .txt extension or open a PR in https://github.com/apache/incubator-nuttx-apps On Fri, Mar 13, 2020 at 3:26 PM Oleg Evseev wrote: > > 1) system/cu: fix wrongly swapped parity options > 2) system/cu:

Re: NuttX Event postponed

On Fri, Mar 13, 2020 at 2:08 PM Alan Carvalho de Assis wrote: > Hi Everyone, > > As you know, the Corona Virus (COVID19) situation in China, Japan and > other countries is still worrying. > > So, we decided to postpone the NuttX event to 2021 spring. > > The good news is that we received many

NuttX Event postponed

Hi Everyone, As you know, the Corona Virus (COVID19) situation in China, Japan and other countries is still worrying. So, we decided to postpone the NuttX event to 2021 spring. The good news is that we received many proposals for lectures (twice as many as 2019), despite the current situation.