Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Xiang Xiao
Takashi provide a patch fix this issue: https://github.com/apache/incubator-nuttx/pull/701 The new behivour is: 1.The default action restore to "make distclean" 2.-G option trigger "git clean -xfdq" On Fri, Apr 3, 2020 at 10:10 AM Xiang Xiao wrote: > > On Fri, Apr 3, 2020 at 8:52 AM Gregory Nutt

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Xiang Xiao
On Fri, Apr 3, 2020 at 8:52 AM Gregory Nutt wrote: > > > > Do we have a platform-independent way to detect whether the NuttX > > distribution is a git clone or not? > Yes, just do a check if the directory at $TOPDIR/.git exists. > > Also, doesn't 'make distclean' clean in apps as well as nuttx?

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 8:52 PM Gregory Nutt wrote: > > Do we have a platform-independent way to detect whether the NuttX > > distribution is a git clone or not? > Yes, just do a check if the directory at $TOPDIR/.git exists. Ok. More below. > > Also, doesn't 'make distclean' clean in apps as

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Gregory Nutt
I opened issue #698 -- https://github.com/apache/incubator-nuttx/issues/698. Issues are good.  Someday they will be fixed but it might be weeks or months.  If you really want a quick turnaround, a PR (or patch) is the only way to do that.

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Gregory Nutt
Do we have a platform-independent way to detect whether the NuttX distribution is a git clone or not? Yes, just do a check if the directory at $TOPDIR/.git exists. Also, doesn't 'make distclean' clean in apps as well as nuttx? Because I think 'git cleanup' won't clean apps. It will also

Re: [DISCUSS] Release Notes

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 8:11 PM Adam Feuer wrote: > Ok, so let's split up the PRs with the three people we have now, Abdelatif, > Nathan, and me. As new people join, we can give them ranges to look at. > > Let's do features first: > >- Abdelatif: PRs: 1-232 >- Nathan: PRs: 233-465 >-

Re: [DISCUSS] Release Notes

2020-04-02 Thread Adam Feuer
Ok, so let's split up the PRs with the three people we have now, Abdelatif, Nathan, and me. As new people join, we can give them ranges to look at. Let's do features first: - Abdelatif: PRs: 1-232 - Nathan: PRs: 233-465 - Adam: PRs: 466-697 Read the PRs, take notes as a bulleted list,

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 7:59 PM Gregory Nutt wrote: > You should open an issue, or better, push a PR. I opened issue #698 -- https://github.com/apache/incubator-nuttx/issues/698.

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 7:59 PM Gregory Nutt wrote: > On 4/2/2020 5:50 PM, Nathan Hartman wrote: > > Regarding commit 27142b2e3c4c6498dc198818ec9b260d812f, this means > > that tools/testbuild.sh now depends on git and on the NuttX > > distribution being a git clone. > > You should open an

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Gregory Nutt
You should open an issue, or better, push a PR. On 4/2/2020 5:50 PM, Nathan Hartman wrote: Hi all, I didn't catch this before the PR was merged, so apologies for being slightly late... Regarding commit 27142b2e3c4c6498dc198818ec9b260d812f, this means that tools/testbuild.sh now depends on

tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
Hi all, I didn't catch this before the PR was merged, so apologies for being slightly late... Regarding commit 27142b2e3c4c6498dc198818ec9b260d812f, this means that tools/testbuild.sh now depends on git and on the NuttX distribution being a git clone. Previously we discussed this when a

Re: STM32H7 support

2020-04-02 Thread John Rippetoe
Is there a working document or set of notes detailing ongoing/needed work for STM32H7 support? Not really - a diff to the F7 file usually will show the holes but there is also the datasheet diff view. What do you mean by datasheet diff? We used SDMMC2 in all H7 designs and that choice

Re: SAMA5D27 SDMMC support branch

2020-04-02 Thread Adam Feuer
Takeyoshi, No worries– I had to work on other things too. -adam On Thu, Apr 2, 2020 at 3:22 PM Takeyoshi Kikuchi wrote: > Adam, > > Sorry, I am currently busy working and have no progress. > I want to check tomorrow. > > Takeyoshi Kikuchi > > On 2020/04/02 9:48, Adam Feuer wrote: > >

Re: SAMA5D27 SDMMC support branch

2020-04-02 Thread Takeyoshi Kikuchi
Adam, Sorry, I am currently busy working and have no progress. I want to check tomorrow. Takeyoshi Kikuchi On 2020/04/02 9:48, Adam Feuer wrote: Takeyoshi, I did some work on the SDMCC driver today, it compiles now and I pushed the code to the branch. I will try it and let you know how it

RE: STM32H7 support

2020-04-02 Thread David Sidrane
Hi John, >Is there a working document or set of notes detailing ongoing/needed work for STM32H7 support? Not really - a diff to the F7 file usually will show the holes but there is also the datasheet diff view. We used SDMMC2 in all H7 designs and that choice gave us the ability to bring out

Re: [DISCUSS] Release Notes

2020-04-02 Thread Abdelatif Guettouche
At the time of writing we've got 1124 commits since nuttx-8.2 for nuttx/ and 230 for apps/. I'm expecting to see a lot of style fixes but also a lot of features and bug fixes. > We need a few more volunteers. I can get some done, whether it's features or bug fixes. On Thu, Apr 2, 2020 at 10:11

Re: [DISCUSS] Release Notes

2020-04-02 Thread Adam Feuer
I can't download all the PR descriptions due to rate limiting. Back to the plan suggested by Nathan. We need a few more volunteers. -adam On Thu, Apr 2, 2020 at 11:55 AM Adam Feuer wrote: > I have an improvement to the process. I just made a scrapy > script that can

STM32H7 support

2020-04-02 Thread John Rippetoe
Hi all, Is there a working document or set of notes detailing ongoing/needed work for STM32H7 support? I've looked through the code in arc/arm/*/stm32h7, release notes, board README, and commits/issues/PRs on github to piece together some of what has been worked on.  It appears that a lot of

Re: [DISCUSS] Release Notes

2020-04-02 Thread Gregory Nutt
On 4/2/2020 1:04 PM, Gregory Nutt wrote: Bumping this up. It seems like we need a plan to tackle going through the 613 closed PRs and summarizing (only merged ones need to be summarized). This would be easier with a team of people... anyone want to help? One way we could do this is one group

Re: [DISCUSS] Release Notes

2020-04-02 Thread Gregory Nutt
Bumping this up. It seems like we need a plan to tackle going through the 613 closed PRs and summarizing (only merged ones need to be summarized). This would be easier with a team of people... anyone want to help? One way we could do this is one group take bug fixes, and another take

Re: [DISCUSS] Release Notes

2020-04-02 Thread Adam Feuer
I have an improvement to the process. I just made a scrapy script that can download the PR title and description from Github. (Yeah that should be accessible via the Github API but I couldn't figure out how.) So I can make a spreadsheet or an HTML doc that has all the PR

Re: [DISCUSS] Release Notes

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 1:01 PM Adam Feuer wrote: > > Bumping this up. It seems like we need a plan to tackle going through the > 613 closed PRs and summarizing (only merged ones need to be summarized). > This would be easier with a team of people... anyone want to help? > > One way we could do

Re: [DISCUSS] Release Notes

2020-04-02 Thread Adam Feuer
Bumping this up. It seems like we need a plan to tackle going through the 613 closed PRs and summarizing (only merged ones need to be summarized). This would be easier with a team of people... anyone want to help? One way we could do this is one group take bug fixes, and another take features,

Re: The Release

2020-04-02 Thread Adam Feuer
Yes, let's try to get a release out. -adam On Thu, Apr 2, 2020 at 9:44 AM Nathan Hartman wrote: > On Thu, Apr 2, 2020 at 9:02 AM Abdelatif Guettouche < > abdelatif.guettou...@gmail.com> wrote: > > > I wanted to revive this, 6th of April is around the corner, does > > everybody agree with the

Re: The Release

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 9:02 AM Abdelatif Guettouche < abdelatif.guettou...@gmail.com> wrote: > I wanted to revive this, 6th of April is around the corner, does > everybody agree with the timeline here? I'm looking forward to it! Cheers, Nathan

Re: The Release

2020-04-02 Thread Abdelatif Guettouche
I wanted to revive this, 6th of April is around the corner, does everybody agree with the timeline here? > Ok, I copied that release checklist and put in the wiki here: Thanks, Adam. I guess we can start crossing some. On Mon, Mar 30, 2020 at 7:23 PM Adam Feuer wrote: > > Ok, I copied that