Re: 答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-11 Thread Tomek CEDRO
ACK! :-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info On Sat, Mar 11, 2023, 23:53 Xiang Xiao wrote: > On Sun, Mar 12, 2023 at 2:09 AM Tomek CEDRO wrote: > > > Please consult Unix manual and source code (for instance any of the BSD). > > Linux was never a reference in Unix world, it was abou

Re: 答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-11 Thread Xiang Xiao
On Sun, Mar 12, 2023 at 2:09 AM Tomek CEDRO wrote: > Please consult Unix manual and source code (for instance any of the BSD). > Linux was never a reference in Unix world, it was about to mimic Unix, but > was not even self-compatible. Not a good reference point. See how big mess > it introduced

Re: 答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-11 Thread Gregory Nutt
It is true that Linux is not fully POSIX compliant (e.g., https://linuxhint.com/is_linux_posix_compliant/).  But Linux folk have gone to a lot of work to clean up a Linux specification with the LSB: https://refspecs.linuxfoundation.org/lsb.shtml and that generally adopts POSIX standards.

Re: 答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-11 Thread Tomek CEDRO
Please consult Unix manual and source code (for instance any of the BSD). Linux was never a reference in Unix world, it was about to mimic Unix, but was not even self-compatible. Not a good reference point. See how big mess it introduced in current drivers implementation (i.e. drm kms) and their pr

Re: 答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Gregory Nutt
On 3/10/2023 5:30 PM, Qi3 Huang 黄齐 wrote: I have to agree that the code is looking better all of the time. Many of the obvious problems that I saw just a couple of days ago have been addressed.  Many of the things I have complained about in this thread have been fixed.  But there are probably

答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang 黄齐
ource to adapt it to NuttX. ________ 发件人: Qi3 Huang 黄齐 发送时间: 2023年3月11日 0:05:41 收件人: dev@nuttx.apache.org 主题: 答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver Thanks for point that, so my change will affect them by serial.c since it&

Re: 答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Gregory Nutt
On 3/10/2023 10:05 AM, Qi3 Huang 黄齐 wrote: Thanks for point that, so my change will affect them by serial.c since it's in common logic (excatly, is in uart_read()). You are right.  But that is not true of telnet, is it?

答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang 黄齐
Thanks for point that, so my change will affect them by serial.c since it's in common logic (excatly, is in uart_read()). 发件人: Gregory Nutt 发送时间: 2023年3月10日 23:58:29 收件人: dev@nuttx.apache.org 主题: Re: 答复: 答复: [External Mail]Re: [Breaking change] Echo charact

Re: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Gregory Nutt
Emm, I confirmed that one of my test platform (esp32c3), its cdcacm driver implement the uart_ops, but rp2040 seems not. CLE should works since it will override the content from driver ECHO if over serial driver, but readline shouldn't echo input. I'll test more to confirm it. cdcacm.c

答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang 黄齐
> Telnet is the same. It does not use any of the changes to serial.c. It > redirects stdin and stdout to the socket interface exchages raw data > with the host. It has now TERMIOS support. I'm sure telnet will echo input itself, so it works with some display issues before. __

答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang 黄齐
Emm, I confirmed that one of my test platform (esp32c3), its cdcacm driver implement the uart_ops, but rp2040 seems not. CLE should works since it will override the content from driver ECHO if over serial driver, but readline shouldn't echo input. I'll test more to confirm it. _