Re: ICMP responses on UDP broadcasts

2022-05-13 Thread Nathan Hartman
On Fri, May 13, 2022 at 5:14 AM Fotis Panagiotopoulos wrote: > > Hi Nathan, > > There is such a macro, it is net_ipv4addr_broadcast(). > I just used it, as you describe above, and I created PR #6262. > > I checked the result with Wireshark, and indeed it solves the issue. > > Thank you all! Grea

Re: ICMP responses on UDP broadcasts

2022-05-13 Thread Fotis Panagiotopoulos
Hi Nathan, There is such a macro, it is net_ipv4addr_broadcast(). I just used it, as you describe above, and I created PR #6262. I checked the result with Wireshark, and indeed it solves the issue. Thank you all! Στις Πέμ 12 Μαΐ 2022 στις 7:01 μ.μ., ο/η Nathan Hartman < hartman.nat...@gmail.com

Re: ICMP responses on UDP broadcasts

2022-05-12 Thread Nathan Hartman
On Thu, May 12, 2022 at 5:18 AM Bernd Walter wrote: > > On Wed, May 11, 2022 at 07:13:17PM -0400, Nathan Hartman wrote: > > On Wed, May 11, 2022 at 5:19 AM Fotis Panagiotopoulos > > wrote: > > > > > > I was thinking the same thing. > > > > > > Which layer is responsible for this check? > > > IP,

Re: ICMP responses on UDP broadcasts

2022-05-12 Thread Bernd Walter
On Wed, May 11, 2022 at 07:13:17PM -0400, Nathan Hartman wrote: > On Wed, May 11, 2022 at 5:19 AM Fotis Panagiotopoulos > wrote: > > > > I was thinking the same thing. > > > > Which layer is responsible for this check? > > IP, UDP, or ICMP? > > > Logically it would seem to me that UDP should do

Re: ICMP responses on UDP broadcasts

2022-05-11 Thread Nathan Hartman
On Wed, May 11, 2022 at 5:19 AM Fotis Panagiotopoulos wrote: > > I was thinking the same thing. > > Which layer is responsible for this check? > IP, UDP, or ICMP? Logically it would seem to me that UDP should do the check and trigger sending the ICMP unreachable reply when appropriate, though it

Re: ICMP responses on UDP broadcasts

2022-05-11 Thread Fotis Panagiotopoulos
I was thinking the same thing. Which layer is responsible for this check? IP, UDP, or ICMP? Στις Τρί 10 Μαΐ 2022 στις 2:41 μ.μ., ο/η Nathan Hartman < hartman.nat...@gmail.com> έγραψε: > On Tue, May 10, 2022 at 6:01 AM Fotis Panagiotopoulos > > wrote: > > > Hello, > > > > I just noticed that Nut

Re: ICMP responses on UDP broadcasts

2022-05-10 Thread Nathan Hartman
On Tue, May 10, 2022 at 6:01 AM Fotis Panagiotopoulos wrote: > Hello, > > I just noticed that NuttX responds with an ICMP port unreachable on UDP > broadcasts. > AFAIK this shouldn't happen. > > I followed the code, and I found that the broadcast reaches udp_input.c: > line 256, where the ICMP re

ICMP responses on UDP broadcasts

2022-05-10 Thread Fotis Panagiotopoulos
Hello, I just noticed that NuttX responds with an ICMP port unreachable on UDP broadcasts. AFAIK this shouldn't happen. I followed the code, and I found that the broadcast reaches udp_input.c: line 256, where the ICMP response is generated. There is a note there that indeed the ICMP shouldn't be