Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread Gregory Nutt
For opening a PR, usually you can just fork the repo and create a branch in the forked repo, and then open a PR. It is not necessary to create a branch in the original repo only for a PR. You can open a branch for a big feature, which usually needs a lot of commits and also a very long time be

Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread Duo Zhang
> From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] > Sent: Saturday, December 21, 2019 5:14 AM > To: dev@nuttx.apache.org > Subject: Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 > GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2] > > This is David's sugge

RE: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread David Sidrane
@nuttx.apache.org Subject: Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2] This is David's suggested workflow, but it still in the discussing or voting process? Before we get the approvement from community, we can't apply th

Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread Gregory Nutt
This is David's suggested workflow, but it still in the discussing or voting process? Before we get the approvement from community, we can't apply this process now because its' unfailr to other upcomming potential suggestion. So my suggestion is still to keep the old process: Greg review and c

Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread Xiang Xiao
day and give a PMC member a chance to review it. > > -Original Message- > From: Gregory Nutt [mailto:spudan...@gmail.com] > Sent: Saturday, December 21, 2019 4:56 AM > To: dev@nuttx.apache.org > Subject: Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 > GPIO_GPT

RE: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread David Sidrane
019 4:56 AM To: dev@nuttx.apache.org Subject: Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2] > Ut-oh It was not intended to be an abuse: This is how PR's or done all the > GH projects I am on as a commiter. > It is a branch

Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread Gregory Nutt
Ut-oh It was not intended to be an abuse: This is how PR's or done all the GH projects I am on as a commiter. It is a branch in the repo so like you have always done with patches, you or any of the PMC)can make change to it if need be. It is PR to master in the same repo. The process is simple

RE: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread David Sidrane
imple: review it (fix it if need be), merge it and delete the branch. -Original Message- From: Gregory Nutt [mailto:spudan...@gmail.com] Sent: Saturday, December 21, 2019 4:41 AM To: dev@nuttx.apache.org Subject: Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3

Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8 GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]

2019-12-21 Thread Gregory Nutt
So I am confused.  It looks like you created a branch in the repository and put all of you code there, bypassing patches and PRs.  This seems a bit of an abuse of your privileges.  I though we agreed that all people, including PPMC members and committers would have to follow the same work flow.