Re: Fail checks no new warnings?

2020-04-01 Thread Gregory Nutt
Almost warning come from #warning, we can: 1.Add -Wno-cpp to disable #warning for precheck/nightly build: https://stackoverflow.com/questions/9793293/how-do-i-disable-warning-message-in-gcc 2.Fix the remaining real warnning 3.Enable -Werror for precheck/nightly build The suggestion from

Re: Fail checks no new warnings?

2020-04-01 Thread Alan Carvalho de Assis
Hi Xiang, Yes, since there are few warnings it is better to fix them. BR, Alan On 4/1/20, Xiang Xiao wrote: > On Thu, Apr 2, 2020 at 1:25 AM Gregory Nutt wrote: >> >> >> > I was able to do this once before: >> > >> > #if !defined(TODO) >> > # if !defined(NO_PRINT_TODOS) >> > # define

Re: Fail checks no new warnings?

2020-04-01 Thread Xiang Xiao
On Thu, Apr 2, 2020 at 1:25 AM Gregory Nutt wrote: > > > > I was able to do this once before: > > > > #if !defined(TODO) > > # if !defined(NO_PRINT_TODOS) > > # define DO_PRAGMA(x) _Pragma (#x) > > # define TODO(x) DO_PRAGMA(message ("TODO - " #x)) > > # else > > # define TODO(x) > > #

Re: Fail checks no new warnings?

2020-04-01 Thread Gregory Nutt
I was able to do this once before: #if !defined(TODO) # if !defined(NO_PRINT_TODOS) # define DO_PRAGMA(x) _Pragma (#x) # define TODO(x) DO_PRAGMA(message ("TODO - " #x)) # else # define TODO(x) # endif #endif IIRC it allowed me to print compiler output that was not treated as warnings

RE: Fail checks no new warnings?

2020-04-01 Thread David Sidrane
Hi Greg, I was able to do this once before: #if !defined(TODO) # if !defined(NO_PRINT_TODOS) # define DO_PRAGMA(x) _Pragma (#x) # define TODO(x) DO_PRAGMA(message ("TODO - " #x)) # else # define TODO(x) # endif #endif IIRC it allowed me to print compiler output that was not treated as

Re: Fail checks no new warnings?

2020-04-01 Thread Gregory Nutt
  I did this manually when I ran the build tests myself:  I just kept the last good test log and diff'ed the current test log with that known good log.  Any new warnings would show up in the diffs.  The tricky part is that there is a lot of other kruft that shows up in the diffs too