RE: I saw a new option for merging in GH: Auto merge when CI completes

2021-02-05 Thread Matias N.
Yes this would be a useful feature.
Assuming that the trigger disarms if there's a new push in between, which may 
require new review.


RE: I saw a new option for merging in GH: Auto merge when CI completes

2021-02-05 Thread David Sidrane
Yes.

But that feature needs to be enabled for us by infra.

-Original Message-
From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com]
Sent: Friday, February 05, 2021 2:04 AM
To: dev@nuttx.apache.org
Subject: Re: I saw a new option for merging in GH: Auto merge when CI
completes

We set it manually right?
I mean after reviewing we can set the PR to be merged when the CI
checks are done?

On Fri, Feb 5, 2021 at 10:53 AM David Sidrane 
wrote:
>
> Hi,
>
> I saw a new option for merging in GH Auto merge when CI completes.
>
> What is the group's opinion on having this enabled?
>
> David


Re: I saw a new option for merging in GH: Auto merge when CI completes

2021-02-05 Thread Abdelatif Guettouche
We set it manually right?
I mean after reviewing we can set the PR to be merged when the CI
checks are done?

On Fri, Feb 5, 2021 at 10:53 AM David Sidrane  wrote:
>
> Hi,
>
> I saw a new option for merging in GH Auto merge when CI completes.
>
> What is the group's opinion on having this enabled?
>
> David


I saw a new option for merging in GH: Auto merge when CI completes

2021-02-05 Thread David Sidrane
Hi,

I saw a new option for merging in GH Auto merge when CI completes.

What is the group's opinion on having this enabled?

David