Re: JPA DAO refactoring.

2010-05-02 Thread Jeff Yu
;> Hi Jeff, >> >> In that case I believe I have completed all the JPA refactoring. >> >> Regards, >> >> Aaron >> >> >> >> >> ____________ >> From: Jeff Yu >> To: dev@ode.apache.org >> Sent:

Re: JPA DAO refactoring.

2010-04-30 Thread Jeff Yu
Aaron Anderson wrote: > Hi Jeff, > > In that case I believe I have completed all the JPA refactoring. > > Regards, > > Aaron > > > > > > From: Jeff Yu > To: dev@ode.apache.org > Sent: Mon, April 26, 2010 9:45:11 AM >

Re: JPA DAO refactoring.

2010-04-29 Thread Aaron Anderson
Hi Jeff, In that case I believe I have completed all the JPA refactoring. Regards, Aaron From: Jeff Yu To: dev@ode.apache.org Sent: Mon, April 26, 2010 9:45:11 AM Subject: Re: JPA DAO refactoring. Hi Aaron, I don't thin

Re: JPA DAO refactoring.

2010-04-26 Thread Jeff Yu
ould the ProcessAndInstanceManagementImpl implementation > support querying in-memory processes or is this test no longer valid and can > be commented out? > > Thanks, > > Aaron > > > > > > From: Jeff Yu > To: dev@ode.apache.org &g

Re: JPA DAO refactoring.

2010-04-23 Thread Aaron Anderson
querying in-memory processes or is this test no longer valid and can be commented out? Thanks, Aaron From: Jeff Yu To: dev@ode.apache.org Sent: Mon, April 12, 2010 10:15:56 PM Subject: Re: JPA DAO refactoring. Hi Aaron, With latest jpa branch, all of modules

Re: JPA DAO refactoring.

2010-04-12 Thread Jeff Yu
time I updated the JPA branch and now there are only a few > tests failing (5) and 12 skipped. Hopefully I will get everything running > this week. > > Regards, > > Aaron > > > > > > From: Jeff Yu > To: dev@ode.apache.org >

Re: JPA DAO refactoring.

2010-04-12 Thread Aaron Anderson
47:39 AM Subject: Re: JPA DAO refactoring. Hi Aaron, I've checked the latest code, also checked in the JPAConnection name issue, (I've updated it into JpaConnection). After that, I've run the 'mvn clean install' from top-level, and got following jar missing. I am wonderin

Re: JPA DAO refactoring.

2010-04-08 Thread Jeff Yu
Hi Aaron, I've checked the latest code, also checked in the JPAConnection name issue, (I've updated it into JpaConnection). After that, I've run the 'mvn clean install' from top-level, and got following jar missing. I am wondering if you forgot to commit some changes? Results : Failed tests: t

Re: JPA DAO refactoring.

2010-04-07 Thread Aaron Anderson
ds, Aaron From: Jeff Yu To: dev@ode.apache.org Sent: Tue, April 6, 2010 1:13:09 AM Subject: Re: JPA DAO refactoring. Hi Aaron, Thanks for the update. It looks good. I will look into the axis2-war pom file, and to try against the ode trunk. Thinking that maybe we c

Re: JPA DAO refactoring.

2010-04-05 Thread Jeff Yu
Jeff Yu > To: dev@ode.apache.org > Sent: Tue, March 30, 2010 12:18:57 AM > Subject: Re: JPA DAO refactoring. > > Hi Aaron, > > comments inline. > > On Tue, Mar 30, 2010 at 2:31 AM, Aaron Anderson >wrote: > > > Hi Jeff, > > > > Thanks for the respo

Re: JPA DAO refactoring.

2010-04-02 Thread Aaron Anderson
is stable now after all my changes and the rest of the work to get the tests all passing again should just be maven tweaks. Regards, Aaron From: Jeff Yu To: dev@ode.apache.org Sent: Tue, March 30, 2010 12:18:57 AM Subject: Re: JPA DAO refactoring. Hi

Re: JPA DAO refactoring.

2010-03-29 Thread Jeff Yu
Hi Aaron, comments inline. On Tue, Mar 30, 2010 at 2:31 AM, Aaron Anderson wrote: > Hi Jeff, > > Thanks for the response. I noticed that the integration tests were in the > svn trunk so I updated it to run the tests and while there were failed test > cases more passed than the git JPA branch so

Re: JPA DAO refactoring.

2010-03-29 Thread Aaron Anderson
t;> >> Regards, >> >> Aaron >> >> >> >> >> >> From: Jeff Yu >> To: dev@ode.apache.org >> Sent: Fri, March 26, 2010 12:18:03 AM >> Subject: Re: JPA DAO refactoring. >> >> Hi Aaro

Re: JPA DAO refactoring.

2010-03-29 Thread Jeff Yu
d the MaxPermSize for JAVA? like: export JAVA_OPTS="-Xms512M -Xmx512M -XX:MaxPermSize=512M" -Jeff > > Regards, > > Aaron > > > > > > From: Jeff Yu > To: dev@ode.apache.org > Sent: Fri, March 26, 2010 12:18:03 AM > Subjec

Re: JPA DAO refactoring.

2010-03-29 Thread Rafal Rusin
On 29 March 2010 11:40, Jeff Yu wrote: > For this refactoring work, we don't have to switch the hibernate impl, I > mean, we can have both jpa's impl (hibernate one) and the native hibernate. > People can stick with the native hibernate one even we move this jpa work > in. One benefit for this is

Re: JPA DAO refactoring.

2010-03-29 Thread Jeff Yu
For this refactoring work, we don't have to switch the hibernate impl, I mean, we can have both jpa's impl (hibernate one) and the native hibernate. People can stick with the native hibernate one even we move this jpa work in. One benefit for this is that I can leverage this work to support cluster

Re: JPA DAO refactoring.

2010-03-28 Thread Aaron Anderson
made to the engine caused anything to break. If you get a chance to run the axis2-war tests and could provide some feedback I would appreciate it. Regards, Aaron From: Jeff Yu To: dev@ode.apache.org Sent: Fri, March 26, 2010 12:18:03 AM Subject: Re: JPA DAO

Re: JPA DAO refactoring.

2010-03-26 Thread Rafal Rusin
distribution > as a whole in any real world tests. I should probably manually test both the > JBI and axis2-war distributions before the code get's promoted. I'll do that > soon and let you know my results. > > Regards, > > Aaron > > > _________

Re: JPA DAO refactoring.

2010-03-26 Thread Aaron Anderson
y manually test both the JBI and axis2-war distributions before the code get's promoted. I'll do that soon and let you know my results. Regards, Aaron From: Jeff Yu To: dev@ode.apache.org Sent: Fri, March 26, 2010 12:18:03 AM Subject: Re: JPA DAO ref

Re: JPA DAO refactoring.

2010-03-25 Thread Jeff Yu
Hi Aaron, The code is great. IMHO, below are the things that we need to be done for getting this big patch applied. 1. axis2-war module test case code is out-of-update, it still refers to the old dao package, like 'org.apache.ode.bpel.dao.", It seems to me that we didn't compile and run test case

Re: JPA DAO refactoring.

2010-03-25 Thread Aaron Anderson
: JPA DAO refactoring. Hi Aaron, I just did a quick run with the latest change, all modules compiled successfully, didn't get chance to run the test case. Unfortunately, I will be on vacation in the rest of this week, won't get time to look into the code until next week. please feel free

Re: JPA DAO refactoring.

2010-03-16 Thread Jeff Yu
ests. Can you please test it out again? > > Thanks, > > Aaron > > > > > > From: Aaron Anderson > To: dev@ode.apache.org > Sent: Mon, March 15, 2010 12:06:29 PM > Subject: Re: JPA DAO refactoring. > > Hi Jeff, > >

Re: JPA DAO refactoring.

2010-03-16 Thread Aaron Anderson
Sent: Mon, March 15, 2010 12:06:29 PM Subject: Re: JPA DAO refactoring. Hi Jeff, Thanks for the feedback! 1. I will do a checkout and a clean build and install on a different machine to make sure I don t have any maven modules cached on my dev machine. The SQLNonTransientConnectionException

Re: JPA DAO refactoring.

2010-03-15 Thread Aaron Anderson
Hi Jeff, Thanks for the feedback! 1. I will do a checkout and a clean build and install on a different machine to make sure I don t have any maven modules cached on my dev machine. The SQLNonTransientConnectionException class was added in JDK 1.6. Since Sun EOL d 1.5 last fall so I assumed the

Re: JPA DAO refactoring.

2010-03-15 Thread Jeff Yu
Hi Aaron, When I checked out the latest code from trunk, I have following observations: 1. When I run the 'mvn clean install', I've got following exception: (in the bpel-dao) /local/works/gitode/ode/bpel-dao/src/main/java/org/apache/ode/dao/DerbyJDBCContext.java:[8,16] cannot find symbol symbol

Re: JPA DAO refactoring.

2010-03-14 Thread Aaron Anderson
Subject: Re: JPA DAO refactoring. Hi Aaron, Thanks for this, one thing we also need to keep in mind is that we need to update the buildr's build file to make it build successfully as well in order to get this patch applied. So I was thinking not to make the build system too complicated. :) But

Re: JPA DAO refactoring.

2010-03-12 Thread Jeff Yu
Hi Aaron, Thanks for this, one thing we also need to keep in mind is that we need to update the buildr's build file to make it build successfully as well in order to get this patch applied. So I was thinking not to make the build system too complicated. :) But lets do as what you think now, and th

Re: JPA DAO refactoring.

2010-03-12 Thread Aaron Anderson
Hi Jeff, I am still working on the refactoring but have hit a speed bump with getting all the DAO tests to pass. For the BPEL DAO I tried to use HSQL but gave up on it since it did not support BLOB s that dao-hibernate uses and I came across a weird issue where hibernate was not getting a valid

Re: JPA DAO refactoring.

2010-03-09 Thread Jeff Yu
Hi Aaron, If we move the dao-test into bpel-test module, will we also run the bpel-test test cases multiple times with different dao implementation? With regard to the svn trunk change, I think we are good with it, as Apache ODE also has a git repository, we pull changes from it into our own git

Re: JPA DAO refactoring.

2010-03-09 Thread Aaron Anderson
AM Subject: Re: JPA DAO refactoring. Hi Aaron, comments inline. On Mon, Mar 8, 2010 at 3:28 PM, Aaron Anderson wrote: > Hi Jeff, > > I committed my changes to my github fork at > http://github.com/aaronanderson/ode/tree/jpa Please take a look at it and > let me know what you

Re: JPA DAO refactoring.

2010-03-09 Thread Jeff Yu
Hi Aaron, comments inline. On Mon, Mar 8, 2010 at 3:28 PM, Aaron Anderson wrote: > Hi Jeff, > > I committed my changes to my github fork at > http://github.com/aaronanderson/ode/tree/jpa Please take a look at it and > let me know what you think. Here are some notes on what I did: > > 1) Moved th

Re: JPA DAO refactoring.

2010-03-08 Thread Jeff Yu
new to git so if >> you would like to accept any of these changes I may need some pointers on >> how to merge them in with your repository. >> >> Cheers, >> >> Aaron >> >> >> >> >> >> >> ___

Re: JPA DAO refactoring.

2010-03-08 Thread Jeff Yu
ory. > > Cheers, > > Aaron > > > > > > > ________ > From: Jeff Yu > To: dev@ode.apache.org > Sent: Thu, March 4, 2010 11:26:50 PM > Subject: Re: JPA DAO refactoring. > > Hi Aaron, > > Yeah, lets try to put it into the

Re: JPA DAO refactoring.

2010-03-07 Thread Aaron Anderson
m new to git so if you would like to accept any of these changes I may need some pointers on how to merge them in with your repository. Cheers, Aaron From: Jeff Yu To: dev@ode.apache.org Sent: Thu, March 4, 2010 11:26:50 PM Subject: Re: JPA DAO refactoring

Re: JPA DAO refactoring.

2010-03-04 Thread Jeff Yu
JPA agent at runtime programatically so it behaves more like Hibernate. > > Regards, > > Aaron > > > > > From: Jeff Yu > To: dev@ode.apache.org > Sent: Thu, March 4, 2010 12:22:14 AM > Subject: Re: JPA DAO refactoring. > > Hi Aaro

Re: JPA DAO refactoring.

2010-03-04 Thread Aaron Anderson
From: Jeff Yu To: dev@ode.apache.org Sent: Thu, March 4, 2010 12:22:14 AM Subject: Re: JPA DAO refactoring. Hi Aaron, Firstly, we are very glad that you made progress on this, and interested in contributing your effort in this area. ;) comments inline. On Thu, Mar 4, 2010 at 2:02 PM

Re: JPA DAO refactoring.

2010-03-03 Thread Jeff Yu
Hi Aaron, Firstly, we are very glad that you made progress on this, and interested in contributing your effort in this area. ;) comments inline. On Thu, Mar 4, 2010 at 2:02 PM, Jeff Yu wrote: > Quote from Aaron's comments of JIRA. ( > https://issues.apache.org/jira/browse/ODE-704) > > Hi Jeff,

JPA DAO refactoring.

2010-03-03 Thread Jeff Yu
Quote from Aaron's comments of JIRA. ( https://issues.apache.org/jira/browse/ODE-704) Hi Jeff, Thanks for the pointers on helping me get started on this task. I have setup a github project and created a fork of your JPA branch. I have made some progress with separating the JPA and hibernate code