Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2018-12-28 Thread Jacques Le Roux

Hi Gil,

Are we sure there is not a test issue with this commit?

Locally I can't reproduce the same but I have also 4 failures, could you please 
check on your side?

Thanks

Jacques

Le 28/12/2018 à 15:28, build...@apache.org a écrit :

The Buildbot has detected a new failure on builder ofbizTrunkFrameworkPlugins 
while building . Full details are available at:
 https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/625

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: downstream
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1849853
Blamelist: pgil

BUILD FAILED: failed shell_4

Sincerely,
  -The Buildbot






Re: svn commit: r1849861 - /ofbiz/ofbiz-framework/branches/release18.12/

2018-12-28 Thread Jacques Le Roux

I created https://issues.apache.org/jira/browse/INFRA-17513 also for tests

Le 28/12/2018 à 15:58, Jacques Le Roux a écrit :

Thanks Nicolas,

Soon we will need to create the Buildbot build for this branch
I just created https://issues.apache.org/jira/browse/OFBIZ-10752 for that

Jacques

Le 28/12/2018 à 15:36, nma...@apache.org a écrit :

Author: nmalin
Date: Fri Dec 28 14:36:11 2018
New Revision: 1849861

URL: http://svn.apache.org/viewvc?rev=1849861=rev
Log:
Created feature branch 18.12 for the ofbiz-framework.

Added:
 ofbiz/ofbiz-framework/branches/release18.12/   (props changed)
   - copied from r1849860, ofbiz/ofbiz-framework/trunk/

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- svn:global-ignores (added)
+++ svn:global-ignores Fri Dec 28 14:36:11 2018
@@ -0,0 +1 @@
+.egradle

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- svn:ignore (added)
+++ svn:ignore Fri Dec 28 14:36:11 2018
@@ -0,0 +1,3 @@
+bin
+lib
+plugins

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Fri Dec 28 14:36:11 2018
@@ -0,0 +1,12 @@
+/ofbiz/branches/2013_RemoveJavolution:1462755
+/ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23:1535171-1654698
+/ofbiz/branches/OFBIZ-6275:1675394-1675466
+/ofbiz/branches/addbirt:831210-885099,885686-886087
+/ofbiz/branches/boostrap_theme:1635411,1635439,1635465
+/ofbiz/branches/dojo1.4:951708-952957
+/ofbiz/branches/framework-api-cleanup:1619853-1620529
+/ofbiz/branches/jackrabbit20100709:962442-1231517
+/ofbiz/branches/jquery:952958-1044489
+/ofbiz/branches/json-integration-refactoring:1634077-1635900
+/ofbiz/branches/multitenant20100310:921280-927264
+/ofbiz/branches/release13.07:1547657

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- tsvn:logtemplatecommit (added)
+++ tsvn:logtemplatecommit Fri Dec 28 14:36:11 2018
@@ -0,0 +1,9 @@
+Improved:
+Fixed:
+Implemented:
+Documented:
+Completed:
+Reverted:
+(OFBIZ-)
+Explanation
+Thanks:

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
 tsvn:logwidthmarker = 80







Re: svn commit: r1849861 - /ofbiz/ofbiz-framework/branches/release18.12/

2018-12-28 Thread Nicolas Malin

oh Merci !

I knew I missed a part of it :)

Thanks Jacques

On 28/12/2018 15:58, Jacques Le Roux wrote:

Thanks Nicolas,

Soon we will need to create the Buildbot build for this branch
I just created https://issues.apache.org/jira/browse/OFBIZ-10752 for that

Jacques

Le 28/12/2018 à 15:36, nma...@apache.org a écrit :

Author: nmalin
Date: Fri Dec 28 14:36:11 2018
New Revision: 1849861

URL: http://svn.apache.org/viewvc?rev=1849861=rev
Log:
Created feature branch 18.12 for the ofbiz-framework.

Added:
 ofbiz/ofbiz-framework/branches/release18.12/   (props changed)
   - copied from r1849860, ofbiz/ofbiz-framework/trunk/

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
-- 


--- svn:global-ignores (added)
+++ svn:global-ignores Fri Dec 28 14:36:11 2018
@@ -0,0 +1 @@
+.egradle

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
-- 


--- svn:ignore (added)
+++ svn:ignore Fri Dec 28 14:36:11 2018
@@ -0,0 +1,3 @@
+bin
+lib
+plugins

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
-- 


--- svn:mergeinfo (added)
+++ svn:mergeinfo Fri Dec 28 14:36:11 2018
@@ -0,0 +1,12 @@
+/ofbiz/branches/2013_RemoveJavolution:1462755
+/ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23:1535171-1654698 


+/ofbiz/branches/OFBIZ-6275:1675394-1675466
+/ofbiz/branches/addbirt:831210-885099,885686-886087
+/ofbiz/branches/boostrap_theme:1635411,1635439,1635465
+/ofbiz/branches/dojo1.4:951708-952957
+/ofbiz/branches/framework-api-cleanup:1619853-1620529
+/ofbiz/branches/jackrabbit20100709:962442-1231517
+/ofbiz/branches/jquery:952958-1044489
+/ofbiz/branches/json-integration-refactoring:1634077-1635900
+/ofbiz/branches/multitenant20100310:921280-927264
+/ofbiz/branches/release13.07:1547657

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
-- 


--- tsvn:logtemplatecommit (added)
+++ tsvn:logtemplatecommit Fri Dec 28 14:36:11 2018
@@ -0,0 +1,9 @@
+Improved:
+Fixed:
+Implemented:
+Documented:
+Completed:
+Reverted:
+(OFBIZ-)
+Explanation
+Thanks:

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
-- 


 tsvn:logwidthmarker = 80







Re: Planning for the creation of new 18.12 branches

2018-12-28 Thread Jacques Le Roux

I think Jiras would fit ;)

Jacques

Le 28/12/2018 à 15:48, Nicolas Malin a écrit :

Thanks all for your comments,

I created release18.12 at r1849861 for framework and r1849862 for plugins.

Rest to update website, prepare the release17.12 as stable and publish the 
17.12.01 but sure on the next year :)

Nicolas

On 28/12/2018 11:10, Jacopo Cappellato wrote:

I agree that to proceed and create the branch now and then, over the next
few months, as a community we will refine our strategy and even decide on
which of the various branches we should focus on more.

Jacopo


On Thu, Dec 27, 2018 at 1:59 PM Michael Brohl 
wrote:


Yes, that would be a solution.

I'm also fine if we would do a 19.x branch. For the future, we could aim
to have a release more towards the middle of the year to avoid
last-minute branching between Christmas and New Year ;-)

The above would fit perfectly with this plan:

1. create an 18.12 branch and stabilize it

2. release 17.12 ;-)

3. create a 19.x (x = {6..10} branch with the Java Upgrade


This would not break the yearly release branch and give us time for the
Java 11 Update in 19.x. 19.x would be earlier next year so we get out of
the end of year-hurries .

Thanks,

Michael


Am 27.12.18 um 12:38 schrieb Taher Alkhateeb:

yeah I guess that would work too if it is okay to push a big change
into that branch


On Thu, Dec 27, 2018 at 1:44 PM Deepak Dixit 

wrote:

We can create a branch and can backport java upgrade changes to 18.12 as
well.
Thanks & Regards
--
Deepak Dixit



On Thu, Dec 27, 2018 at 3:21 PM Taher Alkhateeb <

slidingfilame...@gmail.com>

wrote:


It's okay whatever folks decide, but I think it would be nice if we
can upgrade Java for a new branch.

On Thu, Dec 27, 2018 at 12:05 PM Nicolas Malin <

nicolas.ma...@nereide.fr>

wrote:

Four days before the end of year :)

If no opposition, I will create it tomorrow

Nicolas

On 19/12/2018 11:44, Deepak Dixit wrote:

I agree,

We should create the next release (18.12) for framework and plugins.
I'll check for issues, and if found will share here.
Thanks & Regards
--
Deepak Dixit



On Wed, Dec 19, 2018 at 3:38 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Le 19/12/2018 à 10:14, Nicolas Malin a écrit :

Hello,

The time pass and the end year is near, maybe it's the time to

prepare

next releases branches.

Two questions :

    * Are you agree to create releases 18.12 branches for framework

and

plugin ?

    * Do you have some priority issue that you absolutely need

fbefore

create theses branches ?

I see for my point of view OFBIZ-4361 and OFBIZ-10145. I

believe/will/try to free some time for working on.

Cheers,

Nicolas


Hi Nicolas, All,

As I think we agreed, we need to check all the blocker before

releasing

(not freezing) .

So IMO OFBIZ-4361 and OFBIZ-10145 are not blocker for freezing a

possible

18.12 branches (trunk+plugins)

Thanks

Jacques








Re: svn commit: r1849861 - /ofbiz/ofbiz-framework/branches/release18.12/

2018-12-28 Thread Jacques Le Roux

Thanks Nicolas,

Soon we will need to create the Buildbot build for this branch
I just created https://issues.apache.org/jira/browse/OFBIZ-10752 for that

Jacques

Le 28/12/2018 à 15:36, nma...@apache.org a écrit :

Author: nmalin
Date: Fri Dec 28 14:36:11 2018
New Revision: 1849861

URL: http://svn.apache.org/viewvc?rev=1849861=rev
Log:
Created feature branch 18.12 for the ofbiz-framework.

Added:
 ofbiz/ofbiz-framework/branches/release18.12/   (props changed)
   - copied from r1849860, ofbiz/ofbiz-framework/trunk/

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- svn:global-ignores (added)
+++ svn:global-ignores Fri Dec 28 14:36:11 2018
@@ -0,0 +1 @@
+.egradle

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- svn:ignore (added)
+++ svn:ignore Fri Dec 28 14:36:11 2018
@@ -0,0 +1,3 @@
+bin
+lib
+plugins

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Fri Dec 28 14:36:11 2018
@@ -0,0 +1,12 @@
+/ofbiz/branches/2013_RemoveJavolution:1462755
+/ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23:1535171-1654698
+/ofbiz/branches/OFBIZ-6275:1675394-1675466
+/ofbiz/branches/addbirt:831210-885099,885686-886087
+/ofbiz/branches/boostrap_theme:1635411,1635439,1635465
+/ofbiz/branches/dojo1.4:951708-952957
+/ofbiz/branches/framework-api-cleanup:1619853-1620529
+/ofbiz/branches/jackrabbit20100709:962442-1231517
+/ofbiz/branches/jquery:952958-1044489
+/ofbiz/branches/json-integration-refactoring:1634077-1635900
+/ofbiz/branches/multitenant20100310:921280-927264
+/ofbiz/branches/release13.07:1547657

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
--- tsvn:logtemplatecommit (added)
+++ tsvn:logtemplatecommit Fri Dec 28 14:36:11 2018
@@ -0,0 +1,9 @@
+Improved:
+Fixed:
+Implemented:
+Documented:
+Completed:
+Reverted:
+(OFBIZ-)
+Explanation
+Thanks:

Propchange: ofbiz/ofbiz-framework/branches/release18.12/
--
 tsvn:logwidthmarker = 80





Re: Planning for the creation of new 18.12 branches

2018-12-28 Thread Nicolas Malin

Thanks all for your comments,

I created release18.12 at r1849861 for framework and r1849862 for plugins.

Rest to update website, prepare the release17.12 as stable and publish 
the 17.12.01 but sure on the next year :)


Nicolas

On 28/12/2018 11:10, Jacopo Cappellato wrote:

I agree that to proceed and create the branch now and then, over the next
few months, as a community we will refine our strategy and even decide on
which of the various branches we should focus on more.

Jacopo


On Thu, Dec 27, 2018 at 1:59 PM Michael Brohl 
wrote:


Yes, that would be a solution.

I'm also fine if we would do a 19.x branch. For the future, we could aim
to have a release more towards the middle of the year to avoid
last-minute branching between Christmas and New Year ;-)

The above would fit perfectly with this plan:

1. create an 18.12 branch and stabilize it

2. release 17.12 ;-)

3. create a 19.x (x = {6..10} branch with the Java Upgrade


This would not break the yearly release branch and give us time for the
Java 11 Update in 19.x. 19.x would be earlier next year so we get out of
the end of year-hurries .

Thanks,

Michael


Am 27.12.18 um 12:38 schrieb Taher Alkhateeb:

yeah I guess that would work too if it is okay to push a big change
into that branch


On Thu, Dec 27, 2018 at 1:44 PM Deepak Dixit 

wrote:

We can create a branch and can backport java upgrade changes to 18.12 as
well.
Thanks & Regards
--
Deepak Dixit



On Thu, Dec 27, 2018 at 3:21 PM Taher Alkhateeb <

slidingfilame...@gmail.com>

wrote:


It's okay whatever folks decide, but I think it would be nice if we
can upgrade Java for a new branch.

On Thu, Dec 27, 2018 at 12:05 PM Nicolas Malin <

nicolas.ma...@nereide.fr>

wrote:

Four days before the end of year :)

If no opposition, I will create it tomorrow

Nicolas

On 19/12/2018 11:44, Deepak Dixit wrote:

I agree,

We should create the next release (18.12) for framework and plugins.
I'll check for issues, and if found will share here.
Thanks & Regards
--
Deepak Dixit



On Wed, Dec 19, 2018 at 3:38 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Le 19/12/2018 à 10:14, Nicolas Malin a écrit :

Hello,

The time pass and the end year is near, maybe it's the time to

prepare

next releases branches.

Two questions :

* Are you agree to create releases 18.12 branches for framework

and

plugin ?

* Do you have some priority issue that you absolutely need

fbefore

create theses branches ?

I see for my point of view OFBIZ-4361 and OFBIZ-10145. I

believe/will/try to free some time for working on.

Cheers,

Nicolas


Hi Nicolas, All,

As I think we agreed, we need to check all the blocker before

releasing

(not freezing) .

So IMO OFBIZ-4361 and OFBIZ-10145 are not blocker for freezing a

possible

18.12 branches (trunk+plugins)

Thanks

Jacques






OFBIZ-10691 Refactoring ‘EntityCondition’

2018-12-28 Thread Gil Portenseigne
Hello,

There is a very nice contribution from Mathieu Lirzin about refactoring
EntityCondition class hierarchy, to make it more legit and
understandable.

It is well documented and validated against integration test and basic
usage

This lies in OFBIZ-10691 Jira, if you want to have a look, i will commit it
next week.

Also Mathieu ask to not squash the patches within the Jira, and i'm
particularly in favor of it, since it is not the custom to do it in
OFBiz, i wanted to make it clear :).

Regards,

Gil 


Re: Planning for the creation of new 18.12 branches

2018-12-28 Thread Jacopo Cappellato
I agree that to proceed and create the branch now and then, over the next
few months, as a community we will refine our strategy and even decide on
which of the various branches we should focus on more.

Jacopo


On Thu, Dec 27, 2018 at 1:59 PM Michael Brohl 
wrote:

> Yes, that would be a solution.
>
> I'm also fine if we would do a 19.x branch. For the future, we could aim
> to have a release more towards the middle of the year to avoid
> last-minute branching between Christmas and New Year ;-)
>
> The above would fit perfectly with this plan:
>
> 1. create an 18.12 branch and stabilize it
>
> 2. release 17.12 ;-)
>
> 3. create a 19.x (x = {6..10} branch with the Java Upgrade
>
>
> This would not break the yearly release branch and give us time for the
> Java 11 Update in 19.x. 19.x would be earlier next year so we get out of
> the end of year-hurries .
>
> Thanks,
>
> Michael
>
>
> Am 27.12.18 um 12:38 schrieb Taher Alkhateeb:
> > yeah I guess that would work too if it is okay to push a big change
> > into that branch
> >
> >
> > On Thu, Dec 27, 2018 at 1:44 PM Deepak Dixit 
> wrote:
> >> We can create a branch and can backport java upgrade changes to 18.12 as
> >> well.
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >>
> >>
> >>
> >> On Thu, Dec 27, 2018 at 3:21 PM Taher Alkhateeb <
> slidingfilame...@gmail.com>
> >> wrote:
> >>
> >>> It's okay whatever folks decide, but I think it would be nice if we
> >>> can upgrade Java for a new branch.
> >>>
> >>> On Thu, Dec 27, 2018 at 12:05 PM Nicolas Malin <
> nicolas.ma...@nereide.fr>
> >>> wrote:
>  Four days before the end of year :)
> 
>  If no opposition, I will create it tomorrow
> 
>  Nicolas
> 
>  On 19/12/2018 11:44, Deepak Dixit wrote:
> > I agree,
> >
> > We should create the next release (18.12) for framework and plugins.
> > I'll check for issues, and if found will share here.
> > Thanks & Regards
> > --
> > Deepak Dixit
> >
> >
> >
> > On Wed, Dec 19, 2018 at 3:38 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Le 19/12/2018 à 10:14, Nicolas Malin a écrit :
> >>> Hello,
> >>>
> >>> The time pass and the end year is near, maybe it's the time to
> >>> prepare
> >> next releases branches.
> >>> Two questions :
> >>>
> >>>* Are you agree to create releases 18.12 branches for framework
> and
> >> plugin ?
> >>>* Do you have some priority issue that you absolutely need
> fbefore
> >> create theses branches ?
> >>> I see for my point of view OFBIZ-4361 and OFBIZ-10145. I
> >> believe/will/try to free some time for working on.
> >>> Cheers,
> >>>
> >>> Nicolas
> >>>
> >> Hi Nicolas, All,
> >>
> >> As I think we agreed, we need to check all the blocker before
> >>> releasing
> >> (not freezing) .
> >>
> >> So IMO OFBIZ-4361 and OFBIZ-10145 are not blocker for freezing a
> >>> possible
> >> 18.12 branches (trunk+plugins)
> >>
> >> Thanks
> >>
> >> Jacques
> >>
> >>
>
>


Re: Planning for the creation of new 18.12 branches

2018-12-28 Thread Nicolas Malin

Hello

On 27/12/2018 13:49, Michael Brohl wrote:

Yes, that would be a solution.

I'm also fine if we would do a 19.x branch. For the future, we could 
aim to have a release more towards the middle of the year to avoid 
last-minute branching between Christmas and New Year ;-)


The above would fit perfectly with this plan:

1. create an 18.12 branch and stabilize it

2. release 17.12 ;-)

3. create a 19.x (x = {6..10} branch with the Java Upgrade


I agree with that and I have no problem to backport huge commit on the 
first few month after branch creation.


:) sure create a branch on the last days of the year for respect own 
release rules it's not perfect but i'm sure help to activity community


I'm also in favor to create the release branch in october. I'll be 
careful with that the next year !


Nicolas




This would not break the yearly release branch and give us time for 
the Java 11 Update in 19.x. 19.x would be earlier next year so we get 
out of the end of year-hurries .


Thanks,

Michael


Am 27.12.18 um 12:38 schrieb Taher Alkhateeb:

yeah I guess that would work too if it is okay to push a big change
into that branch


On Thu, Dec 27, 2018 at 1:44 PM Deepak Dixit  
wrote:
We can create a branch and can backport java upgrade changes to 
18.12 as

well.
Thanks & Regards
--
Deepak Dixit



On Thu, Dec 27, 2018 at 3:21 PM Taher Alkhateeb 


wrote:


It's okay whatever folks decide, but I think it would be nice if we
can upgrade Java for a new branch.

On Thu, Dec 27, 2018 at 12:05 PM Nicolas Malin 


wrote:

Four days before the end of year :)

If no opposition, I will create it tomorrow

Nicolas

On 19/12/2018 11:44, Deepak Dixit wrote:

I agree,

We should create the next release (18.12) for framework and plugins.
I'll check for issues, and if found will share here.
Thanks & Regards
--
Deepak Dixit



On Wed, Dec 19, 2018 at 3:38 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Le 19/12/2018 à 10:14, Nicolas Malin a écrit :

Hello,

The time pass and the end year is near, maybe it's the time to

prepare

next releases branches.

Two questions :

   * Are you agree to create releases 18.12 branches for 
framework and

plugin ?
   * Do you have some priority issue that you absolutely need 
fbefore

create theses branches ?

I see for my point of view OFBIZ-4361 and OFBIZ-10145. I

believe/will/try to free some time for working on.

Cheers,

Nicolas


Hi Nicolas, All,

As I think we agreed, we need to check all the blocker before

releasing

(not freezing) .

So IMO OFBIZ-4361 and OFBIZ-10145 are not blocker for freezing a

possible

18.12 branches (trunk+plugins)

Thanks

Jacques