Re: java 1.5 next steps

2007-10-04 Thread Jacques Le Roux
It's cool to see a progress in using java 4.5 new features. Hopefully I will do some tests too. But I must say that I have already some issues awaiting review... Jacques De : Adam Heath [EMAIL PROTECTED] So, you've all seen the jira issues I've filed, all with patches attached. I need

[jira] Commented: (OFBIZ-567) Problem with POS modal window on Linux.

2007-10-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532358 ] Jacques Le Roux commented on OFBIZ-567: --- A interesting comment from Chris Liberty on user ML : The

Re: Typo

2007-10-04 Thread Jacopo Cappellato
Thanks Ján, this is now fixed in rev. 581919 Jacopo Ján Valkovič wrote: Hi, in function 'Clear Since Start Stats' (file \framework\webtools\webapp\webtools\WEB-INF\actions\stats\StatsSinceStart.bsh) in webtools is typo, missing 's' in clearBin: /String clearBins =

Typo

2007-10-04 Thread Ján Valkovič
Hi, in function 'Clear Since Start Stats' (file \framework\webtools\webapp\webtools\WEB-INF\actions\stats\StatsSinceStart.bsh) in webtools is typo, missing 's' in clearBin: String clearBins = request.getParameter("clear"); if (UtilValidate.isNotEmpty(clearBins) "true".equals(clearBin*s*)) {  

[jira] Created: (OFBIZ-1295) move hasExpired logic into CacheLine

2007-10-04 Thread Adam Heath (JIRA)
move hasExpired logic into CacheLine Key: OFBIZ-1295 URL: https://issues.apache.org/jira/browse/OFBIZ-1295 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN

[jira] Updated: (OFBIZ-1295) move hasExpired logic into CacheLine

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1295: -- Attachment: framework-base-CacheLine-hasExpired.patch move hasExpired logic into CacheLine

[jira] Updated: (OFBIZ-1296) EntityCache tries to use a protected method of UtilCache wrongly

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1296: -- Attachment: framework-entity-EntityCache-CacheLine-hasExpired.patch EntityCache tries to use a

[jira] Created: (OFBIZ-1296) EntityCache tries to use a protected method of UtilCache wrongly

2007-10-04 Thread Adam Heath (JIRA)
EntityCache tries to use a protected method of UtilCache wrongly Key: OFBIZ-1296 URL: https://issues.apache.org/jira/browse/OFBIZ-1296 Project: OFBiz Issue Type: Bug

[jira] Updated: (OFBIZ-1299) Use auto-boxing/unboxing in UtilCache

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1299: -- Attachment: framework-base-UtilCache-auto-boxing.patch Use auto-boxing/unboxing in UtilCache

[jira] Created: (OFBIZ-1299) Use auto-boxing/unboxing in UtilCache

2007-10-04 Thread Adam Heath (JIRA)
Use auto-boxing/unboxing in UtilCache - Key: OFBIZ-1299 URL: https://issues.apache.org/jira/browse/OFBIZ-1299 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions:

[jira] Created: (OFBIZ-1302) Use sub-classes of CacheLine to manage hard/soft references.

2007-10-04 Thread Adam Heath (JIRA)
Use sub-classes of CacheLine to manage hard/soft references. Key: OFBIZ-1302 URL: https://issues.apache.org/jira/browse/OFBIZ-1302 Project: OFBiz Issue Type: Improvement

[jira] Created: (OFBIZ-1304) Add a java 1.5 LRU map implementation

2007-10-04 Thread Adam Heath (JIRA)
Add a java 1.5 LRU map implementation - Key: OFBIZ-1304 URL: https://issues.apache.org/jira/browse/OFBIZ-1304 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions:

[jira] Created: (OFBIZ-1305) Switch CacheLineTable to the java 1.4 LRUMap.

2007-10-04 Thread Adam Heath (JIRA)
Switch CacheLineTable to the java 1.4 LRUMap. - Key: OFBIZ-1305 URL: https://issues.apache.org/jira/browse/OFBIZ-1305 Project: OFBiz Issue Type: Improvement Components: framework

[jira] Updated: (OFBIZ-1305) Switch CacheLineTable to the java 1.4 LRUMap.

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1305: -- Attachment: framework-base-CacheLineTableNewLRUMap.patch Switch CacheLineTable to the java 1.4

[jira] Commented: (OFBIZ-1305) Switch CacheLineTable to the java 1.4 LRUMap.

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532445 ] Adam Heath commented on OFBIZ-1305: --- It also depends on OFBIZ-1298. Switch CacheLineTable to the java 1.4

[jira] Commented: (OFBIZ-1293) start the listener thread earlier

2007-10-04 Thread Joe Eckard (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532442 ] Joe Eckard commented on OFBIZ-1293: --- Tested in production. start the listener thread earlier

[jira] Updated: (OFBIZ-1306) Add java 1.5 features to UtilCache and friends

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1306: -- Attachment: framework-base-cache-generics.patch Add java 1.5 features to UtilCache and friends

[jira] Created: (OFBIZ-1306) Add java 1.5 features to UtilCache and friends

2007-10-04 Thread Adam Heath (JIRA)
Add java 1.5 features to UtilCache and friends -- Key: OFBIZ-1306 URL: https://issues.apache.org/jira/browse/OFBIZ-1306 Project: OFBiz Issue Type: Improvement Components: framework

[jira] Created: (OFBIZ-1298) CacheLineTable.getKeyFromMemory() doesn't increment currentIdx

2007-10-04 Thread Adam Heath (JIRA)
CacheLineTable.getKeyFromMemory() doesn't increment currentIdx -- Key: OFBIZ-1298 URL: https://issues.apache.org/jira/browse/OFBIZ-1298 Project: OFBiz Issue Type: Bug

[jira] Updated: (OFBIZ-1297) Implement tri-state status in Start

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1297: -- Attachment: framework-start-FixStartStatusStartedRunningStopping.patch Implement tri-state status in

[jira] Created: (OFBIZ-1297) Implement tri-state status in Start

2007-10-04 Thread Adam Heath (JIRA)
Implement tri-state status in Start --- Key: OFBIZ-1297 URL: https://issues.apache.org/jira/browse/OFBIZ-1297 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN

[jira] Commented: (OFBIZ-1297) Implement tri-state status in Start

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532438 ] Adam Heath commented on OFBIZ-1297: --- This feature depends on OFBIZ-1282 and OFBIZ-1293. Implement tri-state

[jira] Updated: (OFBIZ-1298) CacheLineTable.getKeyFromMemory() doesn't increment currentIdx

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1298: -- Attachment: framework-base-FixCacheLineTableGetKeyFromMemory.patch CacheLineTable.getKeyFromMemory()

[jira] Updated: (OFBIZ-1300) Don't create temporary Integer in UtilCache config code

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1300: -- Attachment: framework-base-UtilCache-ImprovedNumberParsing.patch Don't create temporary Integer in

[jira] Updated: (OFBIZ-1301) Add UtilCache.findCache() for looking up caches by name

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1301: -- Attachment: framework-base-UtilCache-findCache.patch Add UtilCache.findCache() for looking up caches

[jira] Created: (OFBIZ-1301) Add UtilCache.findCache() for looking up caches by name

2007-10-04 Thread Adam Heath (JIRA)
Add UtilCache.findCache() for looking up caches by name --- Key: OFBIZ-1301 URL: https://issues.apache.org/jira/browse/OFBIZ-1301 Project: OFBiz Issue Type: New Feature

[jira] Created: (OFBIZ-1303) Don't use ObjectType.NULL for in memory table in CacheLineTable

2007-10-04 Thread Adam Heath (JIRA)
Don't use ObjectType.NULL for in memory table in CacheLineTable --- Key: OFBIZ-1303 URL: https://issues.apache.org/jira/browse/OFBIZ-1303 Project: OFBiz Issue Type: Improvement

[jira] Updated: (OFBIZ-1303) Don't use ObjectType.NULL for in memory table in CacheLineTable

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1303: -- Attachment: framework-base-CacheLineTable-no-NULL-in-memory.patch Don't use ObjectType.NULL for in

[jira] Updated: (OFBIZ-1304) Add a java 1.5 LRU map implementation

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1304: -- Attachment: framework-base-new-LRUMap.patch Add a java 1.5 LRU map implementation

Re: java 1.5 next steps

2007-10-04 Thread Adam Heath
Adam Heath wrote: So, you've all seen the jira issues I've filed, all with patches attached. I need those applied, so I can start feeding the large set of changes I have. Namely, I have a 1 line patch against all of framework, adding the following features: 1: generics markup 2:

Re: Adding validity dates to ProductPromoCode

2007-10-04 Thread Jacopo Cappellato
The solution with fromDate/thruDate is now implemented in rev. 581961 Jacopo Jacopo Cappellato wrote: Is it ok if I add a new field to the ProductPromoCode entity: expiryDate I'd like to use it to set a validity date for the promo code. Or would it be better to use the standard

Re: Adding validity dates to ProductPromoCode

2007-10-04 Thread David E Jones
Yeah, I think that looks fine Jacopo. We recently discussed doing something just like this with a client but it was never green lit. So yes, looks good and the option of doing from/thru is better than just a thru, so that's cool too. -David On Oct 4, 2007, at 10:46 AM, Jacopo

[jira] Created: (OFBIZ-1307) Add StringUtil.internString, which protects against NPE

2007-10-04 Thread Adam Heath (JIRA)
Add StringUtil.internString, which protects against NPE --- Key: OFBIZ-1307 URL: https://issues.apache.org/jira/browse/OFBIZ-1307 Project: OFBiz Issue Type: New Feature

[jira] Updated: (OFBIZ-1307) Add StringUtil.internString, which protects against NPE

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1307: -- Attachment: framework-base-StringUtil-internString.patch Add StringUtil.internString, which protects

[jira] Updated: (OFBIZ-1291) reduce memory usage in entitymodel.xml and services.xml reading/parsing

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1291: -- Attachment: framework-entity-InternModelServiceEntity.patch reduce memory usage in entitymodel.xml

[jira] Updated: (OFBIZ-1291) reduce memory usage in entitymodel.xml and services.xml reading/parsing

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1291: -- Attachment: (was: InternModelServiceEntity.patch) reduce memory usage in entitymodel.xml and

[jira] Commented: (OFBIZ-1291) reduce memory usage in entitymodel.xml and services.xml reading/parsing

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532498 ] Adam Heath commented on OFBIZ-1291: --- This now depends on OFBIZ-1307. reduce memory usage in entitymodel.xml and

[jira] Updated: (OFBIZ-1309) Make Start.init() use System.arraycopy() instead of doing a copy in a loop

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1309: -- Attachment: framework-start-Start-arraycopy.patch Make Start.init() use System.arraycopy() instead of

[jira] Created: (OFBIZ-1309) Make Start.init() use System.arraycopy() instead of doing a copy in a loop

2007-10-04 Thread Adam Heath (JIRA)
Make Start.init() use System.arraycopy() instead of doing a copy in a loop -- Key: OFBIZ-1309 URL: https://issues.apache.org/jira/browse/OFBIZ-1309 Project: OFBiz Issue

[jira] Commented: (OFBIZ-1309) Make Start.init() use System.arraycopy() instead of doing a copy in a loop

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532503 ] Adam Heath commented on OFBIZ-1309: --- This bug depends on OFBIZ-1282, OFBIZ-1293, and OFBIZ-1297/ Make

[jira] Created: (OFBIZ-1310) Classpath.addComponent(String) now calls addComponent(File).

2007-10-04 Thread Adam Heath (JIRA)
Classpath.addComponent(String) now calls addComponent(File). Key: OFBIZ-1310 URL: https://issues.apache.org/jira/browse/OFBIZ-1310 Project: OFBiz Issue Type: Improvement

[jira] Commented: (OFBIZ-1310) Classpath.addComponent(String) now calls addComponent(File).

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532504 ] Adam Heath commented on OFBIZ-1310: --- This bug depends on OFBIZ-1308. Classpath.addComponent(String) now calls

[jira] Updated: (OFBIZ-1310) Classpath.addComponent(String) now calls addComponent(File).

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1310: -- Attachment: framework-start-Classpath-addComponent-share.patch Classpath.addComponent(String) now

[jira] Created: (OFBIZ-1311) Switch Classpath to use StringBuilder, instead of StringBuffer

2007-10-04 Thread Adam Heath (JIRA)
Switch Classpath to use StringBuilder, instead of StringBuffer -- Key: OFBIZ-1311 URL: https://issues.apache.org/jira/browse/OFBIZ-1311 Project: OFBiz Issue Type: Improvement

[jira] Updated: (OFBIZ-1312) Add java 1.5 features to framework/base/start

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1312: -- Attachment: framework-start-generics.patch Add java 1.5 features to framework/base/start

[jira] Created: (OFBIZ-1312) Add java 1.5 features to framework/base/start

2007-10-04 Thread Adam Heath (JIRA)
Add java 1.5 features to framework/base/start - Key: OFBIZ-1312 URL: https://issues.apache.org/jira/browse/OFBIZ-1312 Project: OFBiz Issue Type: Improvement Components: framework

[jira] Commented: (OFBIZ-1311) Switch Classpath to use StringBuilder, instead of StringBuffer

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532505 ] Adam Heath commented on OFBIZ-1311: --- This bug depends on OFBIZ-1308 and OFBIZ-1310. Switch Classpath to use

[jira] Created: (OFBIZ-1308) Classpath.toString() doesn't use its loop variable

2007-10-04 Thread Adam Heath (JIRA)
Classpath.toString() doesn't use its loop variable -- Key: OFBIZ-1308 URL: https://issues.apache.org/jira/browse/OFBIZ-1308 Project: OFBiz Issue Type: Bug Components: framework

[jira] Updated: (OFBIZ-1308) Classpath.toString() doesn't use its loop variable

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1308: -- Attachment: framework-start-Classpath-toString-loop-fix.patch Classpath.toString() doesn't use its

[jira] Updated: (OFBIZ-1311) Switch Classpath to use StringBuilder, instead of StringBuffer

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1311: -- Attachment: framework-start-Classpath-StringBuilder.patch Switch Classpath to use StringBuilder,

[jira] Created: (OFBIZ-1313) Remove some Visit-related foreign keys

2007-10-04 Thread Si Chen (JIRA)
Remove some Visit-related foreign keys -- Key: OFBIZ-1313 URL: https://issues.apache.org/jira/browse/OFBIZ-1313 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Priority:

[jira] Commented: (OFBIZ-1313) Remove some Visit-related foreign keys

2007-10-04 Thread Si Chen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532533 ] Si Chen commented on OFBIZ-1313: Do you think there will be a way to remove old Visits and keep the

[jira] Assigned: (OFBIZ-1313) Remove some Visit-related foreign keys

2007-10-04 Thread Si Chen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1313: -- Assignee: Si Chen Remove some Visit-related foreign keys --

[jira] Commented: (OFBIZ-1313) Remove some Visit-related foreign keys

2007-10-04 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532530 ] David E. Jones commented on OFBIZ-1313: --- Yeah, I kind of object to this... think it's a bad idea. Still, not a

[jira] Updated: (OFBIZ-1291) reduce memory usage in entitymodel.xml and services.xml reading/parsing

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1291: -- Attachment: (was: framework-entity-InternModelServiceEntity.patch) reduce memory usage in

[jira] Updated: (OFBIZ-1291) reduce memory usage in entitymodel.xml and services.xml reading/parsing

2007-10-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-1291: -- Attachment: framework-entity-InternModelServiceEntity.patch Yet another version of this. Removed the

[jira] Commented: (OFBIZ-1313) Remove some Visit-related foreign keys

2007-10-04 Thread Jonathon Wong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532561 ] Jonathon Wong commented on OFBIZ-1313: -- The way I usually do it is to: 1. Null the field pointing to the