[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

2008-08-15 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622838#action_12622838 ] Bruno Busco commented on OFBIZ-1919: Hi Adrian, thank you for reviewing and updating

Production run instructions/comments

2008-08-15 Thread Bilgin Ibryam
Hi fellows, I want add possibility for entering comments (production instructions/comments) for selected configurable product items when ordering from Order manager. In ProductConfigConfig entity (where the configurations are stored) there is already a description field, which I suppose is for

Re: Discussion: Pluggable preferences/profile screen

2008-08-15 Thread Bruno Busco
Thinking more about this may be the same concept of pluggability could be used in the MyPage component. Every application could register in some way several own screens that will then all available to the user in the MyPage. Using the enable/disable checkboxes the user coud configure its MyPage

Re: Discovery of anti-pattern

2008-08-15 Thread Scott Gray
Thanks David, I guess it's pretty subjective and needs to be looked at on a larger scale rather than just examining small chunks of code. I might put that to one side for now unless I come across anything that looks like it might obviously cause issues. One example I came across that did concern

Re: Production run instructions/comments

2008-08-15 Thread BJ Freeman
Just a thought if the comments effect the production run, then there should be a structure that allows them to be called out, in manufacturing. I say this because the comments may effect time and materials for calculating production runs. They may also effect the ERP code. Bilgin Ibryam sent the

Re: Production run instructions/comments

2008-08-15 Thread BJ Freeman
I meant the ERP processes. BJ Freeman sent the following on 8/15/2008 6:46 AM: Just a thought if the comments effect the production run, then there should be a structure that allows them to be called out, in manufacturing. I say this because the comments may effect time and materials for

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

2008-08-15 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622884#action_12622884 ] Adrian Crum commented on OFBIZ-1919: Bruno, I removed links that are not in

Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src: META-INF/services/ org/ofbiz/minilang/method/conditional/

2008-08-15 Thread Jacopo Cappellato
Adam, please remember the License header and the svn properties (still missing from the last new file you added to the repository). Thanks, Jacopo On Aug 15, 2008, at 5:29 PM, [EMAIL PROTECTED] wrote: Author: doogie Date: Fri Aug 15 08:29:29 2008 New Revision: 686251 URL:

Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src: META-INF/services/ org/ofbiz/minilang/method/conditional/

2008-08-15 Thread Adam Heath
Jacopo Cappellato wrote: please remember the License header and the svn properties (still missing from the last new file you added to the repository). You're right, I forgot to add it to *this* new file; but I already did it for the last one. What svn properties need to be set? Or, point

Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src: META-INF/services/ org/ofbiz/minilang/method/conditional/

2008-08-15 Thread Jacopo Cappellato
On Aug 15, 2008, at 5:42 PM, Adam Heath wrote: Jacopo Cappellato wrote: please remember the License header and the svn properties (still missing from the last new file you added to the repository). You're right, I forgot to add it to *this* new file; but I already did it for the last

Re: Discussion: Pluggable preferences/profile screen

2008-08-15 Thread David E. Jones
While it wouldn't make sense for most of OFBiz, for the MyPage stuff a portal framework would be really valuable. Many of the things you describe here are basically what a portal framework does (ie the JSR 168 type of stuff). Other things would have to be added on to make things happen

Re: Production run instructions/comments

2008-08-15 Thread Jacopo Cappellato
I agree with you that storing them using the WorkEffortNote is the best way. Jacopo On Aug 15, 2008, at 10:51 AM, Bilgin Ibryam wrote: Hi fellows, I want add possibility for entering comments (production instructions/comments) for selected configurable product items when ordering from

Re: svn commit: r686251 - in /ofbiz/trunk/framework/minilang/src: META-INF/services/ org/ofbiz/minilang/method/conditional/

2008-08-15 Thread Adam Heath
Jacopo Cappellato wrote: On Aug 15, 2008, at 5:42 PM, Adam Heath wrote: Jacopo Cappellato wrote: please remember the License header and the svn properties (still missing from the last new file you added to the repository). You're right, I forgot to add it to *this* new file; but I already

[jira] Closed: (OFBIZ-1915) Improving request redirects

2008-08-15 Thread Si Chen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1915. -- Resolution: Fixed Improving request redirects --- Key: OFBIZ-1915

Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java

2008-08-15 Thread Bilgin Ibryam
Hi Si, there are errors in RequestHandler after this commit. Can you fix/revert it, please? Bilgin This message was sent using IMP, the Internet Messaging Program.

Fwd: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java

2008-08-15 Thread Scott Gray
Forwarding since Si doesn't subscribe to the dev list -- Forwarded message -- From: Bilgin Ibryam [EMAIL PROTECTED] Date: 2008/8/16 Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java

Re: [jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

2008-08-15 Thread Jacques Le Roux
Yes, it seems that it's easier to find photographies than illustrations. No surprise though : easier also to shoot than to draw ;o) Jacques From: Ashish Vijaywargiya [EMAIL PROTECTED] Here are some more free Image/Picture websites :- http://www.free-pictures-photos.com/

Re: svn commit: r686377 - in /ofbiz/trunk/applications/accounting: src/org/ofbiz/accounting/ src/org/ofbiz/accounting/invoice/ src/org/ofbiz/accounting/payment/ src/org/ofbiz/accounting/thirdparty/pay

2008-08-15 Thread Adam Heath
[EMAIL PROTECTED] wrote: Author: lektran Date: Fri Aug 15 14:40:30 2008 New Revision: 686377 URL: http://svn.apache.org/viewvc?rev=686377view=rev Log: Various clean ups, no functional changes While not having any specific feedback on this revision, I thought I might as well mention what code

Re: svn commit: r686377 - in /ofbiz/trunk/applications/accounting: src/org/ofbiz/accounting/ src/org/ofbiz/accounting/invoice/ src/org/ofbiz/accounting/payment/ src/org/ofbiz/accounting/thirdparty/pay

2008-08-15 Thread Scott Gray
Hi Adam Thanks for the info, it is interesting (yet tedious) work that I think it is important to understand. Do you think my commits are likely to get in your way? I know conflicts are a PITA and I'm happy to leave it while you do your thing, otherwise I had just planned to move down through

Re: svn commit: r686377 - in /ofbiz/trunk/applications/accounting: src/org/ofbiz/accounting/ src/org/ofbiz/accounting/invoice/ src/org/ofbiz/accounting/payment/ src/org/ofbiz/accounting/thirdparty/pay

2008-08-15 Thread Adam Heath
Scott Gray wrote: Also, you mention moving to the Fast* collections where appropriate, in your opinion where would it be inappropriate to do so? Where the sort order needs to be something other than natural, namely, using a Linked(Map|Set) or Tree(Map|Set). The order is not defined when

Re: svn commit: r686377 - in /ofbiz/trunk/applications/accounting: src/org/ofbiz/accounting/ src/org/ofbiz/accounting/invoice/ src/org/ofbiz/accounting/payment/ src/org/ofbiz/accounting/thirdparty/pay

2008-08-15 Thread Scott Gray
Ah ok gotcha, that makes perfect sense Thanks Scott 2008/8/16 Adam Heath [EMAIL PROTECTED]: Scott Gray wrote: Also, you mention moving to the Fast* collections where appropriate, in your opinion where would it be inappropriate to do so? Where the sort order needs to be something other than

Re: Production run instructions/comments

2008-08-15 Thread BJ Freeman
as long as you can control the sales person to put in only notes that don't effect the time or materials, I think this is fine. However my experience is that down the road the intent gets lost and notes the may effect the time and materials of a product run are introduced. so coming up with a

Re: svn commit: r685473 - in /ofbiz/trunk/specialpurpose: mypage/widget/CommonScreens.xml mypage/widget/MyPageForms.xml projectmgr/script/org/ofbiz/project/ProjectPermissionServices.xml

2008-08-15 Thread Hans Bakker
(resend because of email problems) Hi Adrian, first of thanks for the interest in the new component. What i am trying to do is to use this component not only for company employees but also for customers towhom the status of customer requests can be shown and perhaps also later the invoices. I

Re: svn commit: r685784 - in /ofbiz/trunk/specialpurpose/mypage/widget: CommonScreens.xml MyPageForms.xml

2008-08-15 Thread Hans Bakker
(resend because of email problems) Hi Adrian, the mypage component is to show the information specific for an ofbiz user. Initailly for any userlogin without any required permissions. This was rather difficult because of the current permission system used througout the other components which

Re: svn commit: r685836 - in /ofbiz/trunk/applications/order: script/org/ofbiz/order/request/CustRequestServices.xml servicedef/services_request.xml

2008-08-15 Thread Hans Bakker
(resend because of email problems) sure Jacopo, i tried to save some typing but readability suffered.corrected in revision 686100. On Thu, 2008-08-14 at 11:59 +0200, Jacopo Cappellato wrote: Hi Hans, wouldn't be better (more readable code) to refactor the if condition using the not

[jira] Commented: (OFBIZ-1920) Patch to add support for Postgresql with TEXT type fields

2008-08-15 Thread Philip W. Dalrymple III (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623072#action_12623072 ] Philip W. Dalrymple III commented on OFBIZ-1920: OK Let me try again. Many

IterateSectionWidget.renderWidgetString

2008-08-15 Thread Adam Heath
In framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java, line 102, it checks to see if the object is a map. If so, it gets the entry set(which contains Map.Entry), then converts that to an array(still of Map.Entry), then converts that to a list(still of Map.Entry). It then

[jira] Commented: (OFBIZ-1920) Patch to add support for Postgresql with TEXT type fields

2008-08-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623076#action_12623076 ] Jacques Le Roux commented on OFBIZ-1920: OK, I should have been more specific : had

IterateSectionWidget.renderNextPrev

2008-08-15 Thread Adam Heath
This method does not allow for [Previous] and [Next] to be translated.

Re: svn commit: r686377 - in /ofbiz/trunk/applications/accounting: src/org/ofbiz/accounting/ src/org/ofbiz/accounting/invoice/ src/org/ofbiz/accounting/payment/ src/org/ofbiz/accounting/thirdparty/pay

2008-08-15 Thread Jacques Le Roux
Adam, Thanks for the last point I was not aware of that; thanks for examples of use also. Jacques From: Adam Heath [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: lektran Date: Fri Aug 15 14:40:30 2008 New Revision: 686377 URL: http://svn.apache.org/viewvc?rev=686377view=rev Log:

Re: svn commit: r686377 - in /ofbiz/trunk/applications/accounting: src/org/ofbiz/accounting/ src/org/ofbiz/accounting/invoice/ src/org/ofbiz/accounting/payment/ src/org/ofbiz/accounting/thirdparty/pay

2008-08-15 Thread Adam Heath
One more bug I've noticed as I've been converting the code. I started out adding generics to framework; firstly, base. One common pattern in base, is several methods take a List of errorMessages; the idea is that the code can build up the errors that it detects. Initially, before I checked

Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java

2008-08-15 Thread David E Jones
On Aug 15, 2008, at 2:20 PM, Adam Heath wrote: Scott Gray wrote: Forwarding since Si doesn't subscribe to the dev list Er, he has commit access, but doesn't subscribe? Should this be disallowed? There are definitely people that have a problem with this, and it is a weird situation.

[jira] Commented: (OFBIZ-1920) Patch to add support for Postgresql with TEXT type fields

2008-08-15 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623086#action_12623086 ] BJ Freeman commented on OFBIZ-1920: --- the comments from Jacques, is about the way the