Re: ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-10 Thread Jacopo Cappellato
Do you mean this one: ? Regards, Jacopo On Nov 11, 2009, at 4:34 AM, Hans Bakker wrote: You probably already found it, it is now a secondary application accessible in the same row as webtools. Regards, Hans On Tue, 2009-11-10 at 11:45 +0100, Jacopo Cappellato wrote: Hans, wou

Re: extra Birt information (also answers Scott questions)

2009-11-10 Thread Jacopo Cappellato
I don't think we can distribute files like this: https://svn.apache.org/repos/asf/ofbiz/branches/addbirt/framework/birt/webapp/birt/CancelTask.jsp they are not licensed with the ASL2.0 and are not listed in the LICENSE file. Jacopo On Nov 10, 2009, at 4:22 PM, Jacopo Cappellato wrote: On

[jira] Closed: (OFBIZ-487) Improve performance of POS balance report printing

2009-11-10 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-487. - Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux This was alre

[jira] Commented: (OFBIZ-3169) Implementation of Budget functionality.

2009-11-10 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776341#action_12776341 ] Pierre Smits commented on OFBIZ-3169: - Hi Asish, More often than not it is the persone

Re: OFBiz Tests and Ant build.xml Files

2009-11-10 Thread Harmeet Bedi
What the static 'start' gives you is that you can run single or group of tests with one single container initialization and you can right click and tests in eclipse without caring about running container.. Not sure if there is a better way but need the container setup somehow and shared by junit

Re: OFBiz Tests and Ant build.xml Files

2009-11-10 Thread Harmeet Bedi
Another package used in testing is spring's mock servlet package 'org.springframework.mock.web'. (http://bit.ly/4zEAJF) Mockito intercepts calls with interception setup and checking in junit test. Very general purpose and can be used for servlets, delegators etc. Downside is that a parameter fr

Re: Discussion: User-Defined Java Data Types In The Framework

2009-11-10 Thread David E Jones
Thanks for your comments Harmeet. My main concern was that it makes these various bits of code bigger and more complex, and to balance that I'm wondering what the need is... ie what benefit comes from it? I know there are theoretical benefits like "at some point someone might want to do so

Re: Defining required permissions at the controller request

2009-11-10 Thread Wickersheimer Jeremy
Hi, This seems very interesting. I would say that the crawler could be a useful tool for developers (to begin with), do you have the code available somewhere ? Also i am guessing you can only get static permissions, what about permission that depend on a relationship between the current user

Re: Usage of @SuppressWarnings("serial")

2009-11-10 Thread Bob Morley
Sounds like a consensus; I will continue to use the suppression going forward. Perhaps we can spawn the shark conversation into another thread. :) Jacques Le Roux wrote: > > Scott, > > From: "Scott Gray" >> Hi Jacques, >> >> I'm not going to sit here and pretend to be some sort of expert on

Re: Discussion: User-Defined Java Data Types In The Framework

2009-11-10 Thread Harmeet Bedi
I think TimeDuration is a useful base type. It is something that exists in .NET system package (TimeSpan class) but has not been given as much importance in java land. I personally prefer name TimeSpan over TimeDuration. I think very nice to replace if-then-else with OO equivalents. Ofbiz has too

Defining required permissions at the controller request

2009-11-10 Thread Bob Morley
Have been working on some integration between the various modeled objects in Ofbiz and came across a requirement to allow specification of required permissions for a controller request. Effectively what I have been working on is the ability to walk various model graphs extend behaviour to one mod

Re: OFBiz Tests and Ant build.xml Files

2009-11-10 Thread Robert Morley
Adrian -- While this is probably not the best practice, what we have done is create a set of abstract base classes that extend the JUnit test case. Depending on the architectural layer we are testing, these may just provide some helper methods or they may start the container and allow us to ru

[jira] Commented: (OFBIZ-3169) Implementation of Budget functionality.

2009-11-10 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776266#action_12776266 ] Hans Bakker commented on OFBIZ-3169: Asish, excellent you starting this new feature an

Discussion: User-Defined Java Data Types In The Framework

2009-11-10 Thread Adrian Crum
I first started thinking of this idea in a Jira issue: https://issues.apache.org/jira/browse/OFBIZ-3125 I thought it would be easy to extend the framework to support a new Java object type (or class). I wanted to be able to pass around a TimeDuration instance in services, mini-lang, screen widg

Re: ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-10 Thread Ean Schuessler
Just wanted to weigh in here from a Brainfood perspective. Brainfood is very interested in using BIRT to solve reporting problems for customers. I am more interested in BIRT than Jasper Reports for several reasons including: good Eclipse integration which is good for in-house IT reporting capa

Re: ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-10 Thread Hans Bakker
You probably already found it, it is now a secondary application accessible in the same row as webtools. Regards, Hans On Tue, 2009-11-10 at 11:45 +0100, Jacopo Cappellato wrote: > Hans, > > would you be so kind to point me to the right file from here? > > https://svn.apache.org/repos/asf

[jira] Assigned: (OFBIZ-3125) Add a duration field type to improve input and representation of durations: DurationField, allows to show and input *d *h *m *s *ms

2009-11-10 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3125: -- Assignee: Adrian Crum > Add a duration field type to improve input and representation of durati

[jira] Commented: (OFBIZ-3169) Implementation of Budget functionality.

2009-11-10 Thread Sharan Foga (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776082#action_12776082 ] Sharan Foga commented on OFBIZ-3169: Hi Ashish Your high level process sounds OK but j

Re: Change in AgreementWorkEffortAppl entity

2009-11-10 Thread Jacopo Cappellato
+1 On Nov 10, 2009, at 6:25 PM, Bilgin Ibryam wrote: Hi all, I have a question regarding AgreementWorkEffortAppl entity. I need to assign WorkEfforts to an Agreement instead of separate Agreement Items, but current data model doesn't allow that. The reason is in the relations of AgreementWo

Change in AgreementWorkEffortAppl entity

2009-11-10 Thread Bilgin Ibryam
Hi all, I have a question regarding AgreementWorkEffortAppl entity. I need to assign WorkEfforts to an Agreement instead of separate Agreement Items, but current data model doesn't allow that. The reason is in the relations of AgreementWorkEffortAppl entity:

[jira] Closed: (OFBIZ-2326) Danish translations for framework

2009-11-10 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] André Herbst closed OFBIZ-2326. --- Resolution: Invalid > Danish translations for framework > - > >

[jira] Updated: (OFBIZ-3182) Danish translations for ContentUiLabels

2009-11-10 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] André Herbst updated OFBIZ-3182: Attachment: OFBIZ-3182_ContentUiLabels.patch > Danish translations for ContentUiLabels > --

[jira] Updated: (OFBIZ-3182) Danish translations for ContentUiLabels

2009-11-10 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] André Herbst updated OFBIZ-3182: Fix Version/s: SVN trunk > Danish translations for ContentUiLabels > --

[jira] Updated: (OFBIZ-3182) Danish translations for ContentUiLabels

2009-11-10 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] André Herbst updated OFBIZ-3182: Component/s: content Affects Version/s: SVN trunk Summary: Danish translatio

[jira] Created: (OFBIZ-3182) Danish translations for ContentUilabels

2009-11-10 Thread JIRA
Danish translations for ContentUilabels --- Key: OFBIZ-3182 URL: https://issues.apache.org/jira/browse/OFBIZ-3182 Project: OFBiz Issue Type: Sub-task Reporter: André Herbst -- This message

[jira] Issue Comment Edited: (OFBIZ-3178) error with stock move and reservation with quantity not available

2009-11-10 Thread Albert Mayo (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775935#action_12775935 ] Albert Mayo edited comment on OFBIZ-3178 at 11/10/09 4:45 PM: --

[jira] Updated: (OFBIZ-3178) error with stock move and reservation with quantity not available

2009-11-10 Thread Albert Mayo (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Albert Mayo updated OFBIZ-3178: --- Attachment: StockMoveServices.xml StockMoveServices.patch It looks like there was a c

[jira] Closed: (OFBIZ-3098) Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.

2009-11-10 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3098. -- Resolution: Fixed Thanks guys, Commited at r834527 > Improvement in input validation of 1s

Re: svn commit: r833725 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ service/src/org/ofbiz/service/ service/src/org/ofbiz/service/calendar/ service/src/org/ofbiz/service/config/ service/

2009-11-10 Thread Todor Spasov
Thanks Jacques for your fast reaction. Regards, Todor Spasov. On Nov 10, 2009, at 2:02 PM, Jacques Le Roux wrote: Fixed at r83 Jacques From: "Jacques Le Roux" Hi Todor, You are totally right. I will revert and apply initial Bob's changes. Thanks Jacques From: "Todor Spasov" Hell

Re: extra Birt information (also answers Scott questions)

2009-11-10 Thread Jacopo Cappellato
On Nov 10, 2009, at 3:47 PM, David E Jones wrote: Just keep in mind that if it goes into a specialpurpose component then "applications" components can't use it, meaning no embedded reports in the base applications. It's a tool and IMO makes most sense in the framework if it's going to

[jira] Commented: (OFBIZ-3098) Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.

2009-11-10 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775444#action_12775444 ] Ashish Vijaywargiya commented on OFBIZ-3098: Amit and Rohit thanks for the cont

Re: extra Birt information (also answers Scott questions)

2009-11-10 Thread Jacopo Cappellato
Sorry for the many emails, but I prefer to send them while I run my quick review (because I don't know if I will be able to complete it today and I prefer to give some feedback earlier). The build folder should be removed from svn: https://svn.apache.org/repos/asf/ofbiz/branches/addbirt/frame

Re: extra Birt information (also answers Scott questions)

2009-11-10 Thread Jacopo Cappellato
Hans, please also have a look at the license headers of new files; for example this one is missing its license header: https://svn.apache.org/repos/asf/ofbiz/branches/addbirt/framework/birt/src/org/ofbiz/birt/container/BirtContainer.java there could be others. Jacopo On Nov 10, 2009, at 4:

Re: extra Birt information (also answers Scott questions)

2009-11-10 Thread Jacopo Cappellato
Hans, there is a lot of redundancy with jars we have in OFBiz with the jars in: https://svn.apache.org/repos/asf/ofbiz/branches/addbirt/framework/birt/lib/platform/plugins/ Are all of them needed? I think we have to resolve this, and not only because this will greatly increase the download

[jira] Assigned: (OFBIZ-3098) Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.

2009-11-10 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-3098: -- Assignee: Ashish Vijaywargiya > Improvement in input validation of 1st step (sh

Re: extra Birt information (also answers Scott questions)

2009-11-10 Thread David E Jones
Just keep in mind that if it goes into a specialpurpose component then "applications" components can't use it, meaning no embedded reports in the base applications. It's a tool and IMO makes most sense in the framework if it's going to be used in any standard way. On a side note: I hope

[jira] Assigned: (OFBIZ-3173) Better supportability for products of type MARKETING_PKG_AUTO in order processing and fulfillment process.

2009-11-10 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-3173: -- Assignee: Ashish Vijaywargiya > Better supportability for products of type MARK

[jira] Closed: (OFBIZ-3158) Send item shipped request from OFBiz to Google in a collection instead of sending multiple request for each item shipped.

2009-11-10 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya closed OFBIZ-3158. -- Resolution: Fixed Thanks Ratnesh for bug reporting and Arun for providing quick fix for

[jira] Updated: (OFBIZ-3158) Send item shipped request from OFBiz to Google in a collection instead of sending multiple request for each item shipped.

2009-11-10 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-3158: Attachment: OFBIZ-3158.patch Here is a patch to fix issue of order completion from order detail pag

[jira] Reopened: (OFBIZ-3158) Send item shipped request from OFBiz to Google in a collection instead of sending multiple request for each item shipped.

2009-11-10 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reopened OFBIZ-3158: Reopening - There is some problem coming in order completion. Thanks Ratnesh for report

Re: extra Birt information (also answers Scott questions)

2009-11-10 Thread Shi Yusen
This discussion should be on architect level, not function level. Everybody likes Birt very much. Personally I think it's a special purpose component and should use/extend the BI interface. The BI interface is a great part of v09.04, beside data mining, it also makes it easy to set up mappings to

[jira] Created: (OFBIZ-3181) Change of theme preferences leads to changing the theme of the user

2009-11-10 Thread Pierre Smits (JIRA)
Change of theme preferences leads to changing the theme of the user --- Key: OFBIZ-3181 URL: https://issues.apache.org/jira/browse/OFBIZ-3181 Project: OFBiz Issue Type: Bug

Re: svn commit: r833725 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ service/src/org/ofbiz/service/ service/src/org/ofbiz/service/calendar/ service/src/org/ofbiz/service/config/ service/

2009-11-10 Thread Jacques Le Roux
Fixed at r83 Jacques From: "Jacques Le Roux" Hi Todor, You are totally right. I will revert and apply initial Bob's changes. Thanks Jacques From: "Todor Spasov" Hello Jacques, Could you take a look at this commit again and help me clear up my thoughts below: I think the changes done

Re: svn commit: r833725 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ service/src/org/ofbiz/service/ service/src/org/ofbiz/service/calendar/ service/src/org/ofbiz/service/config/ service/

2009-11-10 Thread Jacques Le Roux
Hi Todor, You are totally right. I will revert and apply initial Bob's changes. Thanks Jacques From: "Todor Spasov" Hello Jacques, Could you take a look at this commit again and help me clear up my thoughts below: I think the changes done to RecurrenceRule.java from this commit (see lines

[jira] Commented: (OFBIZ-3169) Implementation of Budget functionality.

2009-11-10 Thread ashish tiwari (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775382#action_12775382 ] ashish tiwari commented on OFBIZ-3169: -- Hi all, I have not received any comment regar

[jira] Updated: (OFBIZ-3169) Implementation of Budget functionality.

2009-11-10 Thread ashish tiwari (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ashish tiwari updated OFBIZ-3169: - Comment: was deleted (was: Till date i hav not recieved any comments. This is just to inform you

[jira] Commented: (OFBIZ-3169) Implementation of Budget functionality.

2009-11-10 Thread ashish tiwari (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775379#action_12775379 ] ashish tiwari commented on OFBIZ-3169: -- Till date i hav not recieved any comments. Thi

Re: svn commit: r833725 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ service/src/org/ofbiz/service/ service/src/org/ofbiz/service/calendar/ service/src/org/ofbiz/service/config/ service/

2009-11-10 Thread Todor Spasov
Hello Jacques, Could you take a look at this commit again and help me clear up my thoughts below: I think the changes done to RecurrenceRule.java from this commit (see lines 504 to 645) aren't logically equivallent because fragments such as: if (UtilValidate.isNotEmpty(byMonthLi

[jira] Updated: (OFBIZ-3098) Improvement in input validation of 1st step (shopping cart) on onePageCheckout page.

2009-11-10 Thread Amit Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Sharma updated OFBIZ-3098: --- Attachment: OFBIZ-3098.patch Here is the updated patch at revision 834421. Thanks Arun. Regards, -Am

Re: ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-10 Thread Jacopo Cappellato
Hans, would you be so kind to point me to the right file from here? https://svn.apache.org/repos/asf/ofbiz/branches/addbirt/framework/webtools/ Thank you Jacopo On Nov 10, 2009, at 11:18 AM, Hans Bakker wrote: Jacopo, download the branch, look in webtools, there is an example and help scre

Re: ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-10 Thread Hans Bakker
Jacopo, download the branch, look in webtools, there is an example and help screens. Regards, Hans On Tue, 2009-11-10 at 11:12 +0100, Jacopo Cappellato wrote: > Hi Hans, > > frankly speaking I had no time to play with your integration or with > Birt in general, but I have a question: what ki

Re: ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-10 Thread Jacopo Cappellato
Hi Hans, frankly speaking I had no time to play with your integration or with Birt in general, but I have a question: what kind of integration you did? I mean, what is the architectural strategy for the integration, what is the custom code you wrote? If you could send me the links to the cu

[jira] Closed: (OFBIZ-3158) Send item shipped request from OFBiz to Google in a collection instead of sending multiple request for each item shipped.

2009-11-10 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya closed OFBIZ-3158. -- Resolution: Fixed Thanks Pranay / Arun - Done at r834385. -- Ashish Vijaywargiya > Se