[jira] [Closed] (OFBIZ-4405) Some inefficient Map iterations

2011-09-13 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4405. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri for your effort, your small mo

[jira] [Commented] (OFBIZ-4412) Set initial ecommerce Locale/Currency based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm

2011-09-13 Thread Dimitri Unruh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104298#comment-13104298 ] Dimitri Unruh commented on OFBIZ-4412: -- In the productStore entity we already have de

Re: svn commit: r1170442 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java

2011-09-13 Thread Adrian Crum
I remember when I first started contributing code to this project, I was chastised for using single-line if blocks. -Adrian On 9/14/2011 7:18 AM, jler...@apache.org wrote: Author: jleroux Date: Wed Sep 14 06:18:26 2011 New Revision: 1170442 URL: http://svn.apache.org/viewvc?rev=1170442&view=r

Re: Wrong demo data in trunk demo

2011-09-13 Thread Paul Foxworthy
Oh, I missed Adrian's commit at r1170125. Never mind. Cheers Paul Foxworthy Paul Foxworthy wrote: > > Hi Jacques and Adrian, > > I understand the issue in general for custom classes: if we want to use > them with UtilValidate.isEmpty, we need to implement the IsEmpty > interface. > > But Fl

Re: Wrong demo data in trunk demo

2011-09-13 Thread Paul Foxworthy
Hi Jacques and Adrian, I understand the issue in general for custom classes: if we want to use them with UtilValidate.isEmpty, we need to implement the IsEmpty interface. But FlexibleStringExpander *does* implement IsEmpty as an abstract method. Its descendant, ArrayOffsetString, implements it to

[jira] [Updated] (OFBIZ-4412) Set initial ecommerce Locale/Currency based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm

2011-09-13 Thread mz4wheeler (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mz4wheeler updated OFBIZ-4412: -- Summary: Set initial ecommerce Locale/Currency based on mount point specified in specialpurpose/ecommer

[jira] [Updated] (OFBIZ-4412) Set initial ecommerce Local/Currencey based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm

2011-09-13 Thread mz4wheeler (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mz4wheeler updated OFBIZ-4412: -- Attachment: OFBIZ-4412.patch > Set initial ecommerce Local/Currencey based on mount point specified in

[jira] [Created] (OFBIZ-4412) Set initial ecommerce Local/Currencey based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm

2011-09-13 Thread mz4wheeler (JIRA)
Set initial ecommerce Local/Currencey based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm --- Key: OFBIZ-4412 URL: https://is

[jira] [Created] (OFBIZ-4411) QuickCheckout -> New Address -> Back functionality doesn't work

2011-09-13 Thread Kiran Gawde (JIRA)
QuickCheckout -> New Address -> Back functionality doesn't work --- Key: OFBIZ-4411 URL: https://issues.apache.org/jira/browse/OFBIZ-4411 Project: OFBiz Issue Type: Bug Co

[jira] [Issue Comment Edited] (OFBIZ-4409) Agreement issues

2011-09-13 Thread Carlos Guzman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103694#comment-13103694 ] Carlos Guzman edited comment on OFBIZ-4409 at 9/13/11 3:33 PM: -

[jira] [Closed] (OFBIZ-4409) Agreement issues

2011-09-13 Thread Carlos Guzman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carlos Guzman closed OFBIZ-4409. Resolution: Fixed Fix Version/s: SVN trunk with last modifications on trunk the problem gone

Re: Wrong demo data in trunk demo

2011-09-13 Thread Jacques Le Roux
Thanks Adrian, Indeed it seems to have fixed the issue. We should now care about cases where a custom object is passed to UtilValidate.is(No)tEmpty(). I will have a look at possible existing issue (there were already some undetected so far in ModelFormField) For the moment in ObjectType.isEmpt

Re: widgetVerbose

2011-09-13 Thread Dimitri Unruh
+1 Dimitri Unruh Consultant AEW Lynx-Consulting GmbH Johanniskirchplatz 6 33615 Bielefeld Deutschland Fon: +49 521 5247-0 Fax: +49 521 5247-250 Mobil: +49 160 90 57 55 13 Company and Management Headquarters: Lynx-Consulting GmbH, Johanniskirchplatz 6, 33615 Bielefeld, Deutschland Fon: +49 521 5

Re: widgetVerbose

2011-09-13 Thread Bilgin Ibryam
On Tue, Sep 13, 2011 at 9:54 AM, Adrian Crum wrote: > Thanks Scott - those are my feelings exactly. > > I like the way the design worked previously, and changing it because a user > might accidentally leave the comments enabled in production seems silly. > That is a user's QC problem, not a widget

Re: Wrong demo data in trunk demo

2011-09-13 Thread Adrian Crum
Rev 1170125 should solve the UtilValidate problem. -Adrian On 9/13/2011 11:56 AM, Jacques Le Roux wrote: I'm also curious about it. It 's a bummer but I have no time atm to get it into details. I reverted my changes in ModelFormField class to r1169754. Trunk will be back correctly again soon..

Re: Wrong demo data in trunk demo

2011-09-13 Thread Hans Bakker
looks ok now, thanks jacques On Tue, 2011-09-13 at 12:56 +0200, Jacques Le Roux wrote: > I'm also curious about it. It 's a bummer but I have no time atm to get it > into details. I reverted my changes in ModelFormField > class to r1169754. Trunk will be back correctly again soon... > > Jacques

Re: Wrong demo data in trunk demo

2011-09-13 Thread Jacques Le Roux
I'm also curious about it. It 's a bummer but I have no time atm to get it into details. I reverted my changes in ModelFormField class to r1169754. Trunk will be back correctly again soon... Jacques From: "Adrian Crum" Just curious - why can't UtilValidate check for an empty FSE? -Adrian On

Re: Wrong demo data in trunk demo

2011-09-13 Thread Adrian Crum
Just curious - why can't UtilValidate check for an empty FSE? -Adrian On 9/13/2011 11:45 AM, Jacques Le Roux wrote: OK I see this is because there are more FlexibleStringExpanders than description (UtilValidate.is(No)tEmpty() can't be used ) , reverting all those... I will restart trunk after.

Re: Wrong demo data in trunk demo

2011-09-13 Thread Jacques Le Roux
OK I see this is because there are more FlexibleStringExpanders than description (UtilValidate.is(No)tEmpty() can't be used ) , reverting all those... I will restart trunk after... Jacques From: "Hans Bakker" Jacques , because of your refactoring we are now the second day in the problems, th

Re: Wrong demo data in trunk demo

2011-09-13 Thread Hans Bakker
Jacques , because of your refactoring we are now the second day in the problems, the trunk is back, but have a look at the header of the invoices list this is only an example...most are wrong Regards, Hans On Tue, 2011-09-13 at 12:17 +0200, Jacques Le Roux wrote: > It's now fixed, the trun

Wrong demo data in trunk demo

2011-09-13 Thread Jacques Le Roux
It's now fixed, the trunk demo is back again Jacques

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-13 Thread Jacques Le Roux
Hi Hans, It works here but not on trunk demo. here: invoices list with Id trunk: no invoices list You: ? I will check trunk demo log... Jacques From: "Hans Bakker" Jacques, still not working , have a look at the accounting invoicelist and press find.. Regards, Hans On Mon, 2011-09-12

Re: svn commit: r1169478 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/marketing/src/org/ofbiz/

2011-09-13 Thread Hans Bakker
Jacques, still not working , have a look at the accounting invoicelist and press find.. Regards, Hans On Mon, 2011-09-12 at 15:11 +0200, Jacques Le Roux wrote: > OK, I found another one, looks like my double-check needed another check :/ > > Jacques > > From: "Hans Bakker" > > The log er

Re: widgetVerbose

2011-09-13 Thread Jacques Le Roux
+1 Jacques From: "Adrian Crum" Thanks Scott - those are my feelings exactly. I like the way the design worked previously, and changing it because a user might accidentally leave the comments enabled in production seems silly. That is a user's QC problem, not a widget comment design problem.

Re: widgetVerbose

2011-09-13 Thread Adrian Crum
Thanks Scott - those are my feelings exactly. I like the way the design worked previously, and changing it because a user might accidentally leave the comments enabled in production seems silly. That is a user's QC problem, not a widget comment design problem. -Adrian On 9/13/2011 8:55 AM,

Re: widgetVerbose

2011-09-13 Thread Scott Gray
Sorry I'm a bit lost, is the latest proposal something like this: if (widget.properties.enableBoundaryComments == null) { // widget.properties not set, only show where specified as true if (context.enableBoundaryComments != null) return context.enableBoundaryComments; return false;

buildbot success in ASF Buildbot on ofbiz-trunk

2011-09-13 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/2108 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source St

Re: svn commit: r1163084 - in /ofbiz/trunk: ./ applications/accounting/script/org/ofbiz/accounting/test/ applications/accounting/testdef/ framework/testtools/lib/ framework/testtools/src/org/ofbiz/tes

2011-09-13 Thread Hans Bakker
Thank you for reporting Jacques and Adrian. Committed revision 1170063 Regards, Hans On Mon, 2011-09-12 at 23:01 +0200, Jacques Le Roux wrote: > Bump... > > Jacques > > From: "Adrian Crum" > >I noticed that too. A file is created in the main ofbiz folder and it is not > >deleted after the t