[jira] [Comment Edited] (OFBIZ-5113) Update wiki documentation on load data

2014-08-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116332#comment-14116332 ] Jacques Le Roux edited comment on OFBIZ-5113 at 8/31/14 7:27 AM:

[jira] [Commented] (OFBIZ-5704) Extend lot entity to include party Id of manufacturer

2014-08-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116661#comment-14116661 ] Jacques Le Roux commented on OFBIZ-5704: [~pfm.smits] I don't clearly understand

[jira] [Commented] (OFBIZ-5737) Add/Revise Traditional Chinese (zh-TW) translations in framework

2014-08-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116662#comment-14116662 ] Jacques Le Roux commented on OFBIZ-5737: @nhlotwn I have asked [~shi.jinghai] if

[jira] [Assigned] (OFBIZ-5733) Update Derby to last 10.11.1.1 version (security fixes included)

2014-08-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-5733: -- Assignee: Jacques Le Roux Update Derby to last 10.11.1.1 version (security fixes

Discussion: Service Engine Refactoring

2014-08-31 Thread Adrian Crum
Currently, the service engine classes are a bit muddled. GenericDispatcher (the default LocalDispatcher implementation) and DispatchContext have feature envy. Some functionality in DispatchContext belongs in ServiceDispatcher. I would like to clean this up a bit and provide better separation

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Jacopo Cappellato
Thank you Adrian, please see inline: On Aug 31, 2014, at 10:50 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: Currently, the service engine classes are a bit muddled. GenericDispatcher (the default LocalDispatcher implementation) and DispatchContext have feature envy. Some

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Jacopo Cappellato
On Aug 31, 2014, at 10:50 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: However, it will open up the possibility to improve the API. For example, instead of this service implementation: public static MapString, Object myService(DispatchContext dctx, MapString, Object

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Jacopo Cappellato
On Aug 31, 2014, at 11:36 AM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: a) what is the original concern of DispatchContext and of GenericDispatcher This comes from this old but still interesting document: http://ofbiz.apache.org/docs/services.html

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Adrian Crum
That last paragraph describes the cleanup I want to do. If a LocalDispatcher contains things specific to an application, then why are some of those things kept in GenericDispatcher and others are kept in DispatchContext? This is the feature-envy part - they are both trying to be the same

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Adrian Crum
Inline... Adrian Crum Sandglass Software www.sandglass-software.com On 8/31/2014 10:36 AM, Jacopo Cappellato wrote: Thank you Adrian, please see inline: On Aug 31, 2014, at 10:50 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: Currently, the service engine classes are a bit

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Pierre @GMail
That is a nice piece of explanation. Should be part of the documentation, if it is not already. Regards, Pierre Sent from my iPhone On 31 aug. 2014, at 11:56, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: On Aug 31, 2014, at 11:36 AM, Jacopo Cappellato

Re: [VOTE] [RELEASE] Apache OFBiz 11.04.06

2014-08-31 Thread Jacques Le Roux
+1 MD5 OK Tests unsuccessful on Win7 (2 times, last one: ant clean-all run-install run-tests) failures: testReadWriteObject testCountViews errors: testRemoveByCondition testRemoveByPK testRemoveType testCreateManyAndStoreAtOnce

Re: [VOTE] [RELEASE] Apache OFBiz 12.04.05

2014-08-31 Thread Jacques Le Roux
+1 MD5 OK Tests unsuccessful on Win7, failures: testForeignKeyRemove testStoreByCondition testMakeValue errors: testUpdateValue testRemoveValue testEntityCache testAddMembersToTree Test OK on Unbuntu 13 Jacques Le 30/08/2014

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Adrian Crum
That's fine. The opportunity will be there if anyone wants to explore it. It is not something I will push for. Adrian Crum Sandglass Software www.sandglass-software.com On 8/31/2014 10:54 AM, Jacopo Cappellato wrote: On Aug 31, 2014, at 10:50 AM, Adrian Crum

[jira] [Closed] (OFBIZ-5733) Update Derby to last 10.11.1.1 version (security fixes included)

2014-08-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5733. -- Resolution: Done Fix Version/s: Upcoming Branch Done at r1621581 Update Derby to last

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Jacques Le Roux
For now there is only a link to services.html from the tutorial. The best place to add another link seems https://cwiki.apache.org/confluence/display/OFBTECH/Service+Engine+Guide Jacques Le 31/08/2014 12:14, Pierre @GMail a écrit : That is a nice piece of explanation. Should be part of the

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Adrian Crum
Here is some ASCII art that might help: DispatchContext (a container for objects needed by service implementations) | |__ (references) LocalDispatcher (an application-specific service dispatcher) | |__ (delegates to) ServiceDispatcher

Re: svn commit: r1621581 - in /ofbiz/trunk: LICENSE framework/entity/lib/jdbc/derby-10.10.2.0.jar framework/entity/lib/jdbc/derby-10.11.1.1.jar

2014-08-31 Thread Adrian Crum
I am not getting any test failures on Windows. Adrian Crum Sandglass Software www.sandglass-software.com On 8/31/2014 11:18 AM, jler...@apache.org wrote: Author: jleroux Date: Sun Aug 31 10:18:38 2014 New Revision: 1621581 URL: http://svn.apache.org/r1621581 Log: Upgrades Derby from

Re: svn commit: r1621581 - in /ofbiz/trunk: LICENSE framework/entity/lib/jdbc/derby-10.10.2.0.jar framework/entity/lib/jdbc/derby-10.11.1.1.jar

2014-08-31 Thread Jacques Le Roux
Thanks, good news, I don't know why I got them, like I did with 12 and 11 releases :/ Jacques Le 31/08/2014 12:50, Adrian Crum a écrit : I am not getting any test failures on Windows. Adrian Crum Sandglass Software www.sandglass-software.com On 8/31/2014 11:18 AM, jler...@apache.org wrote:

Re: svn commit: r1621581 - in /ofbiz/trunk: LICENSE framework/entity/lib/jdbc/derby-10.10.2.0.jar framework/entity/lib/jdbc/derby-10.11.1.1.jar

2014-08-31 Thread Jacques Le Roux
Ah forgot, also OK on Buildbot http://ci.apache.org/projects/ofbiz/logs/trunk/html/ I hope Gavin will find some time to cure our RAT report http://ci.apache.org/builders/ofbiz-trunk/builds/249 https://issues.apache.org/jira/browse/INFRA-8181 Jacques Le 31/08/2014 13:19, Jacques Le Roux a

Re: svn commit: r1621581 - in /ofbiz/trunk: LICENSE framework/entity/lib/jdbc/derby-10.10.2.0.jar framework/entity/lib/jdbc/derby-10.11.1.1.jar

2014-08-31 Thread Jacques Le Roux
Actually it was this one http://ci.apache.org/builders/ofbiz-trunk/builds/251 Anyway Jacques Le 31/08/2014 13:22, Jacques Le Roux a écrit : Ah forgot, also OK on Buildbot http://ci.apache.org/projects/ofbiz/logs/trunk/html/ I hope Gavin will find some time to cure our RAT report

[jira] [Commented] (OFBIZ-5729) ofbiz hangs on installing tenant database

2014-08-31 Thread Wai (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116812#comment-14116812 ] Wai commented on OFBIZ-5729: Hello, Any status on integrating this patch??? Thanks ofbiz

Re: Discussion: Service Engine Refactoring

2014-08-31 Thread Adrian Crum
I have this done. The change is quite subtle, and it will pave the way for removing GenericDelegator references from the service engine. I will wait a few days before committing so others have time to respond. Adrian Crum Sandglass Software www.sandglass-software.com On 8/31/2014 9:50 AM,

[jira] [Updated] (OFBIZ-5741) Convert ProductStore entites CRUD service from simple to entity-auto

2014-08-31 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-5741: - Attachment: OFBIZ-5741.patch Convert ProductStore entites CRUD service from simple to

[jira] [Created] (OFBIZ-5741) Convert ProductStore entites CRUD service from simple to entity-auto

2014-08-31 Thread Nicolas Malin (JIRA)
Nicolas Malin created OFBIZ-5741: Summary: Convert ProductStore entites CRUD service from simple to entity-auto Key: OFBIZ-5741 URL: https://issues.apache.org/jira/browse/OFBIZ-5741 Project: OFBiz

[jira] [Created] (OFBIZ-5742) Convert CostComponent and Subscription entites CRUD service from simple to entity-auto

2014-08-31 Thread Nicolas Malin (JIRA)
Nicolas Malin created OFBIZ-5742: Summary: Convert CostComponent and Subscription entites CRUD service from simple to entity-auto Key: OFBIZ-5742 URL: https://issues.apache.org/jira/browse/OFBIZ-5742

[jira] [Commented] (OFBIZ-5737) Add/Revise Traditional Chinese (zh-TW) translations in framework

2014-08-31 Thread Nick Ho (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116931#comment-14116931 ] Nick Ho commented on OFBIZ-5737: Thank you for the coordination. I'll continue the