Hi, It seems there is still some issues in trunk. The following steps to
reproduce the error
(1) Go to Accounting
(2) then go to Organizational GL settings
(3) Select Accounting
(4) Select Report from the menu
(5)then select TransactionTotals
2014-10-29 11:56:51,527 |http-bio-8443-exec-6
Hi,
As I'm working on the bootstrap theme branch, I notice that:
1. menuStringRenderer is out-commettted in the MacroScreenViewhandler class;
2. This being the case, that menus get rendered by default through the
HtmlMenuRenderer class;
3. The latter automatically creates ulliul opening tags for
[
https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Patidar updated OFBIZ-5842:
Attachment: OFBIZ-5842.patch
Attached is the patch for the same. Please review and provide your
[
https://issues.apache.org/jira/browse/OFBIZ-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188247#comment-14188247
]
Jacques Le Roux commented on OFBIZ-5835:
Did you try to download again? Do you
No, line 90:
macroLibraryPath = UtilProperties.getPropertyValue(widget, getName() +
.menurenderer);
loads the macro menu renderer.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/29/2014 11:07 AM, Gavin Mabie wrote:
Hi,
As I'm working on the bootstrap theme branch, I
[
https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188258#comment-14188258
]
Adrian Crum commented on OFBIZ-5842:
If the assertEquals method is testing for
[
https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188280#comment-14188280
]
Jacopo Cappellato commented on OFBIZ-5842:
--
+1 to Adrian's comment: the text in
[
https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188296#comment-14188296
]
Arun Patidar commented on OFBIZ-5842:
-
Thanks Adrian and Jacopo for your comments.
[
https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Patidar updated OFBIZ-5842:
Attachment: OFBIZ-5842.patch
Updated assert messages and attached modified patch.
Implement JUnit
Hi Gavin, Adrian and all,
I was thinking about move sub-menu generation by header.ftl or
appbarOpen.ftl in theme folder like main menu...
Can we move the macro in the theme folder or create a service that send
sub-menu entry sorted list ?
It could be useful to create specific webdesign if
I don't understand the question. Could you ask it in another way please?
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/29/2014 1:39 PM, Julien NICOLAS wrote:
Hi Gavin, Adrian and all,
I was thinking about move sub-menu generation by header.ftl or
appbarOpen.ftl in theme
Adrian,
It's just : Why html structure for sub-menu is not managed like main menu ?
Is it possible to use sub-menu like main menu ?
Maybe we can move macro from framework folder to theme folder.
hope you understand better in this way :)
Thanks for your help,
Julien.
Le 29/10/2014 15:22,
If you are referring to the main navigation menu:
div id=main-navigation
that uses a template instead of a menu widget - it is done that way
simply because no one has tried to do it differently. Personally, I
would like to see it changed to a menu widget.
Regarding the existing FreeMarker
Indeed, it does appear on line 90 of MacroScreenViewHandler.java in
ofbiz/branches/bootstrap_theme. I was referring to the
MacroScreenViewHandler.java in ofbiz/branches/frontendNewTheme2013-05-10.
I will revert to the former from henceforth.
Thanks
On Wed, Oct 29, 2014 at 1:30 PM, Adrian Crum
That is why I created the new branch - that other one was outdated.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/29/2014 3:44 PM, Gavin Mabie wrote:
Indeed, it does appear on line 90 of MacroScreenViewHandler.java in
ofbiz/branches/bootstrap_theme. I was referring to the
Hi Julien, Adrian
IMO that we should try to define all menus via menu widgets. So I'm
inclined to agree with Adrian on the issue of the main-navigation menu.
Maybe this is something we should include in our Bootstrap project.
Loading macros as Visual Visual Theme resources might also address
[
https://issues.apache.org/jira/browse/OFBIZ-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-5843.
--
Resolution: Implemented
Completed: At revision: 1635192
Improve storeOrder service
Jacques Le Roux created OFBIZ-5843:
--
Summary: Improve storeOrder service performance and reliability
Key: OFBIZ-5843
URL: https://issues.apache.org/jira/browse/OFBIZ-5843
Project: OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188543#comment-14188543
]
Jacques Le Roux edited comment on OFBIZ-5843 at 10/29/14 5:34 PM:
Jacques,
what was the measured difference between the method call to the Java method and
the service call to the Java implementation?
Jacopo
On Oct 29, 2014, at 5:37 PM, jler...@apache.org wrote:
Author: jleroux
Date: Wed Oct 29 16:37:40 2014
New Revision: 1635192
URL:
I see a serious problem with this commit:
MapString, Object countContext = new HashMapString, Object();
is wrong.
Use the DispatchContext to build the service context from the existing
context Map - so the framework-inserted artifacts are included in the Map.
Adrian Crum
Sandglass Software
I'm not Jacques, but I'm pretty sure there is very little difference.
The disadvantage to hacks like this: Bypassing the service engine like
this will prevent any SECAs attached to the called service from being
invoked.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/29/2014
Le 29/10/2014 18:50, Jacopo Cappellato a écrit :
Jacques,
what was the measured difference between the method call to the Java method and
the service call to the Java implementation?
Apart what I reported in the commit comment and the Jira description, I did not make other measures. Before
Le 29/10/2014 19:02, Adrian Crum a écrit :
I see a serious problem with this commit:
MapString, Object countContext = new HashMapString, Object();
is wrong.
Use the DispatchContext to build the service context from the existing context
Map - so the framework-inserted artifacts are included
The reason is this:
Don't do that!
Use best practices or revert it.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/29/2014 7:26 PM, Jacques Le Roux wrote:
Le 29/10/2014 19:02, Adrian Crum a écrit :
I see a serious problem with this commit:
MapString, Object countContext =
Le 29/10/2014 19:22, Adrian Crum a écrit :
I'm not Jacques, but I'm pretty sure there is very little difference. The disadvantage to hacks like this: Bypassing the service engine like this
will prevent any SECAs attached to the called service from being invoked.
OOTB there are any SECAs
This commit is an ugly hack. Why are you defending it? Just fix it.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/29/2014 7:37 PM, Jacques Le Roux wrote:
Le 29/10/2014 19:22, Adrian Crum a écrit :
I'm not Jacques, but I'm pretty sure there is very little difference.
The
You mean by using DispatchContext? What does it add in this context?
Jacques
Le 29/10/2014 20:44, Adrian Crum a écrit :
This commit is an ugly hack. Why are you defending it? Just fix it.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/29/2014 7:37 PM, Jacques Le Roux wrote:
[
https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188996#comment-14188996
]
Jacques Le Roux commented on OFBIZ-5312:
Could you specify the context, by an use
[
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189006#comment-14189006
]
Jacques Le Roux commented on OFBIZ-2208:
You mean witht the same version of MySQL?
Hi,
I'm sorry but I'm not sure to understand well the goal...
We'll modify the framework to match with bootstrap but, if we have to do
UI modification, we have to do it in the framework ?!
If macros stay in the framework I don't understand how to be as flexible
as we need if anytime we have to
[
https://issues.apache.org/jira/browse/OFBIZ-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189031#comment-14189031
]
Jacques Le Roux commented on OFBIZ-5672:
Ouch, 6149 lines to review, this not for
[
https://issues.apache.org/jira/browse/OFBIZ-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189055#comment-14189055
]
Julien NICOLAS commented on OFBIZ-5672:
---
So true... I was making this first version
[
https://issues.apache.org/jira/browse/OFBIZ-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189120#comment-14189120
]
Jacques Le Roux commented on OFBIZ-4769:
I think I will review more and will try
[
https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-5434:
--
Assignee: Jacques Le Roux (was: Ashish Vijaywargiya)
Improvement of Dutch
[
https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189146#comment-14189146
]
Jacques Le Roux commented on OFBIZ-5434:
Pierre your patch seems outdated, could
[
https://issues.apache.org/jira/browse/OFBIZ-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-5813.
--
Resolution: Won't Fix
Move non-core components from the Applications stack to SpecialPurpose
[
https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189159#comment-14189159
]
Jacques Le Roux commented on OFBIZ-5434:
Note for committers: OFBIZ-5764 must be
[
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189219#comment-14189219
]
Ingo Wolfmayr commented on OFBIZ-2208:
--
When I checked the database entries the
[
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189233#comment-14189233
]
Frank Lam commented on OFBIZ-2208:
--
unsubscribe frl...@gmail.com
ServerHit aborts
[
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189242#comment-14189242
]
Frank Lam commented on OFBIZ-2208:
--
Hah. Well that didn't work.
Jira needs to provide
[
https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189250#comment-14189250
]
Ingo Wolfmayr commented on OFBIZ-5312:
--
I create an image teaser on the start page of
[
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189273#comment-14189273
]
Paul Foxworthy commented on OFBIZ-2208:
---
Changing the data type to include
43 matches
Mail list logo
